Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid repeated value read in SubtractionAnimatedNode

Browse Source 
Summary:
Minor optimization, but spotted this while reviewing the implementation for D33622997

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D33622996

fbshipit-source-id: 8712753803fc46e6a046d50f77454a813e4a641a
This commit is contained in:
Pieter De Baets
2022-01-18 13:51:58 -08:00
committed by Facebook GitHub Bot
parent b2105711a0
commit 08e76772fe
5 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/animated/AdditionAnimatedNode.java
+1 -1
View File
@@ -39,7 +39,7 @@ import com.facebook.react.bridge.ReadableMap;
mValue += ((ValueAnimatedNode) animatedNode).getValue();
} else {
throw new JSApplicationCausedNativeException(
"Illegal node ID set as an input for " + "Animated.Add node");
"Illegal node ID set as an input for Animated.Add node");
}
}
}
ReactAndroid/src/main/java/com/facebook/react/animated/DiffClampAnimatedNode.java
+1 -1
View File
@@ -41,7 +41,7 @@ import com.facebook.react.bridge.ReadableMap;
AnimatedNode animatedNode = mNativeAnimatedNodesManager.getNodeById(mInputNodeTag);
if (animatedNode == null || !(animatedNode instanceof ValueAnimatedNode)) {
throw new JSApplicationCausedNativeException(
"Illegal node ID set as an input for " + "Animated.DiffClamp node");
"Illegal node ID set as an input for Animated.DiffClamp node");
}
return ((ValueAnimatedNode) animatedNode).getValue();
ReactAndroid/src/main/java/com/facebook/react/animated/ModulusAnimatedNode.java
+2 -2
View File
@@ -27,11 +27,11 @@ import com.facebook.react.bridge.ReadableMap;
public void update() {
AnimatedNode animatedNode = mNativeAnimatedNodesManager.getNodeById(mInputNode);
if (animatedNode != null && animatedNode instanceof ValueAnimatedNode) {
final double value = ((ValueAnimatedNode) animatedNode).getValue();
double value = ((ValueAnimatedNode) animatedNode).getValue();
mValue = (value % mModulus + mModulus) % mModulus;
} else {
throw new JSApplicationCausedNativeException(
"Illegal node ID set as an input for " + "Animated.modulus node");
"Illegal node ID set as an input for Animated.modulus node");
}
}
ReactAndroid/src/main/java/com/facebook/react/animated/MultiplicationAnimatedNode.java
+1 -1
View File
@@ -39,7 +39,7 @@ import com.facebook.react.bridge.ReadableMap;
mValue *= ((ValueAnimatedNode) animatedNode).getValue();
} else {
throw new JSApplicationCausedNativeException(
"Illegal node ID set as an input for " + "Animated.multiply node");
"Illegal node ID set as an input for Animated.multiply node");
}
}
}
ReactAndroid/src/main/java/com/facebook/react/animated/SubtractionAnimatedNode.java
+3 -3
View File
@@ -38,12 +38,12 @@ import com.facebook.react.bridge.ReadableMap;
double value = ((ValueAnimatedNode) animatedNode).getValue();
if (i == 0) {
mValue = value;
continue;
} else {
mValue -= value;
}
mValue -= ((ValueAnimatedNode) animatedNode).getValue();
} else {
throw new JSApplicationCausedNativeException(
"Illegal node ID set as an input for " + "Animated.subtract node");
"Illegal node ID set as an input for Animated.subtract node");
}
}
}