From 08e76772fe022e3fb566c8de7de229d304e5a200 Mon Sep 17 00:00:00 2001 From: Pieter De Baets Date: Tue, 18 Jan 2022 13:51:58 -0800 Subject: [PATCH] Avoid repeated value read in SubtractionAnimatedNode Summary: Minor optimization, but spotted this while reviewing the implementation for D33622997 Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D33622996 fbshipit-source-id: 8712753803fc46e6a046d50f77454a813e4a641a --- .../com/facebook/react/animated/AdditionAnimatedNode.java | 2 +- .../com/facebook/react/animated/DiffClampAnimatedNode.java | 2 +- .../com/facebook/react/animated/ModulusAnimatedNode.java | 4 ++-- .../facebook/react/animated/MultiplicationAnimatedNode.java | 2 +- .../facebook/react/animated/SubtractionAnimatedNode.java | 6 +++--- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/animated/AdditionAnimatedNode.java b/ReactAndroid/src/main/java/com/facebook/react/animated/AdditionAnimatedNode.java index c6f21ac735f..6b72b32e516 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/animated/AdditionAnimatedNode.java +++ b/ReactAndroid/src/main/java/com/facebook/react/animated/AdditionAnimatedNode.java @@ -39,7 +39,7 @@ import com.facebook.react.bridge.ReadableMap; mValue += ((ValueAnimatedNode) animatedNode).getValue(); } else { throw new JSApplicationCausedNativeException( - "Illegal node ID set as an input for " + "Animated.Add node"); + "Illegal node ID set as an input for Animated.Add node"); } } } diff --git a/ReactAndroid/src/main/java/com/facebook/react/animated/DiffClampAnimatedNode.java b/ReactAndroid/src/main/java/com/facebook/react/animated/DiffClampAnimatedNode.java index 48efbe1d3a8..de356762c80 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/animated/DiffClampAnimatedNode.java +++ b/ReactAndroid/src/main/java/com/facebook/react/animated/DiffClampAnimatedNode.java @@ -41,7 +41,7 @@ import com.facebook.react.bridge.ReadableMap; AnimatedNode animatedNode = mNativeAnimatedNodesManager.getNodeById(mInputNodeTag); if (animatedNode == null || !(animatedNode instanceof ValueAnimatedNode)) { throw new JSApplicationCausedNativeException( - "Illegal node ID set as an input for " + "Animated.DiffClamp node"); + "Illegal node ID set as an input for Animated.DiffClamp node"); } return ((ValueAnimatedNode) animatedNode).getValue(); diff --git a/ReactAndroid/src/main/java/com/facebook/react/animated/ModulusAnimatedNode.java b/ReactAndroid/src/main/java/com/facebook/react/animated/ModulusAnimatedNode.java index 707ec9bd752..f5ec5b7bb3c 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/animated/ModulusAnimatedNode.java +++ b/ReactAndroid/src/main/java/com/facebook/react/animated/ModulusAnimatedNode.java @@ -27,11 +27,11 @@ import com.facebook.react.bridge.ReadableMap; public void update() { AnimatedNode animatedNode = mNativeAnimatedNodesManager.getNodeById(mInputNode); if (animatedNode != null && animatedNode instanceof ValueAnimatedNode) { - final double value = ((ValueAnimatedNode) animatedNode).getValue(); + double value = ((ValueAnimatedNode) animatedNode).getValue(); mValue = (value % mModulus + mModulus) % mModulus; } else { throw new JSApplicationCausedNativeException( - "Illegal node ID set as an input for " + "Animated.modulus node"); + "Illegal node ID set as an input for Animated.modulus node"); } } diff --git a/ReactAndroid/src/main/java/com/facebook/react/animated/MultiplicationAnimatedNode.java b/ReactAndroid/src/main/java/com/facebook/react/animated/MultiplicationAnimatedNode.java index 25e3a7ae33a..1053457a7bd 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/animated/MultiplicationAnimatedNode.java +++ b/ReactAndroid/src/main/java/com/facebook/react/animated/MultiplicationAnimatedNode.java @@ -39,7 +39,7 @@ import com.facebook.react.bridge.ReadableMap; mValue *= ((ValueAnimatedNode) animatedNode).getValue(); } else { throw new JSApplicationCausedNativeException( - "Illegal node ID set as an input for " + "Animated.multiply node"); + "Illegal node ID set as an input for Animated.multiply node"); } } } diff --git a/ReactAndroid/src/main/java/com/facebook/react/animated/SubtractionAnimatedNode.java b/ReactAndroid/src/main/java/com/facebook/react/animated/SubtractionAnimatedNode.java index 44c0d551975..8b13969f422 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/animated/SubtractionAnimatedNode.java +++ b/ReactAndroid/src/main/java/com/facebook/react/animated/SubtractionAnimatedNode.java @@ -38,12 +38,12 @@ import com.facebook.react.bridge.ReadableMap; double value = ((ValueAnimatedNode) animatedNode).getValue(); if (i == 0) { mValue = value; - continue; + } else { + mValue -= value; } - mValue -= ((ValueAnimatedNode) animatedNode).getValue(); } else { throw new JSApplicationCausedNativeException( - "Illegal node ID set as an input for " + "Animated.subtract node"); + "Illegal node ID set as an input for Animated.subtract node"); } } }