mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Bootstrap Metro from InitializeCore until setup-env is graph-reachable (#57557)
Summary: Pull Request resolved: https://github.com/react/react-native/pull/57557 Fresh projects **redbox on launch** — e.g.: ``` Failed to call into JavaScript module method RCTDeviceEventEmitter.emit(). Module has not been registered as callable. Registered callable JavaScript modules (n = 1): AppRegistry. ``` (The named module varies — `HMRClient.setup()`, `RCTDeviceEventEmitter.emit()` — it's whichever callable module native calls first.) `n = 1: AppRegistry` is the tell: **core initialization never runs**. ## Root cause (https://github.com/react/react-native/issues/57475) Core init runs via Metro's `serializer.getModulesRunBeforeMainModule`. Metro (`metro/src/lib/getAppendScripts.js`) only emits the run-before `__r()` for a module **already present in the bundle graph**, and silently skips it otherwise: ```js const paths = [...options.runBeforeMainModule, entryPoint]; for (const path of paths) { if (modules.some((module) => module.path === path)) { // only if already in the graph /* __r(moduleId) */ } } ``` **https://github.com/react/react-native/issues/57475** switched the run-before target from `Libraries/Core/InitializeCore` → `src/setup-env.js`. - `InitializeCore.js` **is** reachable (imported by `Libraries/ReactPrivate/ReactNativePrivateInitializeCore.js`). - `src/setup-env.js` is imported by **nothing** → not in the graph → silently skipped → core init never runs. The two modules are functionally identical (both call `setUpDefaultReactNativeEnvironment().default()`), so only *reachability* changed. https://github.com/react/react-native/issues/57498 was cosmetic (same resolved file) and does not fix this. ### Evidence (bundle tail) | Run-before target | Bundle tail | Boots? | |---|---|---| | `setup-env` (current) | `__r(0);` | ❌ | | `InitializeCore` (this PR) | `__r(<InitializeCore>); __r(0);` | ✅ | Verified end-to-end via `test-release-local -t RNTestProject -p iOS`. Ruled out: Metro cache (cold `--reset-cache` identical), stale Metro, and https://github.com/react/react-native/issues/57484 (`./src/*` exports removal). Reproduces via the `react-native-community/cli` bundling path (OSS `react-native start`); internal Meta bundling is unaffected, which is why CI/internal stayed green. ## Scope — interim stopgap Only the **internal Metro bootstrap target** reverts to `InitializeCore`. The public `react-native/setup-env` entry point and its deprecation of `InitializeCore` are **unchanged**. The **durable fix** is to make `setup-env` graph-reachable (or make Metro treat `getModulesRunBeforeMainModule` entries as graph roots) — which will then allow `InitializeCore` to be removed as intended. cc huntie (`setup-env` stack owner). A cherry-pick of this is also up against `0.87-stable` (https://github.com/react/react-native/issues/57553). ## Changelog [General][Fixed] - Fix apps failing to boot ("... not registered as callable") caused by core init not running. Reviewed By: christophpurrer Differential Revision: D112002434 fbshipit-source-id: ea3559ef74d31f2c0f9af78aa0a020f4b322e7e0
This commit is contained in:
1 parent
ef54f74deb
commit
08c323346b
2 files changed
+4
-4
No files matched your search
@@ -58,15 +58,15 @@ function getCommunityCliDefaultConfig(
|
||||
return {
|
||||
resolver,
|
||||
serializer: {
|
||||
// We can include multiple copies of setup-env here because Metro will
|
||||
// We can include multiple copies of InitializeCore here because metro will
|
||||
// only add ones that are already part of the bundle
|
||||
getModulesRunBeforeMainModule: () => [
|
||||
require.resolve('react-native/setup-env', {
|
||||
require.resolve('react-native/Libraries/Core/InitializeCore', {
|
||||
paths: [ctx.root],
|
||||
}),
|
||||
...outOfTreePlatforms.map(platform =>
|
||||
require.resolve(
|
||||
`${ctx.platforms[platform].npmPackageName}/setup-env`,
|
||||
`${ctx.platforms[platform].npmPackageName}/Libraries/Core/InitializeCore`,
|
||||
{paths: [ctx.root]},
|
||||
),
|
||||
),
|
||||
|
||||
@@ -61,7 +61,7 @@ export function getDefaultConfig(projectRoot: string): ConfigT {
|
||||
serializer: {
|
||||
// NOTE: Overridden in community-cli-plugin
|
||||
getModulesRunBeforeMainModule: () => [
|
||||
require.resolve('react-native/setup-env'),
|
||||
require.resolve('react-native/Libraries/Core/InitializeCore'),
|
||||
],
|
||||
getPolyfills: () => require('@react-native/js-polyfills')(),
|
||||
isThirdPartyModule({path: modulePath}: Readonly<{path: string, ...}>) {
|
||||
|
||||
Reference in new issue
Block a user