mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Cleanup enableVirtualViewDebugFeatures and FlingItemOverlay (#56946)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/56946 The `enableVirtualViewDebugFeatures` feature flag was effectively dead — its only MobileConfig backing param (`rn_fling.fling_debug`) hadn't been updated in 365+ days, and the codemod-tracking diff D105936405 was already queued to remove the three native overrides. Rather than carry the FF + JS overlay surface forward, delete the whole stack: the FF, the overrides, the BUCK dep, the JS overlay components (`FlingItemOverlay`, `FlingDebugItemOverlay`, `FlingDebugOverlay`), the debug-log helpers in the native ScrollView/VirtualView implementations on both iOS and Android, and the now-orphaned references in `VirtualCollectionView`. Net: 4 files deleted, the FF removed from the cross-language codegen, native debug logging dropped from 5 files (1 ObjC++, 4 Kotlin), and consumer code in `VirtualCollectionView` simplified. Changelog: [General][Removed] - Remove unused `enableVirtualViewDebugFeatures` feature flag and the associated `FlingItemOverlay` / `FlingDebugItemOverlay` debug surfaces. Reviewed By: lunaleaps Differential Revision: D105959433 fbshipit-source-id: 40cba737f3191f3e2501677a16b8b738ec9310c5
This commit is contained in:
1 parent
cf28e6b73c
commit
083fd99ba4
27 files changed
+88
-258
No files matched your search
+12
-26
@@ -16,14 +16,11 @@
|
||||
using namespace facebook;
|
||||
using namespace facebook::react;
|
||||
|
||||
#if RCT_DEBUG
|
||||
#define ENABLE_DEBUG_LOGGING 0 && RCT_DEBUG
|
||||
|
||||
#if ENABLE_DEBUG_LOGGING
|
||||
static void debugLog(NSString *msg, ...)
|
||||
{
|
||||
auto debugEnabled = ReactNativeFeatureFlags::enableVirtualViewDebugFeatures();
|
||||
if (!debugEnabled) {
|
||||
return;
|
||||
}
|
||||
|
||||
va_list args;
|
||||
va_start(args, msg);
|
||||
NSString *msgString = [[NSString alloc] initWithFormat:msg arguments:args];
|
||||
@@ -31,6 +28,9 @@ static void debugLog(NSString *msg, ...)
|
||||
va_end(args); // Don't forget to call va_end to clean up
|
||||
}
|
||||
|
||||
#define DEBUG_LOG(...) debugLog(__VA_ARGS__)
|
||||
#else
|
||||
#define DEBUG_LOG(...) ((void)0)
|
||||
#endif
|
||||
|
||||
/**
|
||||
@@ -87,18 +87,14 @@ static BOOL CGRectOverlaps(CGRect rect1, CGRect rect2)
|
||||
_prerenderRatio = ReactNativeFeatureFlags::virtualViewPrerenderRatio();
|
||||
[_scrollViewComponentView addScrollListener:self];
|
||||
|
||||
#if RCT_DEBUG
|
||||
debugLog(@"initWithScrollView");
|
||||
#endif
|
||||
DEBUG_LOG(@"initWithScrollView");
|
||||
}
|
||||
return self;
|
||||
}
|
||||
|
||||
- (void)dealloc
|
||||
{
|
||||
#if RCT_DEBUG
|
||||
debugLog(@"dealloc");
|
||||
#endif
|
||||
DEBUG_LOG(@"dealloc");
|
||||
if (_scrollViewComponentView != nil) {
|
||||
[_scrollViewComponentView removeScrollListener:self];
|
||||
_scrollViewComponentView = nil;
|
||||
@@ -112,14 +108,9 @@ static BOOL CGRectOverlaps(CGRect rect1, CGRect rect2)
|
||||
{
|
||||
if (![_virtualViews containsObject:virtualView]) {
|
||||
[_virtualViews addObject:virtualView];
|
||||
#if RCT_DEBUG
|
||||
debugLog(@"Add virtualViewID=%@", virtualView.virtualViewID);
|
||||
#endif
|
||||
|
||||
DEBUG_LOG(@"Add virtualViewID=%@", virtualView.virtualViewID);
|
||||
} else {
|
||||
#if RCT_DEBUG
|
||||
debugLog(@"Update virtualViewID=%@", virtualView.virtualViewID);
|
||||
#endif
|
||||
DEBUG_LOG(@"Update virtualViewID=%@", virtualView.virtualViewID);
|
||||
}
|
||||
[self _updateModes:virtualView];
|
||||
}
|
||||
@@ -131,10 +122,7 @@ static BOOL CGRectOverlaps(CGRect rect1, CGRect rect2)
|
||||
}
|
||||
|
||||
[_virtualViews removeObject:virtualView];
|
||||
|
||||
#if RCT_DEBUG
|
||||
debugLog(@"Remove virtualViewID=%@", virtualView.virtualViewID);
|
||||
#endif
|
||||
DEBUG_LOG(@"Remove virtualViewID=%@", virtualView.virtualViewID);
|
||||
}
|
||||
|
||||
#pragma mark - Private Helpers
|
||||
@@ -169,14 +157,12 @@ static BOOL CGRectOverlaps(CGRect rect1, CGRect rect2)
|
||||
thresholdRect = _prerenderRect;
|
||||
}
|
||||
|
||||
#if RCT_DEBUG
|
||||
debugLog(
|
||||
DEBUG_LOG(
|
||||
@"UpdateModes virtualView=%@ mode=%ld rect=%@ thresholdRect=%@",
|
||||
vv.virtualViewID,
|
||||
(long)mode,
|
||||
NSStringFromCGRect(rect),
|
||||
NSStringFromCGRect(thresholdRect));
|
||||
#endif
|
||||
[vv onModeChange:mode targetRect:rect thresholdRect:thresholdRect];
|
||||
}
|
||||
}
|
||||
|
||||
+1
-7
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<3e8cc4e23730f3171824faaf2053bbd9>>
|
||||
* @generated SignedSource<<f930d8c04c79ad156af580f2818fef24>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -336,12 +336,6 @@ public object ReactNativeFeatureFlags {
|
||||
@JvmStatic
|
||||
public fun enableVirtualViewContainerStateExperimental(): Boolean = accessor.enableVirtualViewContainerStateExperimental()
|
||||
|
||||
/**
|
||||
* Enables VirtualView debug features such as logging and overlays.
|
||||
*/
|
||||
@JvmStatic
|
||||
public fun enableVirtualViewDebugFeatures(): Boolean = accessor.enableVirtualViewDebugFeatures()
|
||||
|
||||
/**
|
||||
* Fix incorrect parentTag passed as parentTagForUpdate in the unflatten-unflatten branch of calculateShadowViewMutationsFlattener, which causes UPDATE mutations to reference a parent being created in the same batch.
|
||||
*/
|
||||
|
||||
+1
-11
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<1b877147588a851daaee1a2b4494312a>>
|
||||
* @generated SignedSource<<5072b83512e1a86dc1382268f18916f4>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -71,7 +71,6 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
|
||||
private var enableViewRecyclingForTextCache: Boolean? = null
|
||||
private var enableViewRecyclingForViewCache: Boolean? = null
|
||||
private var enableVirtualViewContainerStateExperimentalCache: Boolean? = null
|
||||
private var enableVirtualViewDebugFeaturesCache: Boolean? = null
|
||||
private var fixDifferentiatorParentTagForUnflattenCaseCache: Boolean? = null
|
||||
private var fixMappingOfEventPrioritiesBetweenFabricAndReactCache: Boolean? = null
|
||||
private var fixYogaFlexBasisFitContentInMainAxisCache: Boolean? = null
|
||||
@@ -568,15 +567,6 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
|
||||
return cached
|
||||
}
|
||||
|
||||
override fun enableVirtualViewDebugFeatures(): Boolean {
|
||||
var cached = enableVirtualViewDebugFeaturesCache
|
||||
if (cached == null) {
|
||||
cached = ReactNativeFeatureFlagsCxxInterop.enableVirtualViewDebugFeatures()
|
||||
enableVirtualViewDebugFeaturesCache = cached
|
||||
}
|
||||
return cached
|
||||
}
|
||||
|
||||
override fun fixDifferentiatorParentTagForUnflattenCase(): Boolean {
|
||||
var cached = fixDifferentiatorParentTagForUnflattenCaseCache
|
||||
if (cached == null) {
|
||||
|
||||
+1
-3
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<a09de0b0d4b342796ff3fcc1b52fc53a>>
|
||||
* @generated SignedSource<<9110ccc69266f7a51738ca533df3a150>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -130,8 +130,6 @@ public object ReactNativeFeatureFlagsCxxInterop {
|
||||
|
||||
@DoNotStrip @JvmStatic public external fun enableVirtualViewContainerStateExperimental(): Boolean
|
||||
|
||||
@DoNotStrip @JvmStatic public external fun enableVirtualViewDebugFeatures(): Boolean
|
||||
|
||||
@DoNotStrip @JvmStatic public external fun fixDifferentiatorParentTagForUnflattenCase(): Boolean
|
||||
|
||||
@DoNotStrip @JvmStatic public external fun fixMappingOfEventPrioritiesBetweenFabricAndReact(): Boolean
|
||||
|
||||
+1
-3
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<b08dd880f47d31353cd29e4bcc63090d>>
|
||||
* @generated SignedSource<<cc3e924846873a6c82f15a81e429a201>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -125,8 +125,6 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
|
||||
|
||||
override fun enableVirtualViewContainerStateExperimental(): Boolean = false
|
||||
|
||||
override fun enableVirtualViewDebugFeatures(): Boolean = false
|
||||
|
||||
override fun fixDifferentiatorParentTagForUnflattenCase(): Boolean = false
|
||||
|
||||
override fun fixMappingOfEventPrioritiesBetweenFabricAndReact(): Boolean = false
|
||||
|
||||
+1
-12
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<c3cb6a890e22fe2ac279c3a9aa65b096>>
|
||||
* @generated SignedSource<<135694971d264d19c84eb6aea5fc8425>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -75,7 +75,6 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
|
||||
private var enableViewRecyclingForTextCache: Boolean? = null
|
||||
private var enableViewRecyclingForViewCache: Boolean? = null
|
||||
private var enableVirtualViewContainerStateExperimentalCache: Boolean? = null
|
||||
private var enableVirtualViewDebugFeaturesCache: Boolean? = null
|
||||
private var fixDifferentiatorParentTagForUnflattenCaseCache: Boolean? = null
|
||||
private var fixMappingOfEventPrioritiesBetweenFabricAndReactCache: Boolean? = null
|
||||
private var fixYogaFlexBasisFitContentInMainAxisCache: Boolean? = null
|
||||
@@ -623,16 +622,6 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
|
||||
return cached
|
||||
}
|
||||
|
||||
override fun enableVirtualViewDebugFeatures(): Boolean {
|
||||
var cached = enableVirtualViewDebugFeaturesCache
|
||||
if (cached == null) {
|
||||
cached = currentProvider.enableVirtualViewDebugFeatures()
|
||||
accessedFeatureFlags.add("enableVirtualViewDebugFeatures")
|
||||
enableVirtualViewDebugFeaturesCache = cached
|
||||
}
|
||||
return cached
|
||||
}
|
||||
|
||||
override fun fixDifferentiatorParentTagForUnflattenCase(): Boolean {
|
||||
var cached = fixDifferentiatorParentTagForUnflattenCaseCache
|
||||
if (cached == null) {
|
||||
|
||||
+1
-3
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<1348346948cf4212dd312c48b5bfe917>>
|
||||
* @generated SignedSource<<c578ce107e944645965622c45645ac2d>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -125,8 +125,6 @@ public interface ReactNativeFeatureFlagsProvider {
|
||||
|
||||
@DoNotStrip public fun enableVirtualViewContainerStateExperimental(): Boolean
|
||||
|
||||
@DoNotStrip public fun enableVirtualViewDebugFeatures(): Boolean
|
||||
|
||||
@DoNotStrip public fun fixDifferentiatorParentTagForUnflattenCase(): Boolean
|
||||
|
||||
@DoNotStrip public fun fixMappingOfEventPrioritiesBetweenFabricAndReact(): Boolean
|
||||
|
||||
+1
-25
@@ -9,8 +9,6 @@ package com.facebook.react.views.scroll
|
||||
|
||||
import android.graphics.Rect
|
||||
import android.view.ViewGroup
|
||||
import com.facebook.common.logging.FLog
|
||||
import com.facebook.react.common.build.ReactBuildConfig
|
||||
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags
|
||||
import com.facebook.react.views.virtual.VirtualViewMode
|
||||
import java.util.*
|
||||
@@ -69,11 +67,7 @@ internal abstract class VirtualViewContainerState {
|
||||
}
|
||||
|
||||
open fun onChange(virtualView: VirtualView) {
|
||||
if (virtualViews.add(virtualView)) {
|
||||
debugLog("add", { "virtualViewID=${virtualView.virtualViewID}" })
|
||||
} else {
|
||||
debugLog("update", { "virtualViewID=${virtualView.virtualViewID}" })
|
||||
}
|
||||
virtualViews.add(virtualView)
|
||||
updateModes(virtualView)
|
||||
}
|
||||
|
||||
@@ -81,12 +75,10 @@ internal abstract class VirtualViewContainerState {
|
||||
assert(virtualViews.remove(virtualView)) {
|
||||
"Attempting to remove non-existent VirtualView: ${virtualView.virtualViewID}"
|
||||
}
|
||||
debugLog("remove", { "virtualViewID=${virtualView.virtualViewID}" })
|
||||
}
|
||||
|
||||
// Called on ScrollView onLayout or onScroll
|
||||
fun updateState() {
|
||||
debugLog("updateState")
|
||||
updateModes()
|
||||
}
|
||||
|
||||
@@ -98,7 +90,6 @@ internal abstract class VirtualViewContainerState {
|
||||
// intentionally goes but curently ScrollView and v1 Fling use this check to determine if
|
||||
// "content ready"
|
||||
if (visibleRect.isEmpty()) {
|
||||
debugLog("updateRects", { "scrollView visibleRect is empty" })
|
||||
// should set the other rects here in case scrollview is suddenly empty after the other rects
|
||||
// are non-empty
|
||||
prerenderRect.set(visibleRect)
|
||||
@@ -110,22 +101,7 @@ internal abstract class VirtualViewContainerState {
|
||||
(-prerenderRect.width() * prerenderRatio).toInt(),
|
||||
(-prerenderRect.height() * prerenderRatio).toInt(),
|
||||
)
|
||||
|
||||
debugLog(
|
||||
"updateRects",
|
||||
{ "visibleRect ${visibleRect.toString()} prerenderRect ${prerenderRect.toString()}" },
|
||||
)
|
||||
}
|
||||
|
||||
protected abstract fun updateModes(virtualView: VirtualView? = null)
|
||||
}
|
||||
|
||||
private const val DEBUG_TAG: String = "VirtualViewContainerState"
|
||||
internal val IS_DEBUG_BUILD =
|
||||
ReactBuildConfig.DEBUG || ReactBuildConfig.IS_INTERNAL_BUILD || ReactBuildConfig.ENABLE_PERFETTO
|
||||
|
||||
private inline fun debugLog(subtag: String, block: () -> String = { "" }) {
|
||||
if (IS_DEBUG_BUILD && ReactNativeFeatureFlags.enableVirtualViewDebugFeatures()) {
|
||||
FLog.d("$DEBUG_TAG:$subtag", block())
|
||||
}
|
||||
}
|
||||
+8
-6
@@ -9,7 +9,7 @@ package com.facebook.react.views.scroll
|
||||
|
||||
import android.view.ViewGroup
|
||||
import com.facebook.common.logging.FLog
|
||||
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags
|
||||
import com.facebook.react.common.build.ReactBuildConfig
|
||||
import com.facebook.react.views.virtual.VirtualViewMode
|
||||
|
||||
internal class VirtualViewContainerStateClassic(scrollView: ViewGroup) :
|
||||
@@ -58,12 +58,14 @@ internal class VirtualViewContainerStateClassic(scrollView: ViewGroup) :
|
||||
)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private const val DEBUG_TAG: String = "VirtualViewContainerStateClassic"
|
||||
internal companion object {
|
||||
private val ENABLE_DEBUG_LOGS = ReactBuildConfig.DEBUG && false
|
||||
|
||||
private inline fun debugLog(subtag: String, block: () -> String = { "" }) {
|
||||
if (IS_DEBUG_BUILD && ReactNativeFeatureFlags.enableVirtualViewDebugFeatures()) {
|
||||
FLog.d("$DEBUG_TAG:$subtag", block())
|
||||
internal inline fun debugLog(subtag: String, block: () -> String = { "" }) {
|
||||
if (ENABLE_DEBUG_LOGS) {
|
||||
FLog.d("VirtualViewContainerStateClassic:$subtag", block())
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
+4
-4
@@ -10,7 +10,7 @@ package com.facebook.react.views.scroll
|
||||
import android.graphics.Rect
|
||||
import android.view.ViewGroup
|
||||
import com.facebook.common.logging.FLog
|
||||
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags
|
||||
import com.facebook.react.common.build.ReactBuildConfig
|
||||
import com.facebook.react.views.virtual.VirtualViewMode
|
||||
|
||||
internal class VirtualViewContainerStateExperimental(scrollView: ViewGroup) :
|
||||
@@ -503,10 +503,10 @@ internal class IntervalTree(private val horizontal: Boolean) : MutableCollection
|
||||
}
|
||||
}
|
||||
|
||||
private const val DEBUG_TAG: String = "VirtualViewContainerStateExperimental"
|
||||
private val ENABLE_DEBUG_LOGS = ReactBuildConfig.DEBUG && false
|
||||
|
||||
private inline fun debugLog(subtag: String, block: () -> String = { "" }) {
|
||||
if (IS_DEBUG_BUILD && ReactNativeFeatureFlags.enableVirtualViewDebugFeatures()) {
|
||||
FLog.d("$DEBUG_TAG:$subtag", block())
|
||||
if (ENABLE_DEBUG_LOGS) {
|
||||
FLog.d("VirtualViewContainerStateExperimental:$subtag", block())
|
||||
}
|
||||
}
|
||||
+7
-8
@@ -15,7 +15,6 @@ import androidx.annotation.VisibleForTesting
|
||||
import com.facebook.common.logging.FLog
|
||||
import com.facebook.react.R
|
||||
import com.facebook.react.common.build.ReactBuildConfig
|
||||
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags
|
||||
import com.facebook.react.uimanager.ReactClippingViewGroup
|
||||
import com.facebook.react.uimanager.ReactRoot
|
||||
import com.facebook.react.views.scroll.VirtualView
|
||||
@@ -287,13 +286,13 @@ public class ReactVirtualView(context: Context) :
|
||||
return null
|
||||
}
|
||||
|
||||
internal inline fun debugLog(subtag: String, block: () -> String = { "" }) {
|
||||
if (IS_DEBUG_BUILD && ReactNativeFeatureFlags.enableVirtualViewDebugFeatures()) {
|
||||
FLog.d("$DEBUG_TAG:[$virtualViewID]:$subtag", block())
|
||||
private companion object {
|
||||
private val ENABLE_DEBUG_LOGS: Boolean = ReactBuildConfig.DEBUG && false
|
||||
}
|
||||
|
||||
private inline fun debugLog(subtag: String, block: () -> String = { "" }) {
|
||||
if (ENABLE_DEBUG_LOGS) {
|
||||
FLog.d("ReactVirtualView:[$virtualViewID]:$subtag", block())
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private const val DEBUG_TAG: String = "ReactVirtualView"
|
||||
private val IS_DEBUG_BUILD =
|
||||
ReactBuildConfig.DEBUG || ReactBuildConfig.IS_INTERNAL_BUILD || ReactBuildConfig.ENABLE_PERFETTO
|
||||
+1
-15
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<ed750080bd0e891a1a11887afb7d7c01>>
|
||||
* @generated SignedSource<<da3ebdd27e001a680c569192712eab7f>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -345,12 +345,6 @@ class ReactNativeFeatureFlagsJavaProvider
|
||||
return method(javaProvider_);
|
||||
}
|
||||
|
||||
bool enableVirtualViewDebugFeatures() override {
|
||||
static const auto method =
|
||||
getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("enableVirtualViewDebugFeatures");
|
||||
return method(javaProvider_);
|
||||
}
|
||||
|
||||
bool fixDifferentiatorParentTagForUnflattenCase() override {
|
||||
static const auto method =
|
||||
getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("fixDifferentiatorParentTagForUnflattenCase");
|
||||
@@ -826,11 +820,6 @@ bool JReactNativeFeatureFlagsCxxInterop::enableVirtualViewContainerStateExperime
|
||||
return ReactNativeFeatureFlags::enableVirtualViewContainerStateExperimental();
|
||||
}
|
||||
|
||||
bool JReactNativeFeatureFlagsCxxInterop::enableVirtualViewDebugFeatures(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
|
||||
return ReactNativeFeatureFlags::enableVirtualViewDebugFeatures();
|
||||
}
|
||||
|
||||
bool JReactNativeFeatureFlagsCxxInterop::fixDifferentiatorParentTagForUnflattenCase(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
|
||||
return ReactNativeFeatureFlags::fixDifferentiatorParentTagForUnflattenCase();
|
||||
@@ -1195,9 +1184,6 @@ void JReactNativeFeatureFlagsCxxInterop::registerNatives() {
|
||||
makeNativeMethod(
|
||||
"enableVirtualViewContainerStateExperimental",
|
||||
JReactNativeFeatureFlagsCxxInterop::enableVirtualViewContainerStateExperimental),
|
||||
makeNativeMethod(
|
||||
"enableVirtualViewDebugFeatures",
|
||||
JReactNativeFeatureFlagsCxxInterop::enableVirtualViewDebugFeatures),
|
||||
makeNativeMethod(
|
||||
"fixDifferentiatorParentTagForUnflattenCase",
|
||||
JReactNativeFeatureFlagsCxxInterop::fixDifferentiatorParentTagForUnflattenCase),
|
||||
|
||||
+1
-4
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<21e508305ffc719768389f668485e57f>>
|
||||
* @generated SignedSource<<1655eb2f217476e64b03c97bce083192>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -183,9 +183,6 @@ class JReactNativeFeatureFlagsCxxInterop
|
||||
static bool enableVirtualViewContainerStateExperimental(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
|
||||
|
||||
static bool enableVirtualViewDebugFeatures(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
|
||||
|
||||
static bool fixDifferentiatorParentTagForUnflattenCase(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
|
||||
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<a65763987ba462f3c46cd84dc8d75713>>
|
||||
* @generated SignedSource<<d3b31e5d51537d44d19f72b2d48f97f4>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -230,10 +230,6 @@ bool ReactNativeFeatureFlags::enableVirtualViewContainerStateExperimental() {
|
||||
return getAccessor().enableVirtualViewContainerStateExperimental();
|
||||
}
|
||||
|
||||
bool ReactNativeFeatureFlags::enableVirtualViewDebugFeatures() {
|
||||
return getAccessor().enableVirtualViewDebugFeatures();
|
||||
}
|
||||
|
||||
bool ReactNativeFeatureFlags::fixDifferentiatorParentTagForUnflattenCase() {
|
||||
return getAccessor().fixDifferentiatorParentTagForUnflattenCase();
|
||||
}
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<e068e0576073bda38f2f86f80306ee93>>
|
||||
* @generated SignedSource<<7299ac6603eb90d63d6cfb21e7ef3893>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -294,11 +294,6 @@ class ReactNativeFeatureFlags {
|
||||
*/
|
||||
RN_EXPORT static bool enableVirtualViewContainerStateExperimental();
|
||||
|
||||
/**
|
||||
* Enables VirtualView debug features such as logging and overlays.
|
||||
*/
|
||||
RN_EXPORT static bool enableVirtualViewDebugFeatures();
|
||||
|
||||
/**
|
||||
* Fix incorrect parentTag passed as parentTagForUpdate in the unflatten-unflatten branch of calculateShadowViewMutationsFlattener, which causes UPDATE mutations to reference a parent being created in the same batch.
|
||||
*/
|
||||
|
||||
+37
-55
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<c3f47b6ffc93782cc87265274a5a1488>>
|
||||
* @generated SignedSource<<5ce3ec2efef77ca4cf69fa6c82097f58>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -947,24 +947,6 @@ bool ReactNativeFeatureFlagsAccessor::enableVirtualViewContainerStateExperimenta
|
||||
return flagValue.value();
|
||||
}
|
||||
|
||||
bool ReactNativeFeatureFlagsAccessor::enableVirtualViewDebugFeatures() {
|
||||
auto flagValue = enableVirtualViewDebugFeatures_.load();
|
||||
|
||||
if (!flagValue.has_value()) {
|
||||
// This block is not exclusive but it is not necessary.
|
||||
// If multiple threads try to initialize the feature flag, we would only
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(51, "enableVirtualViewDebugFeatures");
|
||||
|
||||
flagValue = currentProvider_->enableVirtualViewDebugFeatures();
|
||||
enableVirtualViewDebugFeatures_ = flagValue;
|
||||
}
|
||||
|
||||
return flagValue.value();
|
||||
}
|
||||
|
||||
bool ReactNativeFeatureFlagsAccessor::fixDifferentiatorParentTagForUnflattenCase() {
|
||||
auto flagValue = fixDifferentiatorParentTagForUnflattenCase_.load();
|
||||
|
||||
@@ -974,7 +956,7 @@ bool ReactNativeFeatureFlagsAccessor::fixDifferentiatorParentTagForUnflattenCase
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(52, "fixDifferentiatorParentTagForUnflattenCase");
|
||||
markFlagAsAccessed(51, "fixDifferentiatorParentTagForUnflattenCase");
|
||||
|
||||
flagValue = currentProvider_->fixDifferentiatorParentTagForUnflattenCase();
|
||||
fixDifferentiatorParentTagForUnflattenCase_ = flagValue;
|
||||
@@ -992,7 +974,7 @@ bool ReactNativeFeatureFlagsAccessor::fixMappingOfEventPrioritiesBetweenFabricAn
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(53, "fixMappingOfEventPrioritiesBetweenFabricAndReact");
|
||||
markFlagAsAccessed(52, "fixMappingOfEventPrioritiesBetweenFabricAndReact");
|
||||
|
||||
flagValue = currentProvider_->fixMappingOfEventPrioritiesBetweenFabricAndReact();
|
||||
fixMappingOfEventPrioritiesBetweenFabricAndReact_ = flagValue;
|
||||
@@ -1010,7 +992,7 @@ bool ReactNativeFeatureFlagsAccessor::fixYogaFlexBasisFitContentInMainAxis() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(54, "fixYogaFlexBasisFitContentInMainAxis");
|
||||
markFlagAsAccessed(53, "fixYogaFlexBasisFitContentInMainAxis");
|
||||
|
||||
flagValue = currentProvider_->fixYogaFlexBasisFitContentInMainAxis();
|
||||
fixYogaFlexBasisFitContentInMainAxis_ = flagValue;
|
||||
@@ -1028,7 +1010,7 @@ bool ReactNativeFeatureFlagsAccessor::fuseboxAssertSingleHostState() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(55, "fuseboxAssertSingleHostState");
|
||||
markFlagAsAccessed(54, "fuseboxAssertSingleHostState");
|
||||
|
||||
flagValue = currentProvider_->fuseboxAssertSingleHostState();
|
||||
fuseboxAssertSingleHostState_ = flagValue;
|
||||
@@ -1046,7 +1028,7 @@ bool ReactNativeFeatureFlagsAccessor::fuseboxEnabledRelease() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(56, "fuseboxEnabledRelease");
|
||||
markFlagAsAccessed(55, "fuseboxEnabledRelease");
|
||||
|
||||
flagValue = currentProvider_->fuseboxEnabledRelease();
|
||||
fuseboxEnabledRelease_ = flagValue;
|
||||
@@ -1064,7 +1046,7 @@ bool ReactNativeFeatureFlagsAccessor::fuseboxFrameRecordingEnabled() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(57, "fuseboxFrameRecordingEnabled");
|
||||
markFlagAsAccessed(56, "fuseboxFrameRecordingEnabled");
|
||||
|
||||
flagValue = currentProvider_->fuseboxFrameRecordingEnabled();
|
||||
fuseboxFrameRecordingEnabled_ = flagValue;
|
||||
@@ -1082,7 +1064,7 @@ bool ReactNativeFeatureFlagsAccessor::fuseboxNetworkInspectionEnabled() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(58, "fuseboxNetworkInspectionEnabled");
|
||||
markFlagAsAccessed(57, "fuseboxNetworkInspectionEnabled");
|
||||
|
||||
flagValue = currentProvider_->fuseboxNetworkInspectionEnabled();
|
||||
fuseboxNetworkInspectionEnabled_ = flagValue;
|
||||
@@ -1100,7 +1082,7 @@ bool ReactNativeFeatureFlagsAccessor::fuseboxScreenshotCaptureEnabled() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(59, "fuseboxScreenshotCaptureEnabled");
|
||||
markFlagAsAccessed(58, "fuseboxScreenshotCaptureEnabled");
|
||||
|
||||
flagValue = currentProvider_->fuseboxScreenshotCaptureEnabled();
|
||||
fuseboxScreenshotCaptureEnabled_ = flagValue;
|
||||
@@ -1118,7 +1100,7 @@ bool ReactNativeFeatureFlagsAccessor::hideOffscreenVirtualViewsOnIOS() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(60, "hideOffscreenVirtualViewsOnIOS");
|
||||
markFlagAsAccessed(59, "hideOffscreenVirtualViewsOnIOS");
|
||||
|
||||
flagValue = currentProvider_->hideOffscreenVirtualViewsOnIOS();
|
||||
hideOffscreenVirtualViewsOnIOS_ = flagValue;
|
||||
@@ -1136,7 +1118,7 @@ bool ReactNativeFeatureFlagsAccessor::optimizedAnimatedPropUpdates() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(61, "optimizedAnimatedPropUpdates");
|
||||
markFlagAsAccessed(60, "optimizedAnimatedPropUpdates");
|
||||
|
||||
flagValue = currentProvider_->optimizedAnimatedPropUpdates();
|
||||
optimizedAnimatedPropUpdates_ = flagValue;
|
||||
@@ -1154,7 +1136,7 @@ bool ReactNativeFeatureFlagsAccessor::overrideBySynchronousMountPropsAtMountingA
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(62, "overrideBySynchronousMountPropsAtMountingAndroid");
|
||||
markFlagAsAccessed(61, "overrideBySynchronousMountPropsAtMountingAndroid");
|
||||
|
||||
flagValue = currentProvider_->overrideBySynchronousMountPropsAtMountingAndroid();
|
||||
overrideBySynchronousMountPropsAtMountingAndroid_ = flagValue;
|
||||
@@ -1172,7 +1154,7 @@ bool ReactNativeFeatureFlagsAccessor::perfIssuesEnabled() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(63, "perfIssuesEnabled");
|
||||
markFlagAsAccessed(62, "perfIssuesEnabled");
|
||||
|
||||
flagValue = currentProvider_->perfIssuesEnabled();
|
||||
perfIssuesEnabled_ = flagValue;
|
||||
@@ -1190,7 +1172,7 @@ bool ReactNativeFeatureFlagsAccessor::perfMonitorV2Enabled() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(64, "perfMonitorV2Enabled");
|
||||
markFlagAsAccessed(63, "perfMonitorV2Enabled");
|
||||
|
||||
flagValue = currentProvider_->perfMonitorV2Enabled();
|
||||
perfMonitorV2Enabled_ = flagValue;
|
||||
@@ -1208,7 +1190,7 @@ double ReactNativeFeatureFlagsAccessor::preparedTextCacheSize() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(65, "preparedTextCacheSize");
|
||||
markFlagAsAccessed(64, "preparedTextCacheSize");
|
||||
|
||||
flagValue = currentProvider_->preparedTextCacheSize();
|
||||
preparedTextCacheSize_ = flagValue;
|
||||
@@ -1226,7 +1208,7 @@ bool ReactNativeFeatureFlagsAccessor::preventShadowTreeCommitExhaustion() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(66, "preventShadowTreeCommitExhaustion");
|
||||
markFlagAsAccessed(65, "preventShadowTreeCommitExhaustion");
|
||||
|
||||
flagValue = currentProvider_->preventShadowTreeCommitExhaustion();
|
||||
preventShadowTreeCommitExhaustion_ = flagValue;
|
||||
@@ -1244,7 +1226,7 @@ bool ReactNativeFeatureFlagsAccessor::redBoxV2Android() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(67, "redBoxV2Android");
|
||||
markFlagAsAccessed(66, "redBoxV2Android");
|
||||
|
||||
flagValue = currentProvider_->redBoxV2Android();
|
||||
redBoxV2Android_ = flagValue;
|
||||
@@ -1262,7 +1244,7 @@ bool ReactNativeFeatureFlagsAccessor::redBoxV2IOS() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(68, "redBoxV2IOS");
|
||||
markFlagAsAccessed(67, "redBoxV2IOS");
|
||||
|
||||
flagValue = currentProvider_->redBoxV2IOS();
|
||||
redBoxV2IOS_ = flagValue;
|
||||
@@ -1280,7 +1262,7 @@ bool ReactNativeFeatureFlagsAccessor::shouldPressibilityUseW3CPointerEventsForHo
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(69, "shouldPressibilityUseW3CPointerEventsForHover");
|
||||
markFlagAsAccessed(68, "shouldPressibilityUseW3CPointerEventsForHover");
|
||||
|
||||
flagValue = currentProvider_->shouldPressibilityUseW3CPointerEventsForHover();
|
||||
shouldPressibilityUseW3CPointerEventsForHover_ = flagValue;
|
||||
@@ -1298,7 +1280,7 @@ bool ReactNativeFeatureFlagsAccessor::shouldTriggerResponderTransferOnScrollAndr
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(70, "shouldTriggerResponderTransferOnScrollAndroid");
|
||||
markFlagAsAccessed(69, "shouldTriggerResponderTransferOnScrollAndroid");
|
||||
|
||||
flagValue = currentProvider_->shouldTriggerResponderTransferOnScrollAndroid();
|
||||
shouldTriggerResponderTransferOnScrollAndroid_ = flagValue;
|
||||
@@ -1316,7 +1298,7 @@ bool ReactNativeFeatureFlagsAccessor::skipActivityIdentityAssertionOnHostPause()
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(71, "skipActivityIdentityAssertionOnHostPause");
|
||||
markFlagAsAccessed(70, "skipActivityIdentityAssertionOnHostPause");
|
||||
|
||||
flagValue = currentProvider_->skipActivityIdentityAssertionOnHostPause();
|
||||
skipActivityIdentityAssertionOnHostPause_ = flagValue;
|
||||
@@ -1334,7 +1316,7 @@ bool ReactNativeFeatureFlagsAccessor::syncAndroidClipBoundsWithOverflow() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(72, "syncAndroidClipBoundsWithOverflow");
|
||||
markFlagAsAccessed(71, "syncAndroidClipBoundsWithOverflow");
|
||||
|
||||
flagValue = currentProvider_->syncAndroidClipBoundsWithOverflow();
|
||||
syncAndroidClipBoundsWithOverflow_ = flagValue;
|
||||
@@ -1352,7 +1334,7 @@ bool ReactNativeFeatureFlagsAccessor::traceTurboModulePromiseRejectionsOnAndroid
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(73, "traceTurboModulePromiseRejectionsOnAndroid");
|
||||
markFlagAsAccessed(72, "traceTurboModulePromiseRejectionsOnAndroid");
|
||||
|
||||
flagValue = currentProvider_->traceTurboModulePromiseRejectionsOnAndroid();
|
||||
traceTurboModulePromiseRejectionsOnAndroid_ = flagValue;
|
||||
@@ -1370,7 +1352,7 @@ bool ReactNativeFeatureFlagsAccessor::updateRuntimeShadowNodeReferencesOnCommit(
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(74, "updateRuntimeShadowNodeReferencesOnCommit");
|
||||
markFlagAsAccessed(73, "updateRuntimeShadowNodeReferencesOnCommit");
|
||||
|
||||
flagValue = currentProvider_->updateRuntimeShadowNodeReferencesOnCommit();
|
||||
updateRuntimeShadowNodeReferencesOnCommit_ = flagValue;
|
||||
@@ -1388,7 +1370,7 @@ bool ReactNativeFeatureFlagsAccessor::updateRuntimeShadowNodeReferencesOnCommitT
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(75, "updateRuntimeShadowNodeReferencesOnCommitThread");
|
||||
markFlagAsAccessed(74, "updateRuntimeShadowNodeReferencesOnCommitThread");
|
||||
|
||||
flagValue = currentProvider_->updateRuntimeShadowNodeReferencesOnCommitThread();
|
||||
updateRuntimeShadowNodeReferencesOnCommitThread_ = flagValue;
|
||||
@@ -1406,7 +1388,7 @@ bool ReactNativeFeatureFlagsAccessor::useAlwaysAvailableJSErrorHandling() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(76, "useAlwaysAvailableJSErrorHandling");
|
||||
markFlagAsAccessed(75, "useAlwaysAvailableJSErrorHandling");
|
||||
|
||||
flagValue = currentProvider_->useAlwaysAvailableJSErrorHandling();
|
||||
useAlwaysAvailableJSErrorHandling_ = flagValue;
|
||||
@@ -1424,7 +1406,7 @@ bool ReactNativeFeatureFlagsAccessor::useFabricInterop() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(77, "useFabricInterop");
|
||||
markFlagAsAccessed(76, "useFabricInterop");
|
||||
|
||||
flagValue = currentProvider_->useFabricInterop();
|
||||
useFabricInterop_ = flagValue;
|
||||
@@ -1442,7 +1424,7 @@ bool ReactNativeFeatureFlagsAccessor::useNativeViewConfigsInBridgelessMode() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(78, "useNativeViewConfigsInBridgelessMode");
|
||||
markFlagAsAccessed(77, "useNativeViewConfigsInBridgelessMode");
|
||||
|
||||
flagValue = currentProvider_->useNativeViewConfigsInBridgelessMode();
|
||||
useNativeViewConfigsInBridgelessMode_ = flagValue;
|
||||
@@ -1460,7 +1442,7 @@ bool ReactNativeFeatureFlagsAccessor::useNestedScrollViewAndroid() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(79, "useNestedScrollViewAndroid");
|
||||
markFlagAsAccessed(78, "useNestedScrollViewAndroid");
|
||||
|
||||
flagValue = currentProvider_->useNestedScrollViewAndroid();
|
||||
useNestedScrollViewAndroid_ = flagValue;
|
||||
@@ -1478,7 +1460,7 @@ bool ReactNativeFeatureFlagsAccessor::useOptimizedViewRegistryOnAndroid() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(80, "useOptimizedViewRegistryOnAndroid");
|
||||
markFlagAsAccessed(79, "useOptimizedViewRegistryOnAndroid");
|
||||
|
||||
flagValue = currentProvider_->useOptimizedViewRegistryOnAndroid();
|
||||
useOptimizedViewRegistryOnAndroid_ = flagValue;
|
||||
@@ -1496,7 +1478,7 @@ bool ReactNativeFeatureFlagsAccessor::useSharedAnimatedBackend() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(81, "useSharedAnimatedBackend");
|
||||
markFlagAsAccessed(80, "useSharedAnimatedBackend");
|
||||
|
||||
flagValue = currentProvider_->useSharedAnimatedBackend();
|
||||
useSharedAnimatedBackend_ = flagValue;
|
||||
@@ -1514,7 +1496,7 @@ bool ReactNativeFeatureFlagsAccessor::useTraitHiddenOnAndroid() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(82, "useTraitHiddenOnAndroid");
|
||||
markFlagAsAccessed(81, "useTraitHiddenOnAndroid");
|
||||
|
||||
flagValue = currentProvider_->useTraitHiddenOnAndroid();
|
||||
useTraitHiddenOnAndroid_ = flagValue;
|
||||
@@ -1532,7 +1514,7 @@ bool ReactNativeFeatureFlagsAccessor::useTurboModuleInterop() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(83, "useTurboModuleInterop");
|
||||
markFlagAsAccessed(82, "useTurboModuleInterop");
|
||||
|
||||
flagValue = currentProvider_->useTurboModuleInterop();
|
||||
useTurboModuleInterop_ = flagValue;
|
||||
@@ -1550,7 +1532,7 @@ double ReactNativeFeatureFlagsAccessor::viewCullingOutsetRatio() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(84, "viewCullingOutsetRatio");
|
||||
markFlagAsAccessed(83, "viewCullingOutsetRatio");
|
||||
|
||||
flagValue = currentProvider_->viewCullingOutsetRatio();
|
||||
viewCullingOutsetRatio_ = flagValue;
|
||||
@@ -1568,7 +1550,7 @@ bool ReactNativeFeatureFlagsAccessor::viewTransitionEnabled() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(85, "viewTransitionEnabled");
|
||||
markFlagAsAccessed(84, "viewTransitionEnabled");
|
||||
|
||||
flagValue = currentProvider_->viewTransitionEnabled();
|
||||
viewTransitionEnabled_ = flagValue;
|
||||
@@ -1586,7 +1568,7 @@ bool ReactNativeFeatureFlagsAccessor::viewTransitionUseHardwareBitmapAndroid() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(86, "viewTransitionUseHardwareBitmapAndroid");
|
||||
markFlagAsAccessed(85, "viewTransitionUseHardwareBitmapAndroid");
|
||||
|
||||
flagValue = currentProvider_->viewTransitionUseHardwareBitmapAndroid();
|
||||
viewTransitionUseHardwareBitmapAndroid_ = flagValue;
|
||||
@@ -1604,7 +1586,7 @@ double ReactNativeFeatureFlagsAccessor::virtualViewPrerenderRatio() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(87, "virtualViewPrerenderRatio");
|
||||
markFlagAsAccessed(86, "virtualViewPrerenderRatio");
|
||||
|
||||
flagValue = currentProvider_->virtualViewPrerenderRatio();
|
||||
virtualViewPrerenderRatio_ = flagValue;
|
||||
|
||||
+2
-4
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<f9d7d91647f7002892dfa26259a1f56f>>
|
||||
* @generated SignedSource<<2f027dd5571effd4ee39326db7131eb7>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -83,7 +83,6 @@ class ReactNativeFeatureFlagsAccessor {
|
||||
bool enableViewRecyclingForText();
|
||||
bool enableViewRecyclingForView();
|
||||
bool enableVirtualViewContainerStateExperimental();
|
||||
bool enableVirtualViewDebugFeatures();
|
||||
bool fixDifferentiatorParentTagForUnflattenCase();
|
||||
bool fixMappingOfEventPrioritiesBetweenFabricAndReact();
|
||||
bool fixYogaFlexBasisFitContentInMainAxis();
|
||||
@@ -131,7 +130,7 @@ class ReactNativeFeatureFlagsAccessor {
|
||||
std::unique_ptr<ReactNativeFeatureFlagsProvider> currentProvider_;
|
||||
bool wasOverridden_;
|
||||
|
||||
std::array<std::atomic<const char*>, 88> accessedFeatureFlags_;
|
||||
std::array<std::atomic<const char*>, 87> accessedFeatureFlags_;
|
||||
|
||||
std::atomic<std::optional<bool>> commonTestFlag_;
|
||||
std::atomic<std::optional<bool>> cdpInteractionMetricsEnabled_;
|
||||
@@ -184,7 +183,6 @@ class ReactNativeFeatureFlagsAccessor {
|
||||
std::atomic<std::optional<bool>> enableViewRecyclingForText_;
|
||||
std::atomic<std::optional<bool>> enableViewRecyclingForView_;
|
||||
std::atomic<std::optional<bool>> enableVirtualViewContainerStateExperimental_;
|
||||
std::atomic<std::optional<bool>> enableVirtualViewDebugFeatures_;
|
||||
std::atomic<std::optional<bool>> fixDifferentiatorParentTagForUnflattenCase_;
|
||||
std::atomic<std::optional<bool>> fixMappingOfEventPrioritiesBetweenFabricAndReact_;
|
||||
std::atomic<std::optional<bool>> fixYogaFlexBasisFitContentInMainAxis_;
|
||||
|
||||
+1
-5
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<77b6a81816eff29de7a95ccce85bff53>>
|
||||
* @generated SignedSource<<0dff76292f3f765d95454717d3a61c5f>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -231,10 +231,6 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
|
||||
return false;
|
||||
}
|
||||
|
||||
bool enableVirtualViewDebugFeatures() override {
|
||||
return false;
|
||||
}
|
||||
|
||||
bool fixDifferentiatorParentTagForUnflattenCase() override {
|
||||
return false;
|
||||
}
|
||||
|
||||
+1
-10
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<8621688f8148828ddc1bded80e4484ac>>
|
||||
* @generated SignedSource<<6d7237856953bacb6de35ec63e859d65>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -504,15 +504,6 @@ class ReactNativeFeatureFlagsDynamicProvider : public ReactNativeFeatureFlagsDef
|
||||
return ReactNativeFeatureFlagsDefaults::enableVirtualViewContainerStateExperimental();
|
||||
}
|
||||
|
||||
bool enableVirtualViewDebugFeatures() override {
|
||||
auto value = values_["enableVirtualViewDebugFeatures"];
|
||||
if (!value.isNull()) {
|
||||
return value.getBool();
|
||||
}
|
||||
|
||||
return ReactNativeFeatureFlagsDefaults::enableVirtualViewDebugFeatures();
|
||||
}
|
||||
|
||||
bool fixDifferentiatorParentTagForUnflattenCase() override {
|
||||
auto value = values_["fixDifferentiatorParentTagForUnflattenCase"];
|
||||
if (!value.isNull()) {
|
||||
|
||||
+1
-2
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<b3abbd2996cbb72b7b23db238e986610>>
|
||||
* @generated SignedSource<<07a0d8f1c703685916bce8682f5b4967>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -76,7 +76,6 @@ class ReactNativeFeatureFlagsProvider {
|
||||
virtual bool enableViewRecyclingForText() = 0;
|
||||
virtual bool enableViewRecyclingForView() = 0;
|
||||
virtual bool enableVirtualViewContainerStateExperimental() = 0;
|
||||
virtual bool enableVirtualViewDebugFeatures() = 0;
|
||||
virtual bool fixDifferentiatorParentTagForUnflattenCase() = 0;
|
||||
virtual bool fixMappingOfEventPrioritiesBetweenFabricAndReact() = 0;
|
||||
virtual bool fixYogaFlexBasisFitContentInMainAxis() = 0;
|
||||
|
||||
+1
-6
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<d92bd6100efa1a3b352a5c7b654c2174>>
|
||||
* @generated SignedSource<<1b1d76d354f735488f8de5c1d0b83cc6>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -299,11 +299,6 @@ bool NativeReactNativeFeatureFlags::enableVirtualViewContainerStateExperimental(
|
||||
return ReactNativeFeatureFlags::enableVirtualViewContainerStateExperimental();
|
||||
}
|
||||
|
||||
bool NativeReactNativeFeatureFlags::enableVirtualViewDebugFeatures(
|
||||
jsi::Runtime& /*runtime*/) {
|
||||
return ReactNativeFeatureFlags::enableVirtualViewDebugFeatures();
|
||||
}
|
||||
|
||||
bool NativeReactNativeFeatureFlags::fixDifferentiatorParentTagForUnflattenCase(
|
||||
jsi::Runtime& /*runtime*/) {
|
||||
return ReactNativeFeatureFlags::fixDifferentiatorParentTagForUnflattenCase();
|
||||
|
||||
+1
-3
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<1a26271de9309c5f9c2435197e376847>>
|
||||
* @generated SignedSource<<95947de110a15ea5c43af6213194058a>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -138,8 +138,6 @@ class NativeReactNativeFeatureFlags
|
||||
|
||||
bool enableVirtualViewContainerStateExperimental(jsi::Runtime& runtime);
|
||||
|
||||
bool enableVirtualViewDebugFeatures(jsi::Runtime& runtime);
|
||||
|
||||
bool fixDifferentiatorParentTagForUnflattenCase(jsi::Runtime& runtime);
|
||||
|
||||
bool fixMappingOfEventPrioritiesBetweenFabricAndReact(jsi::Runtime& runtime);
|
||||
|
||||
@@ -593,16 +593,6 @@ const definitions: FeatureFlagDefinitions = {
|
||||
},
|
||||
ossReleaseStage: 'none',
|
||||
},
|
||||
enableVirtualViewDebugFeatures: {
|
||||
defaultValue: false,
|
||||
metadata: {
|
||||
description:
|
||||
'Enables VirtualView debug features such as logging and overlays.',
|
||||
expectedReleaseValue: false,
|
||||
purpose: 'operational',
|
||||
},
|
||||
ossReleaseStage: 'none',
|
||||
},
|
||||
fixDifferentiatorParentTagForUnflattenCase: {
|
||||
defaultValue: false,
|
||||
metadata: {
|
||||
|
||||
-4
@@ -17,7 +17,6 @@ import {
|
||||
VirtualViewMode,
|
||||
createHiddenVirtualView,
|
||||
} from '../virtualview/VirtualView';
|
||||
import FlingItemOverlay from './debug/FlingItemOverlay';
|
||||
import * as React from 'react';
|
||||
import {useCallback, useMemo, useState} from 'react';
|
||||
|
||||
@@ -108,9 +107,6 @@ export function createVirtualCollectionView<TLayoutProps extends {...}>(
|
||||
key={key}
|
||||
nativeID={key}
|
||||
removeClippedSubviews={removeClippedSubviews}>
|
||||
{FlingItemOverlay == null ? null : (
|
||||
<FlingItemOverlay nativeID={key} />
|
||||
)}
|
||||
{children(item, key)}
|
||||
</VirtualView>
|
||||
);
|
||||
|
||||
-13
@@ -1,13 +0,0 @@
|
||||
/**
|
||||
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
||||
*
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @flow strict-local
|
||||
* @format
|
||||
*/
|
||||
|
||||
const FlingItemOverlay: ?component(nativeID: string) = null;
|
||||
|
||||
export default FlingItemOverlay;
|
||||
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<17cac2c987328cb01ab6321fe7670cc5>>
|
||||
* @generated SignedSource<<f67507377832e158acd47c7362a7211a>>
|
||||
* @flow strict
|
||||
* @noformat
|
||||
*/
|
||||
@@ -97,7 +97,6 @@ export type ReactNativeFeatureFlags = $ReadOnly<{
|
||||
enableViewRecyclingForText: Getter<boolean>,
|
||||
enableViewRecyclingForView: Getter<boolean>,
|
||||
enableVirtualViewContainerStateExperimental: Getter<boolean>,
|
||||
enableVirtualViewDebugFeatures: Getter<boolean>,
|
||||
fixDifferentiatorParentTagForUnflattenCase: Getter<boolean>,
|
||||
fixMappingOfEventPrioritiesBetweenFabricAndReact: Getter<boolean>,
|
||||
fixYogaFlexBasisFitContentInMainAxis: Getter<boolean>,
|
||||
@@ -399,10 +398,6 @@ export const enableViewRecyclingForView: Getter<boolean> = createNativeFlagGette
|
||||
* Enables the experimental version of `VirtualViewContainerState`.
|
||||
*/
|
||||
export const enableVirtualViewContainerStateExperimental: Getter<boolean> = createNativeFlagGetter('enableVirtualViewContainerStateExperimental', false);
|
||||
/**
|
||||
* Enables VirtualView debug features such as logging and overlays.
|
||||
*/
|
||||
export const enableVirtualViewDebugFeatures: Getter<boolean> = createNativeFlagGetter('enableVirtualViewDebugFeatures', false);
|
||||
/**
|
||||
* Fix incorrect parentTag passed as parentTagForUpdate in the unflatten-unflatten branch of calculateShadowViewMutationsFlattener, which causes UPDATE mutations to reference a parent being created in the same batch.
|
||||
*/
|
||||
|
||||
+1
-2
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<ba2b6d1fb38bdb754817169614234b2a>>
|
||||
* @generated SignedSource<<b939aa5058cb1f40cfd7ede879366bb5>>
|
||||
* @flow strict
|
||||
* @noformat
|
||||
*/
|
||||
@@ -76,7 +76,6 @@ export interface Spec extends TurboModule {
|
||||
+enableViewRecyclingForText?: () => boolean;
|
||||
+enableViewRecyclingForView?: () => boolean;
|
||||
+enableVirtualViewContainerStateExperimental?: () => boolean;
|
||||
+enableVirtualViewDebugFeatures?: () => boolean;
|
||||
+fixDifferentiatorParentTagForUnflattenCase?: () => boolean;
|
||||
+fixMappingOfEventPrioritiesBetweenFabricAndReact?: () => boolean;
|
||||
+fixYogaFlexBasisFitContentInMainAxis?: () => boolean;
|
||||
|
||||
Reference in new issue
Block a user