Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Slider height in Fabric

Browse Source 
Summary: This diff fixes the height of the Slider component in Fabric on Android. Note that the layout is still broken (no padding and the seek bar is misaligned, but it's another issue).

Reviewed By: JoshuaGross

Differential Revision: D17629798

fbshipit-source-id: af8cae909279dc92ee1c80b9be2f5c578972eafc
This commit is contained in:
Oleksandr Melnykov
2019-09-30 03:48:45 -07:00
committed by Facebook Github Bot
parent 231d2f95cd
commit 07fe994e26
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/views/slider/ReactSliderManager.java
+4 -1
View File
@@ -22,6 +22,7 @@ import com.facebook.react.bridge.ReactContext;
import com.facebook.react.bridge.ReadableMap;
import com.facebook.react.common.MapBuilder;
import com.facebook.react.uimanager.LayoutShadowNode;
import com.facebook.react.uimanager.PixelUtil;
import com.facebook.react.uimanager.SimpleViewManager;
import com.facebook.react.uimanager.ThemedReactContext;
import com.facebook.react.uimanager.UIManagerModule;
@@ -255,7 +256,9 @@ public class ReactSliderManager extends SimpleViewManager<ReactSlider>
ViewGroup.LayoutParams.WRAP_CONTENT, View.MeasureSpec.UNSPECIFIED);
reactSlider.measure(spec, spec);
return YogaMeasureOutput.make(reactSlider.getMeasuredWidth(), reactSlider.getMeasuredHeight());
return YogaMeasureOutput.make(
PixelUtil.toDIPFromPixel(reactSlider.getMeasuredWidth()),
PixelUtil.toDIPFromPixel(reactSlider.getMeasuredHeight()));
}
@Override