From 07fe994e262723b94263c848ca1733071dcd92cc Mon Sep 17 00:00:00 2001 From: Oleksandr Melnykov Date: Mon, 30 Sep 2019 03:48:45 -0700 Subject: [PATCH] Fix Slider height in Fabric Summary: This diff fixes the height of the Slider component in Fabric on Android. Note that the layout is still broken (no padding and the seek bar is misaligned, but it's another issue). Reviewed By: JoshuaGross Differential Revision: D17629798 fbshipit-source-id: af8cae909279dc92ee1c80b9be2f5c578972eafc --- .../com/facebook/react/views/slider/ReactSliderManager.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/slider/ReactSliderManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/slider/ReactSliderManager.java index 7f20cb03cd9..064a6e432aa 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/slider/ReactSliderManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/slider/ReactSliderManager.java @@ -22,6 +22,7 @@ import com.facebook.react.bridge.ReactContext; import com.facebook.react.bridge.ReadableMap; import com.facebook.react.common.MapBuilder; import com.facebook.react.uimanager.LayoutShadowNode; +import com.facebook.react.uimanager.PixelUtil; import com.facebook.react.uimanager.SimpleViewManager; import com.facebook.react.uimanager.ThemedReactContext; import com.facebook.react.uimanager.UIManagerModule; @@ -255,7 +256,9 @@ public class ReactSliderManager extends SimpleViewManager ViewGroup.LayoutParams.WRAP_CONTENT, View.MeasureSpec.UNSPECIFIED); reactSlider.measure(spec, spec); - return YogaMeasureOutput.make(reactSlider.getMeasuredWidth(), reactSlider.getMeasuredHeight()); + return YogaMeasureOutput.make( + PixelUtil.toDIPFromPixel(reactSlider.getMeasuredWidth()), + PixelUtil.toDIPFromPixel(reactSlider.getMeasuredHeight())); } @Override