Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove TurboModule debug info (#45323)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/45323

We're no longer running experiments with TurboModule and legacy module rollout, so this debug info is no longer required, and adds unnecessary verbosity to TurboModule lookup errors.

Changelog: [Internal]

Reviewed By: christophpurrer

Differential Revision: D59465974

fbshipit-source-id: 87a2ebd9c05ad312889bcbd819ccbe885b429064
This commit is contained in:
Pieter De Baets
2024-07-09 07:34:11 -07:00
committed by Facebook GitHub Bot
parent 5a62606ab3
commit 0733e36278
1 changed files with 7 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/Libraries/TurboModule/TurboModuleRegistry.js
Vendored
+7 -42
View File
@@ -16,50 +16,25 @@ const NativeModules = require('../BatchedBridge/NativeModules');
const turboModuleProxy = global.__turboModuleProxy;
const moduleLoadHistory = {
NativeModules: ([]: Array<string>),
TurboModules: ([]: Array<string>),
NotFound: ([]: Array<string>),
};
function isBridgeless() {
return global.RN$Bridgeless === true;
}
function isTurboModuleInteropEnabled() {
return global.RN$TurboInterop === true;
}
// TODO(154308585): Remove "module not found" debug info logging
function shouldReportDebugInfo() {
return true;
}
const useLegacyNativeModuleInterop =
global.RN$Bridgeless !== true || global.RN$TurboInterop === true;
function requireModule<T: TurboModule>(name: string): ?T {
if (turboModuleProxy != null) {
const module: ?T = turboModuleProxy(name);
if (module != null) {
if (shouldReportDebugInfo()) {
moduleLoadHistory.TurboModules.push(name);
}
return module;
}
}
if (!isBridgeless() || isTurboModuleInteropEnabled()) {
if (useLegacyNativeModuleInterop) {
// Backward compatibility layer during migration.
const legacyModule: ?T = NativeModules[name];
if (legacyModule != null) {
if (shouldReportDebugInfo()) {
moduleLoadHistory.NativeModules.push(name);
}
return legacyModule;
}
}
if (shouldReportDebugInfo() && !moduleLoadHistory.NotFound.includes(name)) {
moduleLoadHistory.NotFound.push(name);
}
return null;
}
@@ -69,20 +44,10 @@ export function get<T: TurboModule>(name: string): ?T {
export function getEnforcing<T: TurboModule>(name: string): T {
const module = requireModule<T>(name);
let message =
invariant(
module != null,
`TurboModuleRegistry.getEnforcing(...): '${name}' could not be found. ` +
'Verify that a module by this name is registered in the native binary.';
if (shouldReportDebugInfo()) {
message +=
' Bridgeless mode: ' + (isBridgeless() ? 'true' : 'false') + '. ';
message +=
'TurboModule interop: ' +
(isTurboModuleInteropEnabled() ? 'true' : 'false') +
'. ';
message += 'Modules loaded: ' + JSON.stringify(moduleLoadHistory);
}
invariant(module != null, message);
'Verify that a module by this name is registered in the native binary.',
);
return module;
}