Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix CQS signal readability-redundant-smartptr-get in xplat/js/react-native-github/packages (#54065)

Browse Source 
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/54065

Reviewed By: javache

Differential Revision: D83817146

fbshipit-source-id: 36bafe7d363d7978e2d74a98aee444af9f538de4
This commit is contained in:
generatedunixname89002005287564
2025-10-06 10:43:45 -07:00
committed by meta-codesync[bot]
parent 3f7f9d8fb8
commit 064fd59602
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/React/Fabric/Mounting/RCTMountingManager.mm
+1 -1
View File
@@ -299,7 +299,7 @@ static void RCTPerformMountInstructions(
SurfaceId surfaceId = RCTSurfaceIdForView(componentView);
Props::Shared oldProps = [componentView props];
Props::Shared newProps = componentDescriptor.cloneProps(
PropsParserContext{surfaceId, *_contextContainer.get()}, oldProps, RawProps(std::move(props)));
PropsParserContext{surfaceId, *_contextContainer}, oldProps, RawProps(std::move(props)));
NSSet<NSString *> *propKeys = componentView.propKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN ?: [NSSet new];
propKeys = [propKeys setByAddingObjectsFromArray:propsKeysToBeUpdated];
packages/react-native/ReactCommon/react/renderer/scheduler/SurfaceHandler.cpp
+2 -2
View File
@@ -225,7 +225,7 @@ Size SurfaceHandler::measure(
link_.shadowTree->getCurrentRevision().rootShadowNode;
PropsParserContext propsParserContext{
parameters_.surfaceId, *parameters_.contextContainer.get()};
parameters_.surfaceId, *parameters_.contextContainer};
auto rootShadowNode = currentRootShadowNode->clone(
propsParserContext, layoutConstraints, layoutContext);
@@ -329,7 +329,7 @@ void SurfaceHandler::constraintLayout(
}
PropsParserContext propsParserContext{
parameters_.surfaceId, *parameters_.contextContainer.get()};
parameters_.surfaceId, *parameters_.contextContainer};
react_native_assert(
link_.shadowTree && "`link_.shadowTree` must not be null.");
packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp
+3 -3
View File
@@ -70,7 +70,7 @@ std::shared_ptr<ShadowNode> UIManager::createNode(
auto fallbackDescriptor =
componentDescriptorRegistry_->getFallbackComponentDescriptor();
PropsParserContext propsParserContext{surfaceId, *contextContainer_.get()};
PropsParserContext propsParserContext{surfaceId, *contextContainer_};
auto family = componentDescriptor.createFamily(
{.tag = tag,
@@ -113,7 +113,7 @@ std::shared_ptr<ShadowNode> UIManager::cloneNode(
"UIManager::cloneNode", "componentName", shadowNode.getComponentName());
PropsParserContext propsParserContext{
shadowNode.getFamily().getSurfaceId(), *contextContainer_.get()};
shadowNode.getFamily().getSurfaceId(), *contextContainer_};
auto& componentDescriptor = shadowNode.getComponentDescriptor();
auto& family = shadowNode.getFamily();
@@ -457,7 +457,7 @@ void UIManager::setNativeProps_DEPRECATED(
componentDescriptorRegistry_->at(
shadowNode->getComponentHandle());
PropsParserContext propsParserContext{
family.getSurfaceId(), *contextContainer_.get()};
family.getSurfaceId(), *contextContainer_};
auto props = componentDescriptor.cloneProps(
propsParserContext,
getShadowNodeInSubtree(*shadowNode, ancestorShadowNode)