mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Back out "Forward ACTION_SCROLL events to SwipeRefreshLayout children" (#55194)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/55194 Reverts https://github.com/facebook/react-native/pull/55097 Original Phabricator Diff: D90209679 Reverting this behavior and feature flag as the experiment that used it is no longer needed Changelog: [Internal] Reviewed By: cortinico Differential Revision: D90791564 fbshipit-source-id: 362399c435a0c5addba5734e333bc2c1747f7293
This commit is contained in:
1 parent
1c63877fec
commit
03b1bf608d
22 files changed
+39
-189
No files matched your search
@@ -6025,7 +6025,6 @@ public abstract interface class com/facebook/react/views/scroll/VirtualView {
|
||||
public final class com/facebook/react/views/swiperefresh/ReactSwipeRefreshLayout : androidx/swiperefreshlayout/widget/SwipeRefreshLayout {
|
||||
public fun <init> (Lcom/facebook/react/bridge/ReactContext;)V
|
||||
public fun canChildScrollUp ()Z
|
||||
public fun dispatchGenericMotionEvent (Landroid/view/MotionEvent;)Z
|
||||
public fun onInterceptTouchEvent (Landroid/view/MotionEvent;)Z
|
||||
public fun onLayout (ZIIII)V
|
||||
public fun onTouchEvent (Landroid/view/MotionEvent;)Z
|
||||
|
||||
+1
-7
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<2329e4100b9b70dce294c618d0616e98>>
|
||||
* @generated SignedSource<<27dfa9832869aa05987fa7cb9740f7ba>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -384,12 +384,6 @@ public object ReactNativeFeatureFlags {
|
||||
@JvmStatic
|
||||
public fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = accessor.overrideBySynchronousMountPropsAtMountingAndroid()
|
||||
|
||||
/**
|
||||
* When enabled, ReactSwipeRefreshLayout will forward ACTION_SCROLL events to its child for proper handling.
|
||||
*/
|
||||
@JvmStatic
|
||||
public fun passScrollToSwipeRefreshChild(): Boolean = accessor.passScrollToSwipeRefreshChild()
|
||||
|
||||
/**
|
||||
* Enable reporting Performance Issues (`detail.devtools.performanceIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
|
||||
*/
|
||||
|
||||
+1
-11
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<ddaac394d5d58b2dd3416f5155d4df03>>
|
||||
* @generated SignedSource<<6fb19235ba5049e07952cfa1b564e9e2>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -79,7 +79,6 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
|
||||
private var fuseboxNetworkInspectionEnabledCache: Boolean? = null
|
||||
private var hideOffscreenVirtualViewsOnIOSCache: Boolean? = null
|
||||
private var overrideBySynchronousMountPropsAtMountingAndroidCache: Boolean? = null
|
||||
private var passScrollToSwipeRefreshChildCache: Boolean? = null
|
||||
private var perfIssuesEnabledCache: Boolean? = null
|
||||
private var perfMonitorV2EnabledCache: Boolean? = null
|
||||
private var preparedTextCacheSizeCache: Double? = null
|
||||
@@ -630,15 +629,6 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
|
||||
return cached
|
||||
}
|
||||
|
||||
override fun passScrollToSwipeRefreshChild(): Boolean {
|
||||
var cached = passScrollToSwipeRefreshChildCache
|
||||
if (cached == null) {
|
||||
cached = ReactNativeFeatureFlagsCxxInterop.passScrollToSwipeRefreshChild()
|
||||
passScrollToSwipeRefreshChildCache = cached
|
||||
}
|
||||
return cached
|
||||
}
|
||||
|
||||
override fun perfIssuesEnabled(): Boolean {
|
||||
var cached = perfIssuesEnabledCache
|
||||
if (cached == null) {
|
||||
|
||||
+1
-3
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<d39b29af72f9e1830af35d856952e317>>
|
||||
* @generated SignedSource<<6410500cbf5a05b1f34efd12d1e83bdf>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -146,8 +146,6 @@ public object ReactNativeFeatureFlagsCxxInterop {
|
||||
|
||||
@DoNotStrip @JvmStatic public external fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean
|
||||
|
||||
@DoNotStrip @JvmStatic public external fun passScrollToSwipeRefreshChild(): Boolean
|
||||
|
||||
@DoNotStrip @JvmStatic public external fun perfIssuesEnabled(): Boolean
|
||||
|
||||
@DoNotStrip @JvmStatic public external fun perfMonitorV2Enabled(): Boolean
|
||||
|
||||
+1
-3
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<293c71559a8101698003f517a98af514>>
|
||||
* @generated SignedSource<<6c664176cf41ffb9f2bf820f15ed7463>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -141,8 +141,6 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
|
||||
|
||||
override fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = false
|
||||
|
||||
override fun passScrollToSwipeRefreshChild(): Boolean = false
|
||||
|
||||
override fun perfIssuesEnabled(): Boolean = false
|
||||
|
||||
override fun perfMonitorV2Enabled(): Boolean = false
|
||||
|
||||
+1
-12
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<0f1bedf79aaaddc0ff69155ad4593ad3>>
|
||||
* @generated SignedSource<<1403b30f4dc3d18f39303d91d6824bda>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -83,7 +83,6 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
|
||||
private var fuseboxNetworkInspectionEnabledCache: Boolean? = null
|
||||
private var hideOffscreenVirtualViewsOnIOSCache: Boolean? = null
|
||||
private var overrideBySynchronousMountPropsAtMountingAndroidCache: Boolean? = null
|
||||
private var passScrollToSwipeRefreshChildCache: Boolean? = null
|
||||
private var perfIssuesEnabledCache: Boolean? = null
|
||||
private var perfMonitorV2EnabledCache: Boolean? = null
|
||||
private var preparedTextCacheSizeCache: Double? = null
|
||||
@@ -693,16 +692,6 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
|
||||
return cached
|
||||
}
|
||||
|
||||
override fun passScrollToSwipeRefreshChild(): Boolean {
|
||||
var cached = passScrollToSwipeRefreshChildCache
|
||||
if (cached == null) {
|
||||
cached = currentProvider.passScrollToSwipeRefreshChild()
|
||||
accessedFeatureFlags.add("passScrollToSwipeRefreshChild")
|
||||
passScrollToSwipeRefreshChildCache = cached
|
||||
}
|
||||
return cached
|
||||
}
|
||||
|
||||
override fun perfIssuesEnabled(): Boolean {
|
||||
var cached = perfIssuesEnabledCache
|
||||
if (cached == null) {
|
||||
|
||||
+1
-3
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<85087ed95d67c12c6ac8dbf433284d1d>>
|
||||
* @generated SignedSource<<ad478388cb9a64690c71fe8fa06c1c79>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -141,8 +141,6 @@ public interface ReactNativeFeatureFlagsProvider {
|
||||
|
||||
@DoNotStrip public fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean
|
||||
|
||||
@DoNotStrip public fun passScrollToSwipeRefreshChild(): Boolean
|
||||
|
||||
@DoNotStrip public fun perfIssuesEnabled(): Boolean
|
||||
|
||||
@DoNotStrip public fun perfMonitorV2Enabled(): Boolean
|
||||
|
||||
+1
-33
@@ -12,18 +12,11 @@ import android.view.ViewConfiguration
|
||||
import android.view.ViewGroup
|
||||
import androidx.swiperefreshlayout.widget.SwipeRefreshLayout
|
||||
import com.facebook.react.bridge.ReactContext
|
||||
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags
|
||||
import com.facebook.react.uimanager.PixelUtil
|
||||
import com.facebook.react.uimanager.events.NativeGestureUtil
|
||||
import kotlin.math.abs
|
||||
|
||||
/**
|
||||
* Basic extension of [SwipeRefreshLayout] with ReactNative-specific functionality.
|
||||
*
|
||||
* This component wraps a scrollable child (typically a ScrollView or RecyclerView) and provides
|
||||
* pull-to-refresh functionality. It handles touch event interception for the refresh gesture while
|
||||
* properly forwarding other events to its children.
|
||||
*/
|
||||
/** Basic extension of [SwipeRefreshLayout] with ReactNative-specific functionality. */
|
||||
public class ReactSwipeRefreshLayout(reactContext: ReactContext) :
|
||||
SwipeRefreshLayout(reactContext) {
|
||||
|
||||
@@ -134,31 +127,6 @@ public class ReactSwipeRefreshLayout(reactContext: ReactContext) :
|
||||
return true
|
||||
}
|
||||
|
||||
/**
|
||||
* Dispatches generic motion events to children.
|
||||
*
|
||||
* This override ensures that [MotionEvent.ACTION_SCROLL] events (from joystick, scrollwheel, or
|
||||
* other pointing devices) are properly forwarded to child views.
|
||||
*/
|
||||
public override fun dispatchGenericMotionEvent(ev: MotionEvent): Boolean {
|
||||
// For ACTION_SCROLL events, dispatch to child for handling
|
||||
// The child ScrollView will use nested scrolling APIs to communicate with this
|
||||
// SwipeRefreshLayout
|
||||
if (
|
||||
ReactNativeFeatureFlags.passScrollToSwipeRefreshChild() &&
|
||||
ev.actionMasked == MotionEvent.ACTION_SCROLL
|
||||
) {
|
||||
val child = getChildAt(0)
|
||||
if (child != null) {
|
||||
val handled = child.dispatchGenericMotionEvent(ev)
|
||||
if (handled) {
|
||||
return true
|
||||
}
|
||||
}
|
||||
}
|
||||
return super.dispatchGenericMotionEvent(ev)
|
||||
}
|
||||
|
||||
private companion object {
|
||||
private const val DEFAULT_CIRCLE_TARGET = 64f
|
||||
}
|
||||
|
||||
+1
-15
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<131ba2b067fb63576bbc94cfb2521d06>>
|
||||
* @generated SignedSource<<288cffd334fdaebf18b1bede7bb907c8>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -393,12 +393,6 @@ class ReactNativeFeatureFlagsJavaProvider
|
||||
return method(javaProvider_);
|
||||
}
|
||||
|
||||
bool passScrollToSwipeRefreshChild() override {
|
||||
static const auto method =
|
||||
getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("passScrollToSwipeRefreshChild");
|
||||
return method(javaProvider_);
|
||||
}
|
||||
|
||||
bool perfIssuesEnabled() override {
|
||||
static const auto method =
|
||||
getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("perfIssuesEnabled");
|
||||
@@ -806,11 +800,6 @@ bool JReactNativeFeatureFlagsCxxInterop::overrideBySynchronousMountPropsAtMounti
|
||||
return ReactNativeFeatureFlags::overrideBySynchronousMountPropsAtMountingAndroid();
|
||||
}
|
||||
|
||||
bool JReactNativeFeatureFlagsCxxInterop::passScrollToSwipeRefreshChild(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
|
||||
return ReactNativeFeatureFlags::passScrollToSwipeRefreshChild();
|
||||
}
|
||||
|
||||
bool JReactNativeFeatureFlagsCxxInterop::perfIssuesEnabled(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
|
||||
return ReactNativeFeatureFlags::perfIssuesEnabled();
|
||||
@@ -1109,9 +1098,6 @@ void JReactNativeFeatureFlagsCxxInterop::registerNatives() {
|
||||
makeNativeMethod(
|
||||
"overrideBySynchronousMountPropsAtMountingAndroid",
|
||||
JReactNativeFeatureFlagsCxxInterop::overrideBySynchronousMountPropsAtMountingAndroid),
|
||||
makeNativeMethod(
|
||||
"passScrollToSwipeRefreshChild",
|
||||
JReactNativeFeatureFlagsCxxInterop::passScrollToSwipeRefreshChild),
|
||||
makeNativeMethod(
|
||||
"perfIssuesEnabled",
|
||||
JReactNativeFeatureFlagsCxxInterop::perfIssuesEnabled),
|
||||
|
||||
+1
-4
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<c08164df224d384271a3808d8117afb5>>
|
||||
* @generated SignedSource<<b1325a7991f212671b02bd4072d8b555>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -207,9 +207,6 @@ class JReactNativeFeatureFlagsCxxInterop
|
||||
static bool overrideBySynchronousMountPropsAtMountingAndroid(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
|
||||
|
||||
static bool passScrollToSwipeRefreshChild(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
|
||||
|
||||
static bool perfIssuesEnabled(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
|
||||
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<3df4827c2f80663280d762d64448873f>>
|
||||
* @generated SignedSource<<e197fcc2185d8f75ff6d355c27975bd4>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -262,10 +262,6 @@ bool ReactNativeFeatureFlags::overrideBySynchronousMountPropsAtMountingAndroid()
|
||||
return getAccessor().overrideBySynchronousMountPropsAtMountingAndroid();
|
||||
}
|
||||
|
||||
bool ReactNativeFeatureFlags::passScrollToSwipeRefreshChild() {
|
||||
return getAccessor().passScrollToSwipeRefreshChild();
|
||||
}
|
||||
|
||||
bool ReactNativeFeatureFlags::perfIssuesEnabled() {
|
||||
return getAccessor().perfIssuesEnabled();
|
||||
}
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<3e7c529929a70e9539193237baed2e89>>
|
||||
* @generated SignedSource<<66c8c46d66dde5eb2fd19a67459c83af>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -334,11 +334,6 @@ class ReactNativeFeatureFlags {
|
||||
*/
|
||||
RN_EXPORT static bool overrideBySynchronousMountPropsAtMountingAndroid();
|
||||
|
||||
/**
|
||||
* When enabled, ReactSwipeRefreshLayout will forward ACTION_SCROLL events to its child for proper handling.
|
||||
*/
|
||||
RN_EXPORT static bool passScrollToSwipeRefreshChild();
|
||||
|
||||
/**
|
||||
* Enable reporting Performance Issues (`detail.devtools.performanceIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
|
||||
*/
|
||||
|
||||
+19
-37
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<9ec16e6422e98c7afd1c0d7d776779fa>>
|
||||
* @generated SignedSource<<e70e7523ad30d9fa247a6c1375dcaf0b>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -1091,24 +1091,6 @@ bool ReactNativeFeatureFlagsAccessor::overrideBySynchronousMountPropsAtMountingA
|
||||
return flagValue.value();
|
||||
}
|
||||
|
||||
bool ReactNativeFeatureFlagsAccessor::passScrollToSwipeRefreshChild() {
|
||||
auto flagValue = passScrollToSwipeRefreshChild_.load();
|
||||
|
||||
if (!flagValue.has_value()) {
|
||||
// This block is not exclusive but it is not necessary.
|
||||
// If multiple threads try to initialize the feature flag, we would only
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(59, "passScrollToSwipeRefreshChild");
|
||||
|
||||
flagValue = currentProvider_->passScrollToSwipeRefreshChild();
|
||||
passScrollToSwipeRefreshChild_ = flagValue;
|
||||
}
|
||||
|
||||
return flagValue.value();
|
||||
}
|
||||
|
||||
bool ReactNativeFeatureFlagsAccessor::perfIssuesEnabled() {
|
||||
auto flagValue = perfIssuesEnabled_.load();
|
||||
|
||||
@@ -1118,7 +1100,7 @@ bool ReactNativeFeatureFlagsAccessor::perfIssuesEnabled() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(60, "perfIssuesEnabled");
|
||||
markFlagAsAccessed(59, "perfIssuesEnabled");
|
||||
|
||||
flagValue = currentProvider_->perfIssuesEnabled();
|
||||
perfIssuesEnabled_ = flagValue;
|
||||
@@ -1136,7 +1118,7 @@ bool ReactNativeFeatureFlagsAccessor::perfMonitorV2Enabled() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(61, "perfMonitorV2Enabled");
|
||||
markFlagAsAccessed(60, "perfMonitorV2Enabled");
|
||||
|
||||
flagValue = currentProvider_->perfMonitorV2Enabled();
|
||||
perfMonitorV2Enabled_ = flagValue;
|
||||
@@ -1154,7 +1136,7 @@ double ReactNativeFeatureFlagsAccessor::preparedTextCacheSize() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(62, "preparedTextCacheSize");
|
||||
markFlagAsAccessed(61, "preparedTextCacheSize");
|
||||
|
||||
flagValue = currentProvider_->preparedTextCacheSize();
|
||||
preparedTextCacheSize_ = flagValue;
|
||||
@@ -1172,7 +1154,7 @@ bool ReactNativeFeatureFlagsAccessor::preventShadowTreeCommitExhaustion() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(63, "preventShadowTreeCommitExhaustion");
|
||||
markFlagAsAccessed(62, "preventShadowTreeCommitExhaustion");
|
||||
|
||||
flagValue = currentProvider_->preventShadowTreeCommitExhaustion();
|
||||
preventShadowTreeCommitExhaustion_ = flagValue;
|
||||
@@ -1190,7 +1172,7 @@ bool ReactNativeFeatureFlagsAccessor::shouldPressibilityUseW3CPointerEventsForHo
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(64, "shouldPressibilityUseW3CPointerEventsForHover");
|
||||
markFlagAsAccessed(63, "shouldPressibilityUseW3CPointerEventsForHover");
|
||||
|
||||
flagValue = currentProvider_->shouldPressibilityUseW3CPointerEventsForHover();
|
||||
shouldPressibilityUseW3CPointerEventsForHover_ = flagValue;
|
||||
@@ -1208,7 +1190,7 @@ bool ReactNativeFeatureFlagsAccessor::shouldTriggerResponderTransferOnScrollAndr
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(65, "shouldTriggerResponderTransferOnScrollAndroid");
|
||||
markFlagAsAccessed(64, "shouldTriggerResponderTransferOnScrollAndroid");
|
||||
|
||||
flagValue = currentProvider_->shouldTriggerResponderTransferOnScrollAndroid();
|
||||
shouldTriggerResponderTransferOnScrollAndroid_ = flagValue;
|
||||
@@ -1226,7 +1208,7 @@ bool ReactNativeFeatureFlagsAccessor::skipActivityIdentityAssertionOnHostPause()
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(66, "skipActivityIdentityAssertionOnHostPause");
|
||||
markFlagAsAccessed(65, "skipActivityIdentityAssertionOnHostPause");
|
||||
|
||||
flagValue = currentProvider_->skipActivityIdentityAssertionOnHostPause();
|
||||
skipActivityIdentityAssertionOnHostPause_ = flagValue;
|
||||
@@ -1244,7 +1226,7 @@ bool ReactNativeFeatureFlagsAccessor::traceTurboModulePromiseRejectionsOnAndroid
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(67, "traceTurboModulePromiseRejectionsOnAndroid");
|
||||
markFlagAsAccessed(66, "traceTurboModulePromiseRejectionsOnAndroid");
|
||||
|
||||
flagValue = currentProvider_->traceTurboModulePromiseRejectionsOnAndroid();
|
||||
traceTurboModulePromiseRejectionsOnAndroid_ = flagValue;
|
||||
@@ -1262,7 +1244,7 @@ bool ReactNativeFeatureFlagsAccessor::updateRuntimeShadowNodeReferencesOnCommit(
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(68, "updateRuntimeShadowNodeReferencesOnCommit");
|
||||
markFlagAsAccessed(67, "updateRuntimeShadowNodeReferencesOnCommit");
|
||||
|
||||
flagValue = currentProvider_->updateRuntimeShadowNodeReferencesOnCommit();
|
||||
updateRuntimeShadowNodeReferencesOnCommit_ = flagValue;
|
||||
@@ -1280,7 +1262,7 @@ bool ReactNativeFeatureFlagsAccessor::useAlwaysAvailableJSErrorHandling() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(69, "useAlwaysAvailableJSErrorHandling");
|
||||
markFlagAsAccessed(68, "useAlwaysAvailableJSErrorHandling");
|
||||
|
||||
flagValue = currentProvider_->useAlwaysAvailableJSErrorHandling();
|
||||
useAlwaysAvailableJSErrorHandling_ = flagValue;
|
||||
@@ -1298,7 +1280,7 @@ bool ReactNativeFeatureFlagsAccessor::useFabricInterop() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(70, "useFabricInterop");
|
||||
markFlagAsAccessed(69, "useFabricInterop");
|
||||
|
||||
flagValue = currentProvider_->useFabricInterop();
|
||||
useFabricInterop_ = flagValue;
|
||||
@@ -1316,7 +1298,7 @@ bool ReactNativeFeatureFlagsAccessor::useNativeViewConfigsInBridgelessMode() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(71, "useNativeViewConfigsInBridgelessMode");
|
||||
markFlagAsAccessed(70, "useNativeViewConfigsInBridgelessMode");
|
||||
|
||||
flagValue = currentProvider_->useNativeViewConfigsInBridgelessMode();
|
||||
useNativeViewConfigsInBridgelessMode_ = flagValue;
|
||||
@@ -1334,7 +1316,7 @@ bool ReactNativeFeatureFlagsAccessor::useSharedAnimatedBackend() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(72, "useSharedAnimatedBackend");
|
||||
markFlagAsAccessed(71, "useSharedAnimatedBackend");
|
||||
|
||||
flagValue = currentProvider_->useSharedAnimatedBackend();
|
||||
useSharedAnimatedBackend_ = flagValue;
|
||||
@@ -1352,7 +1334,7 @@ bool ReactNativeFeatureFlagsAccessor::useTraitHiddenOnAndroid() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(73, "useTraitHiddenOnAndroid");
|
||||
markFlagAsAccessed(72, "useTraitHiddenOnAndroid");
|
||||
|
||||
flagValue = currentProvider_->useTraitHiddenOnAndroid();
|
||||
useTraitHiddenOnAndroid_ = flagValue;
|
||||
@@ -1370,7 +1352,7 @@ bool ReactNativeFeatureFlagsAccessor::useTurboModuleInterop() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(74, "useTurboModuleInterop");
|
||||
markFlagAsAccessed(73, "useTurboModuleInterop");
|
||||
|
||||
flagValue = currentProvider_->useTurboModuleInterop();
|
||||
useTurboModuleInterop_ = flagValue;
|
||||
@@ -1388,7 +1370,7 @@ bool ReactNativeFeatureFlagsAccessor::useTurboModules() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(75, "useTurboModules");
|
||||
markFlagAsAccessed(74, "useTurboModules");
|
||||
|
||||
flagValue = currentProvider_->useTurboModules();
|
||||
useTurboModules_ = flagValue;
|
||||
@@ -1406,7 +1388,7 @@ double ReactNativeFeatureFlagsAccessor::viewCullingOutsetRatio() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(76, "viewCullingOutsetRatio");
|
||||
markFlagAsAccessed(75, "viewCullingOutsetRatio");
|
||||
|
||||
flagValue = currentProvider_->viewCullingOutsetRatio();
|
||||
viewCullingOutsetRatio_ = flagValue;
|
||||
@@ -1424,7 +1406,7 @@ double ReactNativeFeatureFlagsAccessor::virtualViewPrerenderRatio() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(77, "virtualViewPrerenderRatio");
|
||||
markFlagAsAccessed(76, "virtualViewPrerenderRatio");
|
||||
|
||||
flagValue = currentProvider_->virtualViewPrerenderRatio();
|
||||
virtualViewPrerenderRatio_ = flagValue;
|
||||
|
||||
+2
-4
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<a988a1145e1437cd8444dda3863c6065>>
|
||||
* @generated SignedSource<<40870eeb15b0536567bf7bc6c95b7f45>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -91,7 +91,6 @@ class ReactNativeFeatureFlagsAccessor {
|
||||
bool fuseboxNetworkInspectionEnabled();
|
||||
bool hideOffscreenVirtualViewsOnIOS();
|
||||
bool overrideBySynchronousMountPropsAtMountingAndroid();
|
||||
bool passScrollToSwipeRefreshChild();
|
||||
bool perfIssuesEnabled();
|
||||
bool perfMonitorV2Enabled();
|
||||
double preparedTextCacheSize();
|
||||
@@ -121,7 +120,7 @@ class ReactNativeFeatureFlagsAccessor {
|
||||
std::unique_ptr<ReactNativeFeatureFlagsProvider> currentProvider_;
|
||||
bool wasOverridden_;
|
||||
|
||||
std::array<std::atomic<const char*>, 78> accessedFeatureFlags_;
|
||||
std::array<std::atomic<const char*>, 77> accessedFeatureFlags_;
|
||||
|
||||
std::atomic<std::optional<bool>> commonTestFlag_;
|
||||
std::atomic<std::optional<bool>> cdpInteractionMetricsEnabled_;
|
||||
@@ -182,7 +181,6 @@ class ReactNativeFeatureFlagsAccessor {
|
||||
std::atomic<std::optional<bool>> fuseboxNetworkInspectionEnabled_;
|
||||
std::atomic<std::optional<bool>> hideOffscreenVirtualViewsOnIOS_;
|
||||
std::atomic<std::optional<bool>> overrideBySynchronousMountPropsAtMountingAndroid_;
|
||||
std::atomic<std::optional<bool>> passScrollToSwipeRefreshChild_;
|
||||
std::atomic<std::optional<bool>> perfIssuesEnabled_;
|
||||
std::atomic<std::optional<bool>> perfMonitorV2Enabled_;
|
||||
std::atomic<std::optional<double>> preparedTextCacheSize_;
|
||||
|
||||
+1
-5
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<6a4d99365bdd62d89ab5b33dd014bed3>>
|
||||
* @generated SignedSource<<046cb410368bfb2d3ba6ed3364376f28>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -263,10 +263,6 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
|
||||
return false;
|
||||
}
|
||||
|
||||
bool passScrollToSwipeRefreshChild() override {
|
||||
return false;
|
||||
}
|
||||
|
||||
bool perfIssuesEnabled() override {
|
||||
return false;
|
||||
}
|
||||
|
||||
+1
-10
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<93a08f1864437e6fe4fc90800d7b8b31>>
|
||||
* @generated SignedSource<<b04b2269efaa4394985f1e90b5761bb2>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -576,15 +576,6 @@ class ReactNativeFeatureFlagsDynamicProvider : public ReactNativeFeatureFlagsDef
|
||||
return ReactNativeFeatureFlagsDefaults::overrideBySynchronousMountPropsAtMountingAndroid();
|
||||
}
|
||||
|
||||
bool passScrollToSwipeRefreshChild() override {
|
||||
auto value = values_["passScrollToSwipeRefreshChild"];
|
||||
if (!value.isNull()) {
|
||||
return value.getBool();
|
||||
}
|
||||
|
||||
return ReactNativeFeatureFlagsDefaults::passScrollToSwipeRefreshChild();
|
||||
}
|
||||
|
||||
bool perfIssuesEnabled() override {
|
||||
auto value = values_["perfIssuesEnabled"];
|
||||
if (!value.isNull()) {
|
||||
|
||||
+1
-2
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<04cc670e379f09e13f6e4b017c0b6468>>
|
||||
* @generated SignedSource<<ddfbc841e1af5449c1fe6bde6344d289>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -84,7 +84,6 @@ class ReactNativeFeatureFlagsProvider {
|
||||
virtual bool fuseboxNetworkInspectionEnabled() = 0;
|
||||
virtual bool hideOffscreenVirtualViewsOnIOS() = 0;
|
||||
virtual bool overrideBySynchronousMountPropsAtMountingAndroid() = 0;
|
||||
virtual bool passScrollToSwipeRefreshChild() = 0;
|
||||
virtual bool perfIssuesEnabled() = 0;
|
||||
virtual bool perfMonitorV2Enabled() = 0;
|
||||
virtual double preparedTextCacheSize() = 0;
|
||||
|
||||
+1
-6
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<24e3e282a3447ef0f8e4685bdee7ee7e>>
|
||||
* @generated SignedSource<<dfb0bf3222991d38f586e0d218e064f4>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -339,11 +339,6 @@ bool NativeReactNativeFeatureFlags::overrideBySynchronousMountPropsAtMountingAnd
|
||||
return ReactNativeFeatureFlags::overrideBySynchronousMountPropsAtMountingAndroid();
|
||||
}
|
||||
|
||||
bool NativeReactNativeFeatureFlags::passScrollToSwipeRefreshChild(
|
||||
jsi::Runtime& /*runtime*/) {
|
||||
return ReactNativeFeatureFlags::passScrollToSwipeRefreshChild();
|
||||
}
|
||||
|
||||
bool NativeReactNativeFeatureFlags::perfIssuesEnabled(
|
||||
jsi::Runtime& /*runtime*/) {
|
||||
return ReactNativeFeatureFlags::perfIssuesEnabled();
|
||||
|
||||
+1
-3
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<a8a002af1f2ca32499cc44ff8fa162cc>>
|
||||
* @generated SignedSource<<6d28ea5d159f53988ca76188bc2fa5c0>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -154,8 +154,6 @@ class NativeReactNativeFeatureFlags
|
||||
|
||||
bool overrideBySynchronousMountPropsAtMountingAndroid(jsi::Runtime& runtime);
|
||||
|
||||
bool passScrollToSwipeRefreshChild(jsi::Runtime& runtime);
|
||||
|
||||
bool perfIssuesEnabled(jsi::Runtime& runtime);
|
||||
|
||||
bool perfMonitorV2Enabled(jsi::Runtime& runtime);
|
||||
|
||||
@@ -679,17 +679,6 @@ const definitions: FeatureFlagDefinitions = {
|
||||
},
|
||||
ossReleaseStage: 'none',
|
||||
},
|
||||
passScrollToSwipeRefreshChild: {
|
||||
defaultValue: false,
|
||||
metadata: {
|
||||
dateAdded: '2026-01-13',
|
||||
description:
|
||||
'When enabled, ReactSwipeRefreshLayout will forward ACTION_SCROLL events to its child for proper handling.',
|
||||
expectedReleaseValue: true,
|
||||
purpose: 'experimentation',
|
||||
},
|
||||
ossReleaseStage: 'none',
|
||||
},
|
||||
perfIssuesEnabled: {
|
||||
defaultValue: false,
|
||||
metadata: {
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<43d84ba3660c1398624b33b7801752ec>>
|
||||
* @generated SignedSource<<b8b1b2973a5c1b1903ea946b15642cf6>>
|
||||
* @flow strict
|
||||
* @noformat
|
||||
*/
|
||||
@@ -106,7 +106,6 @@ export type ReactNativeFeatureFlags = $ReadOnly<{
|
||||
fuseboxNetworkInspectionEnabled: Getter<boolean>,
|
||||
hideOffscreenVirtualViewsOnIOS: Getter<boolean>,
|
||||
overrideBySynchronousMountPropsAtMountingAndroid: Getter<boolean>,
|
||||
passScrollToSwipeRefreshChild: Getter<boolean>,
|
||||
perfIssuesEnabled: Getter<boolean>,
|
||||
perfMonitorV2Enabled: Getter<boolean>,
|
||||
preparedTextCacheSize: Getter<number>,
|
||||
@@ -427,10 +426,6 @@ export const hideOffscreenVirtualViewsOnIOS: Getter<boolean> = createNativeFlagG
|
||||
* Override props at mounting with synchronously mounted (i.e. direct manipulation) props from Native Animated.
|
||||
*/
|
||||
export const overrideBySynchronousMountPropsAtMountingAndroid: Getter<boolean> = createNativeFlagGetter('overrideBySynchronousMountPropsAtMountingAndroid', false);
|
||||
/**
|
||||
* When enabled, ReactSwipeRefreshLayout will forward ACTION_SCROLL events to its child for proper handling.
|
||||
*/
|
||||
export const passScrollToSwipeRefreshChild: Getter<boolean> = createNativeFlagGetter('passScrollToSwipeRefreshChild', false);
|
||||
/**
|
||||
* Enable reporting Performance Issues (`detail.devtools.performanceIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
|
||||
*/
|
||||
|
||||
+1
-2
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<7cdd88679f9216b12bf60fc98ca7e33a>>
|
||||
* @generated SignedSource<<b69f5df319840ba90e905d1a19aebf30>>
|
||||
* @flow strict
|
||||
* @noformat
|
||||
*/
|
||||
@@ -84,7 +84,6 @@ export interface Spec extends TurboModule {
|
||||
+fuseboxNetworkInspectionEnabled?: () => boolean;
|
||||
+hideOffscreenVirtualViewsOnIOS?: () => boolean;
|
||||
+overrideBySynchronousMountPropsAtMountingAndroid?: () => boolean;
|
||||
+passScrollToSwipeRefreshChild?: () => boolean;
|
||||
+perfIssuesEnabled?: () => boolean;
|
||||
+perfMonitorV2Enabled?: () => boolean;
|
||||
+preparedTextCacheSize?: () => number;
|
||||
|
||||
Reference in new issue
Block a user