mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Fix Nullsafe FIXMEs for BlobProvider.java and mark nullsafe (#50363)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/50363 Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made BlobProvider.java nullsafe Reviewed By: cortinico Differential Revision: D71979597 fbshipit-source-id: a6fba0d83f3558b3bed21de484b59ee6b17bb643
This commit is contained in:
committed by
Facebook GitHub Bot
parent
0702e74277
commit
020db409a2
+5
-2
@@ -14,6 +14,7 @@ import android.database.Cursor;
|
||||
import android.net.Uri;
|
||||
import android.os.ParcelFileDescriptor;
|
||||
import androidx.annotation.Nullable;
|
||||
import com.facebook.infer.annotation.Nullsafe;
|
||||
import com.facebook.react.ReactApplication;
|
||||
import com.facebook.react.ReactNativeHost;
|
||||
import com.facebook.react.bridge.ReactContext;
|
||||
@@ -23,6 +24,7 @@ import java.io.OutputStream;
|
||||
import java.util.concurrent.ExecutorService;
|
||||
import java.util.concurrent.Executors;
|
||||
|
||||
@Nullsafe(Nullsafe.Mode.LOCAL)
|
||||
public final class BlobProvider extends ContentProvider {
|
||||
|
||||
private static final int PIPE_CAPACITY = 65536;
|
||||
@@ -72,7 +74,9 @@ public final class BlobProvider extends ContentProvider {
|
||||
if (context instanceof ReactApplication) {
|
||||
ReactNativeHost host = ((ReactApplication) context).getReactNativeHost();
|
||||
ReactContext reactContext = host.getReactInstanceManager().getCurrentReactContext();
|
||||
// NULLSAFE_FIXME[Nullable Dereference]
|
||||
if (reactContext == null) {
|
||||
throw new RuntimeException("No ReactContext associated with BlobProvider");
|
||||
}
|
||||
blobModule = reactContext.getNativeModule(BlobModule.class);
|
||||
}
|
||||
|
||||
@@ -87,7 +91,6 @@ public final class BlobProvider extends ContentProvider {
|
||||
|
||||
ParcelFileDescriptor[] pipe;
|
||||
try {
|
||||
// NULLSAFE_FIXME[Not Vetted Third-Party]
|
||||
pipe = ParcelFileDescriptor.createPipe();
|
||||
} catch (IOException exception) {
|
||||
return null;
|
||||
|
||||
Reference in New Issue
Block a user