Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

ReactCommon/renderer/components/image: Migrate uses of NDEBUG to REACT_NATIVE_DEBUG + react_native_assert

Browse Source 
Summary:
For better cross-platform consistency, migrate usages of NDEBUG to REACT_NATIVE_DEBUG. See flags.h for explanation.

Changelog: [Internal]

Reviewed By: PeteTheHeat

Differential Revision: D26695038

fbshipit-source-id: afcf2aecad8305b112e1b4ddcc1693380f3defcc
This commit is contained in:
Joshua Gross
2021-02-26 23:29:58 -08:00
committed by Facebook GitHub Bot
parent 5194183037
commit 01dcec401b
3 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/react/renderer/components/image/BUCK
+1
View File
@@ -50,6 +50,7 @@ rn_xplat_cxx_library(
"//xplat/folly:headers_only",
"//xplat/folly:molly",
YOGA_CXX_TARGET,
react_native_xplat_target("react/debug:debug"),
react_native_xplat_target("react/renderer/debug:debug"),
react_native_xplat_target("react/renderer/core:core"),
react_native_xplat_target("react/renderer/graphics:graphics"),
ReactCommon/react/renderer/components/image/ImageComponentDescriptor.h
+2 -1
View File
@@ -7,6 +7,7 @@
#pragma once
#include <react/debug/react_native_assert.h>
#include <react/renderer/components/image/ImageShadowNode.h>
#include <react/renderer/core/ConcreteComponentDescriptor.h>
#include <react/renderer/imagemanager/ImageManager.h>
@@ -28,7 +29,7 @@ class ImageComponentDescriptor final
void adopt(UnsharedShadowNode shadowNode) const override {
ConcreteComponentDescriptor::adopt(shadowNode);
assert(std::dynamic_pointer_cast<ImageShadowNode>(shadowNode));
react_native_assert(std::dynamic_pointer_cast<ImageShadowNode>(shadowNode));
auto imageShadowNode =
std::static_pointer_cast<ImageShadowNode>(shadowNode);
ReactCommon/react/renderer/components/image/conversions.h
+2 -1
View File
@@ -9,6 +9,7 @@
#include <better/map.h>
#include <folly/dynamic.h>
#include <react/debug/react_native_assert.h>
#include <react/renderer/graphics/conversions.h>
#include <react/renderer/imagemanager/primitives.h>
@@ -88,7 +89,7 @@ inline std::string toString(const ImageSource &value) {
}
inline void fromRawValue(const RawValue &value, ImageResizeMode &result) {
assert(value.hasType<std::string>());
react_native_assert(value.hasType<std::string>());
auto stringValue = (std::string)value;
if (stringValue == "cover") {
result = ImageResizeMode::Cover;