Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fabric: Simplifying RCTImageResponseObserverProxy interface

Browse Source 
Summary: There is no reason why RCTImageResponseObserverProxy accepts untyped pointer. This diff fixes that. The call sites now look much cleaner.

Reviewed By: sammy-SC

Differential Revision: D17923552

fbshipit-source-id: b08556e1164b00c9cf2676c0d9b1718ae60b2aca
This commit is contained in:
Valentin Shergin
2019-10-15 16:12:53 -07:00
committed by Facebook Github Bot
parent 23564ab44d
commit 01143859ff
4 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
React/Fabric/Mounting/ComponentViews/Image/RCTImageComponentView.mm
+1 -1
View File
@@ -39,7 +39,7 @@
_imageView.contentMode = (UIViewContentMode)RCTResizeModeFromImageResizeMode(defaultProps->resizeMode);
_imageResponseObserverProxy = std::make_unique<RCTImageResponseObserverProxy>((__bridge void *)self);
_imageResponseObserverProxy = std::make_unique<RCTImageResponseObserverProxy>(self);
self.contentView = _imageView;
}
React/Fabric/Mounting/ComponentViews/Slider/RCTSliderComponentView.mm
+4 -4
View File
@@ -55,10 +55,10 @@ using namespace facebook::react;
_sliderView.value = defaultProps->value;
_trackImageResponseObserverProxy = std::make_unique<RCTImageResponseObserverProxy>((__bridge void *)self);
_minimumTrackImageResponseObserverProxy = std::make_unique<RCTImageResponseObserverProxy>((__bridge void *)self);
_maximumTrackImageResponseObserverProxy = std::make_unique<RCTImageResponseObserverProxy>((__bridge void *)self);
_thumbImageResponseObserverProxy = std::make_unique<RCTImageResponseObserverProxy>((__bridge void *)self);
_trackImageResponseObserverProxy = std::make_unique<RCTImageResponseObserverProxy>(self);
_minimumTrackImageResponseObserverProxy = std::make_unique<RCTImageResponseObserverProxy>(self);
_maximumTrackImageResponseObserverProxy = std::make_unique<RCTImageResponseObserverProxy>(self);
_thumbImageResponseObserverProxy = std::make_unique<RCTImageResponseObserverProxy>(self);
self.contentView = _sliderView;
}
React/Fabric/RCTImageResponseObserverProxy.h
+1 -1
View File
@@ -18,7 +18,7 @@ namespace react {
class RCTImageResponseObserverProxy final : public ImageResponseObserver {
public:
RCTImageResponseObserverProxy(void *delegate);
RCTImageResponseObserverProxy(id<RCTImageResponseDelegate> delegate);
void didReceiveImage(ImageResponse const &imageResponse) const override;
void didReceiveProgress(float progress) const override;
React/Fabric/RCTImageResponseObserverProxy.mm
+2 -2
View File
@@ -14,8 +14,8 @@
namespace facebook {
namespace react {
RCTImageResponseObserverProxy::RCTImageResponseObserverProxy(void *delegate)
: delegate_((__bridge id<RCTImageResponseDelegate>)delegate)
RCTImageResponseObserverProxy::RCTImageResponseObserverProxy(id<RCTImageResponseDelegate> delegate)
: delegate_(delegate)
{
}