Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix misleading comment in RCTFabricSurface API

Browse Source 
Summary:
Using RCTFabricSurface in bridgeless mode, this comment seems incorrect to me.

`[_surface start]`  needs to be called after initialization, or else the stage and `SurfacePresenter` registration never happen.

Maybe this comment used to be true, but it is misleading with the current implementation.

Changelog: [Internal]

Reviewed By: shergin

Differential Revision: D22800934

fbshipit-source-id: c396cbd3fc1749b8e7ab571c9e7bc05cd352fc14
This commit is contained in:
Peter Argany
2020-07-28 14:41:26 -07:00
committed by Facebook GitHub Bot
parent 0bcc686c1c
commit 00bc73f625
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
React/Fabric/Surface/RCTFabricSurface.h
+1 -3
View File
@@ -71,9 +71,7 @@ NS_ASSUME_NONNULL_BEGIN
* A Surface object can be stopped and then restarted.
* The starting process includes initializing all underlying React Native
* infrastructure and running React app.
* Just initialized Surface object starts automatically, there is no need
* to call `start` explicitly. Surface also stops itself on deallocation
* automatically.
* Surface stops itself on deallocation automatically.
* Returns YES in case of success. Returns NO if the Surface is already
* started or stopped.
*/