fix: more review fixes, replace i with span

This commit is contained in:
Arman
2022-07-11 11:48:54 +02:00
parent 3af97e8aae
commit b26c34557e
10 changed files with 22 additions and 13 deletions
+1 -1
View File
@@ -3,6 +3,6 @@
</script>
<a {href}>
<i class="icon-cheveron-left" />
<span class="icon-cheveron-left" aria-hidden="true" />
<slot />
</a>
+4 -1
View File
@@ -84,7 +84,10 @@
</h1>
{#if $copyData?.value}
<Copy value={$copyData.value}>
<Pill button><i class="icon-duplicate" />{$copyData.text}</Pill>
<Pill button
><span
class="icon-duplicate"
aria-hidden="true" />{$copyData.text}</Pill>
</Copy>
{/if}
</svelte:fragment>
@@ -73,7 +73,7 @@
<div class="u-flex u-flex-vertical u-cross-center">
<div class="common-section">
<Button secondary round on:click={() => console.log('showCreate = true')}>
<i class="icon-plus" />
<span class="icon-plus" aria-hidden="true" />
</Button>
</div>
<div class="common-section">
@@ -110,7 +110,7 @@
<div class="u-flex u-flex-vertical u-cross-center">
<div class="common-section">
<Button secondary round on:click={() => (showCreate = true)}>
<i class="icon-plus" />
<span class="icon-plus" aria-hidden="true" />
</Button>
</div>
<div class="common-section">
@@ -51,7 +51,8 @@
<h3 class="tiles-title">{bucket.name}</h3>
<div class="u-flex u-main-space-between">
<Copy value={bucket.$id}>
<Pill button><i class="icon-duplicate" />Bucket ID</Pill>
<Pill button
><span class="icon-duplicate" aria-hidden="true" />Bucket ID</Pill>
</Copy>
<div class="">
<Tooltip icon="lock-closed" aria="encryption">
@@ -97,7 +98,7 @@
<div class="u-flex u-flex-vertical u-cross-center">
<div class="common-section">
<Button secondary round on:click={() => (showCreate = true)}>
<i class="icon-plus" />
<span class="icon-plus" aria-hidden="true" />
</Button>
</div>
<div class="common-section">
@@ -49,7 +49,8 @@
{#if !showDropdown}
<div>
<Pill button on:click={() => (showDropdown = !showDropdown)}
><span class="icon-pencil" /> <span class="text"> Team ID </span>
><span class="icon-pencil" aria-hidden="true" />
<span class="text"> Team ID </span>
</Pill>
</div>
{:else}
@@ -69,7 +69,9 @@
{#if !showDropdown}
<div>
<Pill button on:click={() => (showDropdown = !showDropdown)}
><span class="icon-pencil" /><span class="text"> User ID </span></Pill>
><span class="icon-pencil" aria-hidden="true" /><span class="text">
User ID
</span></Pill>
</div>
{:else}
<InnerModal bind:show={showDropdown}>
@@ -96,7 +96,9 @@
</TableCellText>
<TableCellText showOverflow title="ID">
<Copy value={user.$id}>
<Pill button><i class="icon-duplicate" />User ID</Pill>
<Pill button
><span class="icon-duplicate" aria-hidden="true" />
<span class="text">User ID</span></Pill>
</Copy>
</TableCellText>
<TableCellText title="Joined">
@@ -139,7 +141,7 @@
}
}}>
<Button secondary round on:click={() => (showCreate = true)}>
<i class="icon-plus" />
<span class="icon-plus" aria-hidden="true" />
</Button>
</div>
<div class="common-section">
@@ -117,7 +117,7 @@
}
}}>
<Button secondary round on:click={() => (showCreate = true)}>
<i class="icon-plus" />
<span class="icon-plus" aria-hidden="true" />
</Button>
</div>
<div class="common-section">
@@ -45,7 +45,7 @@
<Container>
<Search bind:search placeholder="Search by ID">
<Button on:click={() => (showCreate = true)}>
<span class="icon-plus" aria-hidden="true" /> <span class="text">Add Member</span>
<span class="icon-plus" aria-hidden="true" /> <span class="text">Create Member</span>
</Button>
</Search>
{#if $memberships?.total}
@@ -117,7 +117,7 @@
<div class="u-flex u-flex-vertical u-cross-center">
<div class="common-section">
<Button secondary round on:click={() => (showCreate = true)}>
<i class="icon-plus" />
<span class="icon-plus" aria-hidden="true" />
</Button>
</div>
<div class="common-section">