chore: resovle review comments

This commit is contained in:
Christy Jacob committed 2023-07-20 16:55:00 +04:00
1 parent 61ed63c509
commit ab93a3fb35
6 files changed
+29 -22

No files matched your search

+4 -5
View File
@@ -7,7 +7,7 @@
"name": "@appwrite/console",
"dependencies": {
"@analytics/google-analytics": "^1.0.5",
"@appwrite.io/console": "npm:christy-appwrite-console@0.0.5",
"@appwrite.io/console": "0.1.0",
"@appwrite.io/pink": "^0.0.6-rc.10",
"@popperjs/core": "^2.11.6",
"@sentry/svelte": "^7.44.2",
@@ -147,10 +147,9 @@
"integrity": "sha512-1Yw7u/COtxx06BfwlI+kVhsa/upKYzmCNrT4c8QDeCY2KMYlnijkUjtHiPU08HxyTIVB5j6d75O0YWVIHwQS8g=="
},
"node_modules/@appwrite.io/console": {
"name": "christy-appwrite-console",
"version": "0.0.5",
"resolved": "https://registry.npmjs.org/christy-appwrite-console/-/christy-appwrite-console-0.0.5.tgz",
"integrity": "sha512-9OHfJW1Tys4xeJh/p3kzNb92oqDT3zrz6Iu8ob6maKupyhb5ghWIa1ev0bowiYvJTDGkNVfDVXXHoXYbBbrmmQ==",
"version": "0.1.0",
"resolved": "https://registry.npmjs.org/@appwrite.io/console/-/console-0.1.0.tgz",
"integrity": "sha512-GzCRUmaXAVgpGwxBNI3PrtCLHz7CM+epBHDDTHw8B2u61KbijGBO3GrwreXy91fy00RJiEzGlMSRzDgwsF3Tsg==",
"dependencies": {
"cross-fetch": "3.1.5",
"isomorphic-form-data": "2.0.0"
+1 -1
View File
@@ -19,7 +19,7 @@
},
"dependencies": {
"@analytics/google-analytics": "^1.0.5",
"@appwrite.io/console": "npm:christy-appwrite-console@0.0.5",
"@appwrite.io/console": "0.1.0",
"@appwrite.io/pink": "^0.0.6-rc.10",
"@popperjs/core": "^2.11.6",
"@sentry/svelte": "^7.44.2",
+1 -1
View File
@@ -143,7 +143,7 @@ export enum Submit {
AuthStatusUpdate = 'submit_auth_status_update',
AuthPasswordHistoryUpdate = 'submit_auth_password_history_limit_update',
AuthPasswordDictionaryUpdate = 'submit_auth_password_dictionary_update',
AuthDisallowPersonalDataUpdate = 'submit_auth_disallow_personal_data_update',
AuthPersonalDataCheckUpdate = 'submit_auth_personal_data_check_update',
SessionsLengthUpdate = 'submit_sessions_length_update',
SessionsLimitUpdate = 'submit_sessions_limit_update',
SessionDelete = 'submit_session_delete',
@@ -2,7 +2,7 @@
import { Container } from '$lib/layout';
import UpdatePasswordDictionary from './updatePasswordDictionary.svelte';
import UpdatePasswordHistory from './updatePasswordHistory.svelte';
import UpdatePasswordPersonalData from './updatePasswordPersonalData.svelte';
import UpdatePersonalDataCheck from './updatePersonalDataCheck.svelte';
import UpdateSessionLength from './updateSessionLength.svelte';
import UpdateSessionsLimit from './updateSessionsLimit.svelte';
import UpdateUsersLimit from './updateUsersLimit.svelte';
@@ -14,5 +14,5 @@
<UpdateSessionsLimit />
<UpdatePasswordHistory />
<UpdatePasswordDictionary />
<UpdatePasswordPersonalData />
<UpdatePersonalDataCheck />
</Container>
@@ -10,38 +10,46 @@
import { project } from '../../store';
const projectId = $project.$id;
let disallowPersonalData = $project.authDisallowPersonalData ?? false;
let authPersonalDataCheck = $project.authPersonalDataCheck ?? false;
async function updateDisallowPersonalData() {
async function updatePersonalDataCheck() {
try {
await sdk.forConsole.projects.updateDisallowPersonalData(
projectId,
disallowPersonalData
const path = '/projects/' + $project.$id + '/auth/personal-data';
await sdk.forConsole.client.call(
'PATCH',
new URL(sdk.forConsole.client.config.endpoint + path),
{
'content-type': 'application/json'
},
{
projectId,
enabled: authPersonalDataCheck
}
);
await invalidate(Dependencies.PROJECT);
addNotification({
type: 'success',
message: 'Updated disallow personal data.'
message: 'Toggled personal data checks for passwords'
});
trackEvent(Submit.AuthDisallowPersonalDataUpdate);
trackEvent(Submit.AuthPersonalDataCheckUpdate);
} catch (error) {
addNotification({
type: 'error',
message: error.message
});
trackError(error, Submit.AuthDisallowPersonalDataUpdate);
trackError(error, Submit.AuthPersonalDataCheckUpdate);
}
}
</script>
<Form onSubmit={updateDisallowPersonalData}>
<Form onSubmit={updatePersonalDataCheck}>
<CardGrid>
<Heading tag="h2" size="7">Personal Data</Heading>
<svelte:fragment slot="aside">
<FormList>
<InputSwitch
bind:value={disallowPersonalData}
id="passwordHisotryEnabled"
bind:value={authPersonalDataCheck}
id="personalDataCheck"
label="Disallow Personal Data" />
</FormList>
<p class="text">
@@ -51,7 +59,7 @@
</svelte:fragment>
<svelte:fragment slot="actions">
<Button disabled={disallowPersonalData === $project.authDisallowPersonalData} submit
<Button disabled={authPersonalDataCheck === $project.authPersonalDataCheck} submit
>Update</Button>
</svelte:fragment>
</CardGrid>
@@ -3,7 +3,7 @@ import { page } from '$app/stores';
import type { Models } from '@appwrite.io/console';
import type { BarSeriesOption } from 'echarts/charts';
export const project = derived(page, ($page) => $page.data.project as Models.Project);
export const project = derived(page, ($page) => $page.data.project as Models.Project | any);
export const onboarding = derived(
project,
($project) => $project.platforms.length === 0 && $project.keys.length === 0