fix: design review

This commit is contained in:
Arman committed 2024-08-07 15:22:32 +02:00
1 parent 218c2d4791
commit 8de53cfc36
3 files changed
+17 -9

No files matched your search

@@ -19,7 +19,7 @@
import { scopes } from '$lib/constants';
import { isValueOfStringEnum } from '$lib/helpers/types';
import TemplateConfiguration from './steps/templateConfiguration.svelte';
import TemplateScopes from './steps/templateScopes.svelte';
import TemplatePermissions from './steps/templatePermissions.svelte';
import TemplateVariables from './steps/templateVariables.svelte';
import TemplateDeployment from './steps/templateDeployment.svelte';
import CreateRepository from './steps/createRepository.svelte';
@@ -120,8 +120,8 @@
component: TemplateConfiguration
});
$templateStepsComponents.set(2, {
label: 'Scopes',
component: TemplateScopes,
label: 'Permissions',
component: TemplatePermissions,
disabled: !$template?.scopes?.length
});
$templateStepsComponents.set(3, {
@@ -32,14 +32,14 @@
<FormList gap={16} class="u-margin-block-start-8">
<LabelCard name="behaviour" value="new" bind:group={$templateConfig.repositoryBehaviour}>
<svelte:fragment slot="title">Create a new repository</svelte:fragment>
Clone the template and create a new repository in your selected organization.
Clone the template to a newly created repository in your organization.
</LabelCard>
<LabelCard
name="behaviour"
value="existing"
bind:group={$templateConfig.repositoryBehaviour}>
<svelte:fragment slot="title">Add to existing repository</svelte:fragment>
Clone the template to an existing repository in your selected organization.
Clone the template to an existing repository in your organization.
</LabelCard>
</FormList>
@@ -47,7 +47,7 @@
<ul class="u-margin-block-start-8">
<LabelCard name="behaviour" value="manual" bind:group={$templateConfig.repositoryBehaviour}>
<svelte:fragment slot="title">Create manually</svelte:fragment>
Clone the template to an existing repository in your selected organization.
Deploy a function from a template and change the code using the CLI.
</LabelCard>
</ul>
</WizardStep>
@@ -4,6 +4,7 @@
import { WizardStep } from '$lib/layout';
import { onMount } from 'svelte';
import { template, templateConfig } from '../store';
import { tooltip } from '$lib/actions/tooltip';
let templateScopes = [];
onMount(() => {
@@ -26,7 +27,7 @@
<svelte:fragment slot="subtitle">
Enable recommended scopes and execute access for when your function is deployed.
</svelte:fragment>
<p>Execute permissions</p>
<h3>Execute permissions</h3>
<FormList class="u-margin-block-start-16">
<div class="user-profile">
<span class="avatar" style:--p-text-size="1rem">
@@ -34,7 +35,14 @@
</span>
<span class="user-profile-info u-flex u-main-space-between u-gap-16">
<div>
<p class="name u-bold">Public (anyone can execute)</p>
<p class="name u-bold">
Public (anyone can execute) <span
class="icon-info"
use:tooltip={{
content:
'You can further customize execute permissions in your function settings.'
}} />
</p>
<p class="text u-margin-block-start-4">
This could include unauthorized users and search engines.
</p>
@@ -49,7 +57,7 @@
</span>
</div>
</FormList>
<p class="text u-margin-block-start-48">Function scopes</p>
<h3 class="text u-margin-block-start-48">Function scopes</h3>
<FormList class="u-margin-block-start-16">
{#each templateScopes as scope, i}
<div class="user-profile">