mirror of
https://github.com/appwrite/console.git
synced 2026-11-18 20:47:21 +00:00
fix: prevent project Usage tab crash on missing usage breakdowns
The project Settings > Usage tab failed to render entirely, while every
other Settings tab worked. The API request succeeded; the crash was in
the page component's render:
Uncaught TypeError: Cannot read properties of undefined (reading 'length')
at +page.svelte:324
`data.usage.executionsBreakdown` was undefined. The console SDK types it
as a required `MetricBreakdown[]`, so the guard read `.length` on it
unconditionally. Because a throw during render aborts the whole render
pass, nothing mounted -- which is why the tab highlight moved to Usage
while the previously active tab's content stayed on screen instead of an
error page being shown.
Optional-chain both breakdown-table guards (`executionsBreakdown` and
`authPhoneCountryBreakdown`) so a missing breakdown hides just its table.
Also guard two latent instances of the same class on this page, since the
response demonstrably omits array fields the SDK types as required:
- `legendData` reduced over `databasesReads`/`databasesWrites` outside any
`{#if}`, so it would have crashed even earlier had those been missing.
- The db chart's `{#if dbReads || dbWrites}` passes when only one array is
present, but the body mapped both.
These are null-guards rather than defaulting the arrays to `[]`, because
`[]` is truthy and would flip several `{#if}` empty-state checks, silently
replacing "No data to show" cards with empty charts.
Separately, the attribution ping in `+layout.svelte` was fire-and-forget
with no `.catch()`, so a blocked request surfaced as an unhandled
`Failed to fetch` rejection that obscured real errors in the console.
This commit is contained in:
1 parent
a2a7e1a93b
commit
7e8011976c
2 files changed
+11
-7
No files matched your search
+6
-6
@@ -49,11 +49,11 @@
|
||||
$: legendData = [
|
||||
{
|
||||
name: 'Reads',
|
||||
value: clampMin(data.usage.databasesReads.reduce((sum, item) => sum + item.value, 0))
|
||||
value: clampMin((dbReads ?? []).reduce((sum, item) => sum + item.value, 0))
|
||||
},
|
||||
{
|
||||
name: 'Writes',
|
||||
value: clampMin(data.usage.databasesWrites.reduce((sum, item) => sum + item.value, 0))
|
||||
value: clampMin((dbWrites ?? []).reduce((sum, item) => sum + item.value, 0))
|
||||
}
|
||||
];
|
||||
|
||||
@@ -196,11 +196,11 @@
|
||||
series={[
|
||||
{
|
||||
name: 'Reads',
|
||||
data: [...dbReads.map((e) => [e.date, e.value])]
|
||||
data: [...(dbReads ?? []).map((e) => [e.date, e.value])]
|
||||
},
|
||||
{
|
||||
name: 'Writes',
|
||||
data: [...dbWrites.map((e) => [e.date, e.value])]
|
||||
data: [...(dbWrites ?? []).map((e) => [e.date, e.value])]
|
||||
}
|
||||
]} />
|
||||
</div>
|
||||
@@ -321,7 +321,7 @@
|
||||
data: [...executions.map((e) => [e.date, e.value])]
|
||||
}
|
||||
]} />
|
||||
{#if data.usage.executionsBreakdown.length > 0}
|
||||
{#if data.usage.executionsBreakdown?.length > 0}
|
||||
<Table.Root columns={2} let:root>
|
||||
<svelte:fragment slot="header" let:root>
|
||||
<Table.Header.Cell {root}>Function</Table.Header.Cell>
|
||||
@@ -579,7 +579,7 @@
|
||||
</span>
|
||||
</p>
|
||||
</div>
|
||||
{#if data.usage.authPhoneCountryBreakdown.length > 0}
|
||||
{#if data.usage.authPhoneCountryBreakdown?.length > 0}
|
||||
<Accordion title="Region breakdown">
|
||||
<Table.Root columns={3} let:root>
|
||||
<svelte:fragment slot="header" let:root>
|
||||
|
||||
@@ -58,7 +58,11 @@
|
||||
}
|
||||
|
||||
if (ref || referrer || utmSource || utmCampaign || utmMedium) {
|
||||
sdk.forConsole.sources.create(ref, referrer, utmSource, utmCampaign, utmMedium);
|
||||
// fire-and-forget: swallow failures so a blocked request doesn't
|
||||
// surface as an unhandled rejection
|
||||
sdk.forConsole.sources
|
||||
.create(ref, referrer, utmSource, utmCampaign, utmMedium)
|
||||
.catch(() => {});
|
||||
}
|
||||
|
||||
if (referrer || ref) {
|
||||
|
||||
Reference in new issue
Block a user