fix: Matej feedback

This commit is contained in:
Arman
2025-03-13 09:23:43 +01:00
parent c41e1da1e8
commit 0530c9cefb
4 changed files with 20 additions and 9 deletions
@@ -64,7 +64,7 @@
let silentMode = false;
let entrypoint = '';
let selectedScopes: string[] = [];
let execute = false;
let execute = true;
let variables: Partial<Models.TemplateVariable>[] = [];
let specification = specificationOptions[0].value;
@@ -4,16 +4,19 @@
export let templateScopes: string[];
export let selectedScopes: string[];
export let execute = false;
export let execute = true;
let scopeList = scopes
.filter((s) => templateScopes.includes(s.scope))
.map((s) => {
selectedScopes.push(s.scope);
return {
value: s,
checked: false
checked: true
};
});
$: console.log(selectedScopes);
</script>
<Fieldset legend="Permissions">
@@ -36,6 +36,7 @@
export let frameworks: Models.Framework[];
export let selectedFramework: Models.Framework;
$: frameworkData = frameworks.find((framework) => framework.key === selectedFramework?.key);
export let variables: Partial<Models.Variable>[] = [];
export let installCommand = '';
@@ -52,7 +53,11 @@
let currentVariable: Partial<Models.Variable>;
let frameworkId = selectedFramework.key;
$: frameworkData = frameworks.find((framework) => framework.key === selectedFramework?.key);
$: if (!installCommand || !buildCommand || !outputDirectory) {
installCommand ||= frameworkData?.adapters?.ssr?.installCommand;
buildCommand ||= frameworkData?.adapters?.ssr?.buildCommand;
outputDirectory ||= frameworkData?.adapters?.ssr?.outputDirectory;
}
</script>
<Fieldset legend="Settings">
@@ -87,7 +92,9 @@
size="s"
disabled={frameworkData?.adapters?.ssr?.installCommand ===
installCommand}
on:click={() => (installCommand = '')}>
on:click={() =>
(installCommand =
frameworkData?.adapters?.ssr?.installCommand)}>
Reset
</Button>
</Layout.Stack>
@@ -102,7 +109,8 @@
size="s"
disabled={frameworkData?.adapters?.ssr?.buildCommand ===
buildCommand}
on:click={() => (buildCommand = '')}>
on:click={() =>
(buildCommand = frameworkData?.adapters?.ssr?.buildCommand)}>
Reset
</Button>
</Layout.Stack>
@@ -117,7 +125,9 @@
size="s"
disabled={frameworkData?.adapters?.ssr?.outputDirectory ===
outputDirectory}
on:click={() => (outputDirectory = '')}>
on:click={() =>
(outputDirectory =
frameworkData?.adapters?.ssr?.outputDirectory)}>
Reset
</Button>
</Layout.Stack>
@@ -176,8 +176,6 @@
bind:selectedFramework={framework}
bind:variables
frameworks={data.frameworks.frameworks} />
<!-- <Domain bind:domain bind:domainIsValid /> -->
</Layout.Stack>
</Form>
<svelte:fragment slot="aside">