Commit Graph
39351 Commits
Author SHA1 Message Date
Cursor AgentandJake Barnby 5f8218da4f Merge branch 'main' into csv-import-upsert
Co-authored-by: Jake Barnby <abnegate@users.noreply.github.com>
2026-09-21 09:52:45 +00:00
Matej Bačo 4a66fccf8d Merge pull request #13765 from appwrite/fix/skip-domain-validation-after-api-check
fix(certificates): do not verify DNS again for a job the endpoint just verified
2026-09-21 11:44:12 +02:00
Cursor AgentandJake Barnby c456550c34 Merge branch 'main' into csv-import-upsert
Bring the branch onto current main. Import overwrite/skip already
landed there as onDuplicate (fail/skip/overwrite), so drop the 1.9.x
boolean overwrite/skip API, controller, and composer branch pins.

Co-authored-by: Jake Barnby <abnegate@users.noreply.github.com>
2026-09-21 09:42:38 +00:00
Harsh Mahajan 8aca5098e8 Merge pull request #13786 from appwrite/fix/membership-privacy-self
fix(teams): exempt a member's own membership from the privacy policy
2026-09-21 14:46:21 +05:30
Harsh Mahajan 5141f67ad6 Merge branch 'main' into fix/membership-privacy-self 2026-09-21 14:46:12 +05:30
Chirag Aggarwal 85f75bacd5 Merge pull request #13783 from appwrite/chore-react-native-stable
chore: mark the React Native SDK stable
2026-09-21 02:02:26 -07:00
Chirag Aggarwal 7c08cb2205 Merge pull request #13779 from appwrite/ci/gcrunner-presets-labels
ci: select runners by preset instead of a machine spec
2026-09-21 01:30:42 -07:00
Harsh Mahajan ce1f2001b5 Merge branch 'main' into fix/membership-privacy-self 2026-09-21 13:13:07 +05:30
ArnabChatterjee20k bea0ff3b20 Merge pull request #13785 from appwrite/feat-add-reply-params-messaging
Feat add reply params messaging
2026-09-21 12:28:31 +05:30
harsh mahajan 2f4091fea9 fix(teams): exempt a member's own membership from the privacy policy
The membership privacy policy is documented as controlling what members
can see about *other* members, but it was applied to every membership in
the list, including the requester's own. New projects are created with
`membershipsUserId` disabled, so a standard user listing team
memberships got an empty `userId` on every row - including their own -
and could no longer tell which membership was theirs. That also left
them unable to leave a team, since removing a membership needs its ID.

Treat the requester's own membership like a privileged read in both
`GET /v1/teams/:teamId/memberships` and
`GET /v1/teams/:teamId/memberships/:membershipId`, matching how
`Memberships/Delete.php` and `Memberships/Update.php` already identify
the caller's own membership. None of these fields are secret from the
member anyway - `GET /v1/account` returns all of them.

Fixes #13767
2026-09-21 11:30:48 +05:30
ArnabChatterjee20kandClaude Opus 4.8 3b3c627a10 fix(messaging): allow empty replyToName to clear the default
Text defaults to a minimum length of one, so an empty replyToName was
rejected. Use Text(128, 0) as the provider create actions do, letting an
empty string clear the custom reply-to name.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-09-21 11:30:48 +05:30
ArnabChatterjee20kandClaude Opus 4.8 bd97325488 test(messaging): cover reply-to clearing and delivered name
Assert an empty string clears the reply-to, and check both the address
and display name on the delivered mail.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-09-21 11:24:46 +05:30
ArnabChatterjee20kandClaude Opus 4.8 828030626d fix(messaging): let an empty reply-to restore the default
Accept an empty string for replyToEmail so a draft can drop a custom
reply-to and fall back to the provider or sender, matching the worker's
empty-value handling.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-09-21 11:24:39 +05:30
ArnabChatterjee20k 0b6d57a4eb Merge branch 'main' into feat-add-reply-params-messaging 2026-09-21 11:19:19 +05:30
ArnabChatterjee20kandClaude Opus 4.8 8b2309f2ce test(messaging): cover email reply-to persistence and delivery
Add e2e coverage for reply-to fields: persistence and validation on
create/update, and the delivered reply-to header over SMTP.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-09-21 11:16:32 +05:30
ArnabChatterjee20kandClaude Opus 4.8 502b531d4a feat(messaging): prefer message reply-to over provider default
buildEmailMessage now reads replyToEmail/replyToName from the message
data, falling back to the provider options when unset.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-09-21 11:16:25 +05:30
ArnabChatterjee20kandClaude Opus 4.8 776493f53d feat(messaging): accept replyToEmail and replyToName on email messages
Add optional reply-to address and name params to the create and update
email endpoints, persisted alongside the rest of the message data.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-09-21 11:16:19 +05:30
Chirag Aggarwal 27cf60b2f7 Merge branch 'main' into ci/gcrunner-presets-labels 2026-09-20 13:57:37 -07:00
Chirag Aggarwal 294eb16a96 Merge pull request #13782 from appwrite/ci/gcrunner-presets-c3d
ci: move the runner presets to c3d
2026-09-20 13:56:15 -07:00
Chirag Aggarwal c06844204e chore: mark the React Native SDK stable
The SDK ships 1.0.0, so it is no longer a beta and the release tooling must be allowed to bump it past 0.x.
2026-09-20 20:13:40 +01:00
Chirag Aggarwal b9a0919db2 ci: restore the preset labels after the family experiment
The explicit family=c3d labels were only there to measure the family change on
this branch, since the orchestrator reads .github/gcrunner.yml from the default
branch on a public repository. The measurement is done and the family moves into
the presets in #13782, so the labels go back to runner=<name>.
2026-09-20 19:28:47 +01:00
Chirag Aggarwal b1ab4c4eb0 ci: move the runner presets to c3d
n2d-standard-4 is EPYC Rome/Milan where RunsOn was handing out Zen 4, and these
lanes are short and largely single-thread bound, so the core generation shows up
directly: 42% slower than RunsOn on n2d against 21% on c3d, measured on #13779.

Only the family changes, so every existing runner=<name> keeps resolving.
2026-09-20 19:27:49 +01:00
Chirag Aggarwal 77778be907 Revert "ci: pin to europe-west3 to test a warm regional image cache"
This reverts commit eb475b5953.
2026-09-20 19:26:46 +01:00
Chirag Aggarwal eb475b5953 ci: pin to europe-west3 to test a warm regional image cache
Per-step timing shows the gap is image pulls, not compute: Run tests is 3s on
RunsOn against 5s here, while Pull Docker Image is 12s against 54s and Pull
Docker Compose images 50s against 87s.

The app image already comes from GCRUNNER_REGISTRY_PULL, but jobs spread over
eight regions, so each regional read-through cache is cold for a new SHA and the
image is fetched cross-region once per region. europe-west3 is where the source
registry lives, so pinning there should make every job after the first a local
hit.
2026-09-20 19:23:45 +01:00
Chirag Aggarwal fc52ec251c ci: try c3d explicitly to measure the family change
The preset run came out 42% slower than RunsOn across 38 of 39 jobs, because
n2d-standard-4 is EPYC Rome/Milan against the Zen 4 machines RunsOn was handing
out for runner=4cpu-linux-x64/family=c7. These lanes are short and largely
single-thread bound, so the core generation shows up directly.

Explicit labels rather than presets, because the orchestrator reads
.github/gcrunner.yml from the default branch on a public repository, so a
preset edit on this branch would not affect this branch is own CI. Measure
first, then move the family into the presets and restore runner=<name>.
2026-09-20 18:51:08 +01:00
Chirag Aggarwal a3c87b8c66 Merge branch 'main' into ci/gcrunner-presets-labels 2026-09-20 10:32:26 -07:00
Chirag Aggarwal bdcdbc0cb6 Merge pull request #13778 from appwrite/ci/gcrunner-presets-config
ci: add the gcrunner runner presets
2026-09-20 10:22:39 -07:00
Chirag Aggarwal df994a68a8 ci: drop the gcrunner.yml header comment 2026-09-20 12:19:16 +01:00
Chirag Aggarwal b57750077c ci: select runners by preset instead of a machine spec
Each label names the shape it needs and the shape is defined once, in
.github/gcrunner.yml. No preset names an image, so the default resolves the
image family rather than a build name that the image workflow can prune.

Depends on the presets being on main first: the orchestrator reads that file
from the default branch on a public repository, so these labels resolve only
after #13778 lands.
2026-09-20 12:17:54 +01:00
Chirag Aggarwal f998ba4b97 ci: add the gcrunner runner presets
Nothing references them yet. The orchestrator reads this file from the default
branch on a public repository, never from the pull request head, so a change
that adds the file and switches the labels together references presets that do
not exist on main and every job is held queued. The definitions have to land
first.
2026-09-20 12:16:43 +01:00
Chirag Aggarwal 1513146b25 Merge pull request #13776 from appwrite/ci/runner-image-family
ci: track the runner image family instead of one deleted build
2026-09-20 03:13:43 -07:00
Chirag Aggarwal 2b278e73dd ci: track the runner image family instead of one deleted build
The pinned image was pruned by the gcrunner image workflow, which keeps only the
newest three per family, so every job here queues forever behind
`The referenced image resource cannot be found`. The family always names the
newest build and cannot be collected out from under CI.
2026-09-20 10:37:33 +01:00
Matej Bačo 0fc5b7d30b Merge pull request #13773 from appwrite/chore-upgrade-detector-0.2.8
chore: upgrade utopia-php/detector to 0.2.8
2026-09-20 00:41:42 +02:00
Matej BačoandClaude Opus 5 8c60772b53 chore: upgrade utopia-php/detector to 0.2.8
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-19 23:46:58 +02:00
Matej Bačo 05118a6eff Merge pull request #13771 from appwrite/fix-vcs-comment-processing-image
fix(vcs): use the mapped status when picking the comment image extension
2026-09-19 23:28:52 +02:00
ArnabChatterjee20k a1051fda45 Merge pull request #13772 from appwrite/copilot/implement-deletion-feature
Guard push-ledger sweeper when `appwritePushLedger` is absent
2026-09-19 23:44:13 +05:30
copilot-swe-agent[bot]andArnabChatterjee20k d0e8faf6c9 fix: guard push ledger cleanup for missing collection
Co-authored-by: ArnabChatterjee20k <83803257+ArnabChatterjee20k@users.noreply.github.com>
2026-09-19 17:26:33 +00:00
Matej Bačo d6b820e064 Merge pull request #13710 from jaysomani/feat/jaspr-framework
feat: add Jaspr SSR framework support
2026-09-19 14:31:57 +02:00
Matej BačoandClaude Opus 5 ce8c7c2328 fix: use preinstalled Jaspr CLI for build command
`dart run jaspr_cli:jaspr build` only resolves jaspr_cli from the project's
own dependency graph, and `jaspr create` does not add it to pubspec.yaml --
Jaspr treats the CLI as part of the environment. A stock Jaspr project
therefore failed to build with:

    Could not find package `jaspr_cli` or file `jaspr_cli:jaspr`

The Flutter runtime now preinstalls the CLI and puts it on PATH
(open-runtimes/open-runtimes#572), so the plain binary is the correct call.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-19 13:59:42 +02:00
Matej BačoandClaude Opus 5 980c4f94a8 fix(vcs): use the mapped status when picking the comment image extension
Sites map the `processing` status onto the `building` image, but the
extension was still derived from the raw status, so a processing
deployment asked for `status-building-light.png`, which does not exist.
Only the `.gif` variants are shipped for `building`.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-19 11:48:44 +02:00
Matej BačoandClaude Fable 5.1 21b634f3da fix(certificates): do not verify DNS again for a job the endpoint just verified
The proxy create and re-verify endpoints run the multi-region DNS validator,
write the rule as verifying and enqueue generation. The worker then ran the
identical validator again seconds later: doubled DNS traffic when both pass,
and when the second run failed on a transient it wrote unverified over a
status the endpoint had just written. The certificate message now carries
skipDomainValidation, set by every enqueuer that verified DNS itself, and
the worker honours it. The renew check stays in place, unlike a forced job.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-18 18:48:13 +02:00
Levi van Noort f61009be8c Merge pull request #13762 from appwrite/feat/queue-3
chore(queue): move to utopia-php/queue 3.0
2026-09-18 16:29:41 +02:00
Chirag Aggarwal 1794c85dce Merge pull request #13761 from appwrite/refactor/messaging-adapter-di
refactor(messaging): build the platform's SMS adapter as a DI resource
2026-09-18 07:14:44 -07:00
Chirag Aggarwal 37a5481b15 Merge branch 'main' into refactor/messaging-adapter-di 2026-09-18 07:14:39 -07:00
Chirag Aggarwal f68355775c Merge pull request #13763 from appwrite/fix/id-token-unsupported-provider-test
test(account): expect validation to refuse a non-ID-token provider
2026-09-18 07:14:26 -07:00
Chirag Aggarwal 6a01e5e2b7 test(account): expect validation to refuse a non-ID-token provider
The provider whitelist no longer holds every OAuth provider, so github is
refused by the parameter before the action runs and never reaches the
PROJECT_PROVIDER_UNSUPPORTED guard.
2026-09-18 15:07:45 +01:00
Levi van Noort 0094fa47c7 Merge branch 'main' into feat/queue-3 2026-09-18 16:00:49 +02:00
Levi van Noort 2a0f45ec4b test(queue): assert the batched sibling at the worker boundary
The previous test's subject was the fake itself -- it drove
receiveBatch() directly and asserted the broker's return. Review called
that implementation-coupled and it is: a test whose subject is a fixture
proves the fixture, not the worker.

What matters about batching here is the boundary between queues. Batching
changes how many messages one receive claims, not how many run at once,
so the way it could go wrong is by occupying slots another queue is
serialised by, or by losing or duplicating what it claimed. The combined
-mode case now runs its parallel sibling batched and asserts what came
out: every message once, databases still serial, the cap still the cap.

Worth knowing what this cannot see: a batch size that is ignored outright
behaves identically at this boundary, because the whole point of a batch
is fewer round trips and nothing else. Claiming is not observable from
out here.
2026-09-18 15:27:59 +02:00
Chirag Aggarwal 7125b4c5f3 refactor(messaging): drop imports the extraction left behind 2026-09-18 14:25:47 +01:00
Levi van Noort a0fd9a00ac test(queue): prove the in-memory fake serves a batched receive
Review flagged rightPopMany() for ignoring $timeout. It does, as every
pop in this fake does -- nothing here blocks, an empty pop yields, and
that is what keeps a busy receive loop from starving the handlers it
shares a thread with. Making one method block would be a new behaviour,
not a fix.

The real defect underneath was quieter: each message after the first went
back through pop(), so a batch shorter than asked ended on a yield the
real connection never takes. LMPOP waits for the first message only and
takes the company it finds. The rest now comes straight off the list.

A batch the fake cannot serve looks exactly like an idle queue, so the
failure it would cause is silence. The test claims a three-message
backlog in one receive and asserts the order and the drained queue --
seen red against a rightPopMany() that returns nothing.
2026-09-18 15:23:18 +02:00