Appwrite/appwrite
1
0
Fork 0
mirror of https://github.com/appwrite/appwrite.git synced 2026-05-26 13:51:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix path param

Browse Source
This commit is contained in:
Jake Barnby
2025-06-10 00:22:38 -04:00
parent 9fc2c5db69
commit fd7d4db4c4
2 changed files with 13 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/controllers/api/databases.php
+2 -2
View File
@@ -4464,7 +4464,7 @@ App::put('/v1/databases/:databaseId/collections/:collectionId/documents/:documen
$response->dynamic($document, Response::MODEL_DOCUMENT);
});
App::patch('/v1/databases/:databaseId/collections/:collectionId/documents/:documentId/:key/increment')
App::patch('/v1/databases/:databaseId/collections/:collectionId/documents/:documentId/:attribute/increment')
->desc('Increment document attribute')
->groups(['api', 'database'])
->label('event', 'databases.[databaseId].collections.[collectionId].documents.[documentId].upsert')
@@ -4541,7 +4541,7 @@ App::patch('/v1/databases/:databaseId/collections/:collectionId/documents/:docum
$response->dynamic($document, Response::MODEL_DOCUMENT);
});
App::patch('/v1/databases/:databaseId/collections/:collectionId/documents/:documentId/:key/decrement')
App::patch('/v1/databases/:databaseId/collections/:collectionId/documents/:documentId/:attribute/decrement')
->desc('Decrement document attribute')
->groups(['api', 'database'])
->label('event', 'databases.[databaseId].collections.[collectionId].documents.[documentId].decrement')
tests/e2e/Services/Databases/DatabasesBase.php
+11 -10
View File
@@ -5302,7 +5302,7 @@ trait DatabasesBase
/**
* @throws \Exception
*/
public function testIncrementAttributeRoutes(): array
public function testIncrementAttribute(): void
{
$database = $this->client->call(Client::METHOD_POST, '/databases', [
'content-type' => 'application/json',
@@ -5337,10 +5337,9 @@ trait DatabasesBase
]), [
'key' => 'count',
'required' => true,
'default' => 0,
]);
\sleep(1);
\sleep(2);
// Create document with initial count = 5
$doc = $this->client->call(Client::METHOD_POST, '/databases/' . $databaseId . '/collections/' . $collectionId . '/documents', array_merge([
@@ -5348,7 +5347,9 @@ trait DatabasesBase
'x-appwrite-project' => $this->getProject()['$id'],
], $this->getHeaders()), [
'documentId' => 'counter1',
'data' => ['count' => 5],
'data' => [
'count' => 5
],
'permissions' => [
Permission::read(Role::any()),
Permission::update(Role::any()),
@@ -5402,7 +5403,7 @@ trait DatabasesBase
$this->assertEquals(404, $notFound['headers']['status-code']);
}
public function testDecrementAttributeRoutes(array $data): void
public function testDecrementAttribute(): void
{
$database = $this->client->call(Client::METHOD_POST, '/databases', [
'content-type' => 'application/json',
@@ -5439,18 +5440,16 @@ trait DatabasesBase
]), [
'key' => 'count',
'required' => true,
'default' => 10,
]);
\sleep(1);
\sleep(2);
// Create document with initial count = 10
$documentId = 'counter1';
$doc = $this->client->call(Client::METHOD_POST, '/databases/' . $databaseId . '/collections/' . $collectionId . '/documents', array_merge([
'content-type' => 'application/json',
'x-appwrite-project' => $this->getProject()['$id'],
], $this->getHeaders()), [
'documentId' => $documentId,
'documentId' => ID::unique(),
'data' => ['count' => 10],
'permissions' => [
Permission::read(Role::any()),
@@ -5458,6 +5457,8 @@ trait DatabasesBase
],
]);
$documentId = $doc['body']['$id'];
// Decrement by default 1 (count = 10 -> 9)
$dec = $this->client->call(Client::METHOD_PATCH, '/databases/' . $databaseId . '/collections/' . $collectionId . '/documents/' . $documentId . '/count/decrement', array_merge([
'content-type' => 'application/json',
@@ -5495,7 +5496,7 @@ trait DatabasesBase
]), ['min' => 7]);
$this->assertEquals(400, $err['headers']['status-code']);
// Test type error on non-numeric attribute
// Test type error on non-numeric attribut
$typeErr = $this->client->call(Client::METHOD_PATCH, '/databases/' . $databaseId . '/collections/' . $collectionId . '/documents/' . $documentId . '/count/decrement', array_merge([
'content-type' => 'application/json',
'x-appwrite-project' => $this->getProject()['$id'],