Appwrite/appwrite
1
0
Fork 0
mirror of https://github.com/appwrite/appwrite.git synced 2026-05-26 13:51:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent certificate deletion race condition

Browse Source
This commit is contained in:
Matej Bačo
2025-06-24 12:42:03 +02:00
parent 030d37fd5f
commit f3e7b8eb24
1 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Appwrite/Platform/Workers/Deletes.php
+15
View File
@@ -1192,6 +1192,21 @@ class Deletes extends Action
private function deleteRule(Database $dbForPlatform, Document $document, CertificatesAdapter $certificates): void
{
$domain = $document->getAttribute('domain');
// Race condition prevention
if (System::getEnv('_APP_RULES_FORMAT') === 'md5') {
$rule = $dbForPlatform->getDocument('rules', md5($domain));
} else {
$rule = $dbForPlatform->findOne('rules', [
Query::equal('domain', [$domain]),
Query::limit(1)
]);
}
if ($rule->isEmpty()) {
Console::warning("Race condition in certificate deletion prevented for domain {$domain}");
return;
}
$certificates->deleteCertificate($domain);
// Delete certificate document, so Appwrite is aware of change