Replace generic APP_VCS_COMMIT_* aliases with a real Gitea constant

APP_VCS_COMMIT_USERNAME/URL were dead code (zero usages), and
APP_VCS_COMMIT_EMAIL was just an alias for APP_VCS_GITHUB_EMAIL --
meaning Gitea's self-commit check was silently comparing a Gitea commit's
author against GitHub's bot identity, which a real Gitea commit could
never match. Add a real APP_VCS_GITEA_EMAIL instead of a fake-generic
alias; Gitea has no bot-commit-push flow yet, so username/url aren't
needed until it does.
This commit is contained in:
harsh mahajan committed 2026-07-14 18:59:11 +05:30
1 parent 534b695dad
commit e71bec65f2
2 files changed
+5 -4

No files matched your search

+4 -3
View File
@@ -108,9 +108,10 @@ const APP_SDK_PLATFORM_STATIC = 'static';
const APP_VCS_GITHUB_USERNAME = 'Appwrite';
const APP_VCS_GITHUB_EMAIL = 'team@appwrite.io';
const APP_VCS_GITHUB_URL = 'https://github.com/TeamAppwrite';
const APP_VCS_COMMIT_USERNAME = APP_VCS_GITHUB_USERNAME;
const APP_VCS_COMMIT_EMAIL = APP_VCS_GITHUB_EMAIL;
const APP_VCS_COMMIT_URL = APP_VCS_GITHUB_URL;
// Gitea has no bot-commit-push flow yet (unlike GitHub's classic template
// merge), so only the email is needed, to detect Appwrite's own commits and
// skip re-triggering a build on them.
const APP_VCS_GITEA_EMAIL = 'team@appwrite.io';
const APP_BRANDED_EMAIL_BASE_TEMPLATE = 'email-base-styled';
// Embeddings
@@ -140,7 +140,7 @@ class Create extends Action
Span::add('vcs.gitea.event.repo.name', $providerRepositoryName);
Span::add('vcs.gitea.event.branch', $providerBranch);
if ($providerCommitAuthorEmail === APP_VCS_COMMIT_EMAIL || $providerBranchDeleted) {
if ($providerCommitAuthorEmail === APP_VCS_GITEA_EMAIL || $providerBranchDeleted) {
return;
}