Fix compute build specification defaults

This commit is contained in:
Torsten Dittmann committed 2026-06-23 14:47:06 +04:00
1 parent 908d4875af
commit dc50f940bf
5 files changed
+38 -11

No files matched your search

@@ -50,17 +50,21 @@ class Base extends Action
);
$allowedSpecifications = $specificationValidator->getAllowedSpecifications();
if (empty($allowedSpecifications)) {
return $fallback;
}
if ($preferFallback && !array_key_exists($planKey, $plan) && \in_array($fallback, $allowedSpecifications)) {
return $fallback;
}
// If there is no plan use the highest specification
if (empty($plan)) {
return end($allowedSpecifications) ?: '';
return end($allowedSpecifications);
}
// Otherwise, use the lowest specification available in the plan
return $allowedSpecifications[0] ?? '';
return $allowedSpecifications[0];
}
public function redeployVcsFunction(Request $request, Document $function, Document $project, Document $installation, Database $dbForProject, BuildPublisher $publisherForBuilds, Document $template, GitHub $github, bool $activate, array $platform = [], string $referenceType = 'branch', string $reference = ''): Document
@@ -98,11 +98,12 @@ class Create extends Base
->param('providerRootDirectory', '', new Text(128, 0), 'Path to function code in the linked repo.', true)
->param('providerBranches', [], new ArrayList(new Text(128), APP_LIMIT_ARRAY_PARAMS_SIZE), 'List of branch name patterns to trigger automatic deployments. Supports wildcards. Leave empty to deploy on all branches.', true)
->param('providerPaths', [], new ArrayList(new Text(128), APP_LIMIT_ARRAY_PARAMS_SIZE), 'List of file path patterns to trigger automatic deployments. Supports wildcards. Leave empty to deploy on all file changes.', true)
->param('buildSpecification', fn (array $plan) => $this->getDefaultSpecification($plan), fn (array $plan) => new Specification(
->param('buildSpecification', fn (array $plan) => $this->getDefaultSpecification($plan, 'buildSpecifications'), fn (array $plan) => new Specification(
$plan,
Config::getParam('specifications', []),
System::getEnv('_APP_COMPUTE_CPUS', 0),
System::getEnv('_APP_COMPUTE_MEMORY', 0)
System::getEnv('_APP_COMPUTE_MEMORY', 0),
'buildSpecifications'
), 'Build specification for the function deployments.', true, ['plan'])
->param('runtimeSpecification', fn (array $plan) => $this->getDefaultSpecification($plan), fn (array $plan) => new Specification(
$plan,
@@ -90,12 +90,13 @@ class Update extends Base
->param('providerRootDirectory', '', new Text(128, 0), 'Path to function code in the linked repo.', true)
->param('providerBranches', null, new Nullable(new ArrayList(new Text(128), APP_LIMIT_ARRAY_PARAMS_SIZE)), 'List of branch name patterns to trigger automatic deployments. Supports wildcards. Leave empty to deploy on all branches.', true)
->param('providerPaths', null, new Nullable(new ArrayList(new Text(128), APP_LIMIT_ARRAY_PARAMS_SIZE)), 'List of file path patterns to trigger automatic deployments. Supports wildcards. Leave empty to deploy on all file changes.', true)
->param('buildSpecification', fn (array $plan) => $this->getDefaultSpecification($plan), fn (array $plan) => new Specification(
->param('buildSpecification', null, fn (array $plan) => new Nullable(new Specification(
$plan,
Config::getParam('specifications', []),
System::getEnv('_APP_COMPUTE_CPUS', 0),
System::getEnv('_APP_COMPUTE_MEMORY', 0)
), 'Build specification for the function deployments.', true, ['plan'])
System::getEnv('_APP_COMPUTE_MEMORY', 0),
'buildSpecifications'
)), 'Build specification for the function deployments.', true, ['plan'])
->param('runtimeSpecification', fn (array $plan) => $this->getDefaultSpecification($plan), fn (array $plan) => new Specification(
$plan,
Config::getParam('specifications', []),
@@ -137,7 +138,7 @@ class Update extends Base
string $providerRootDirectory,
?array $providerBranches,
?array $providerPaths,
string $buildSpecification,
?string $buildSpecification,
string $runtimeSpecification,
int $deploymentRetention,
Request $request,
@@ -173,6 +174,8 @@ class Update extends Base
$runtime = $function->getAttribute('runtime');
}
$buildSpecification ??= $function->getAttribute('buildSpecification', APP_COMPUTE_SPECIFICATION_DEFAULT);
$repositoryId = $function->getAttribute('repositoryId', '');
$repositoryInternalId = $function->getAttribute('repositoryInternalId', '');
@@ -86,13 +86,13 @@ class Update extends Base
->param('providerRootDirectory', '', new Text(128, 0), 'Path to site code in the linked repo.', true)
->param('providerBranches', null, new Nullable(new ArrayList(new Text(128), APP_LIMIT_ARRAY_PARAMS_SIZE)), 'List of branch name patterns to trigger automatic deployments. Supports wildcards. Leave empty to deploy on all branches.', true)
->param('providerPaths', null, new Nullable(new ArrayList(new Text(128), APP_LIMIT_ARRAY_PARAMS_SIZE)), 'List of file path patterns to trigger automatic deployments. Supports wildcards. Leave empty to deploy on all file changes.', true)
->param('buildSpecification', fn (array $plan) => $this->getDefaultSpecification($plan, 'buildSpecifications', APP_SITES_BUILD_SPECIFICATION_DEFAULT, true), fn (array $plan) => new Specification(
->param('buildSpecification', null, fn (array $plan) => new Nullable(new Specification(
$plan,
Config::getParam('specifications', []),
System::getEnv('_APP_COMPUTE_CPUS', 0),
System::getEnv('_APP_COMPUTE_MEMORY', 0),
'buildSpecifications'
), 'Build specification for the site deployments.', true, ['plan'])
)), 'Build specification for the site deployments.', true, ['plan'])
->param('runtimeSpecification', fn (array $plan) => $this->getDefaultSpecification($plan), fn (array $plan) => new Specification(
$plan,
Config::getParam('specifications', []),
@@ -134,7 +134,7 @@ class Update extends Base
string $providerRootDirectory,
?array $providerBranches,
?array $providerPaths,
string $buildSpecification,
?string $buildSpecification,
string $runtimeSpecification,
int $deploymentRetention,
Request $request,
@@ -178,6 +178,8 @@ class Update extends Base
$framework = $site->getAttribute('framework');
}
$buildSpecification ??= $site->getAttribute('buildSpecification', APP_SITES_BUILD_SPECIFICATION_DEFAULT);
$repositoryId = $site->getAttribute('repositoryId', '');
$repositoryInternalId = $site->getAttribute('repositoryInternalId', '');
@@ -1703,6 +1703,23 @@ final class SitesCustomServerTest extends Scope
$this->assertEquals($buildSpecification, $site['body']['buildSpecification']);
$this->assertEquals(Specification::S_1VCPU_1GB, $site['body']['runtimeSpecification']);
$site = $this->updateSite([
'buildRuntime' => 'node-22',
'fallbackFile' => '',
'framework' => 'other',
'name' => 'Test Site',
'outputDirectory' => './',
'providerBranch' => 'main',
'providerRootDirectory' => './',
'$id' => $siteId,
'runtimeSpecification' => Specification::S_1VCPU_1GB,
]);
$this->assertEquals(200, $site['headers']['status-code']);
$this->assertNotEmpty($site['body']['$id']);
$this->assertEquals($buildSpecification, $site['body']['buildSpecification']);
$this->assertEquals(Specification::S_1VCPU_1GB, $site['body']['runtimeSpecification']);
// Change the specs to 1vcpu 512mb
$site = $this->updateSite([
'buildRuntime' => 'node-22',