Appwrite/appwrite
1
0
Fork 0
mirror of https://github.com/appwrite/appwrite.git synced 2026-05-26 13:51:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: remove curl request from DELETE /function

Browse Source
This commit is contained in:
Christy Jacob
2022-01-28 04:26:19 +04:00
parent 608eff458c
commit dbcf479cd9
2 changed files with 2 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/controllers/api/functions.php
-29
View File
@@ -431,35 +431,6 @@ App::delete('/v1/functions/:functionId')
$function = $dbForProject->getDocument('functions', $functionId);
// // Request executor to delete deployment containers
// $ch = \curl_init();
// \curl_setopt($ch, CURLOPT_CUSTOMREQUEST, 'DELETE');
// \curl_setopt($ch, CURLOPT_URL, "http://appwrite-executor/v1/functions/$functionId");
// \curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
// \curl_setopt($ch, CURLOPT_TIMEOUT, 900);
// \curl_setopt($ch, CURLOPT_CONNECTTIMEOUT, 10);
// \curl_setopt($ch, CURLOPT_HTTPHEADER, [
// 'Content-Type: application/json',
// 'x-appwrite-project: '.$project->getId(),
// 'x-appwrite-executor-key: '. App::getEnv('_APP_EXECUTOR_SECRET', '')
// ]);
// $executorResponse = \curl_exec($ch);
// $error = \curl_error($ch);
// if (!empty($error)) {
// throw new Exception('Executor Cleanup Error: ' . $error, 500);
// }
// // Check status code
// $statusCode = \curl_getinfo($ch, CURLINFO_HTTP_CODE);
// if (200 !== $statusCode) {
// throw new Exception('Executor error: ' . $executorResponse, $statusCode);
// }
// \curl_close($ch);
if ($function->isEmpty()) {
throw new Exception('Function not found', 404);
}
app/workers/deletes.php
+2
View File
@@ -342,6 +342,8 @@ class DeletesV1 extends Worker
new Query('functionId', Query::TYPE_EQUAL, [$document->getId()])
], $dbForProject);
// Send delete request to executor
}