Appwrite/appwrite
1
0
Fork 0
mirror of https://github.com/appwrite/appwrite.git synced 2026-05-26 13:51:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

removed redundant key

Browse Source
This commit is contained in:
ArnabChatterjee20k
2026-01-28 19:04:42 +05:30
parent b785dea7ac
commit cbe13d71f1
2 changed files with 15 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Appwrite/Messaging/Adapter/Realtime.php
+10 -9
View File
@@ -231,18 +231,19 @@ class Realtime extends MessagingAdapter
$payload = $event['data']['payload'] ?? [];
foreach ($this->subscriptions[$event['project']][$role][$channel] as $id => $queryMap) {
$matchedQueryKeys = [];
// for representing a all query subscribed channel
if (isset($queryMap[''])) {
$matchedQueryKeys[] = '';
} else {
foreach (array_keys($queryMap) as $queryKey) {
$parsed = Query::parseQueries([$queryKey]);
if (!empty(RuntimeQuery::filter($parsed, $payload))) {
$matchedQueryKeys[] = $queryKey;
}
$receivers[$id] = $matchedQueryKeys;
continue;
}
foreach (array_keys($queryMap) as $queryKey) {
$parsed = Query::parseQueries([$queryKey]);
if (!empty(RuntimeQuery::filter($parsed, $payload))) {
$matchedQueryKeys[] = $queryKey;
}
}
$receivers[$id] = $matchedQueryKeys;
if (!empty($matchedQueryKeys)) {
$receivers[$id] = $matchedQueryKeys;
}
}
break;
}
tests/e2e/Services/Realtime/RealtimeCustomClientQueryTest.php
+5 -5
View File
@@ -1608,7 +1608,7 @@ class RealtimeCustomClientQueryTest extends Scope
Query::equal('category', ['gold']),
])->toString();
// Subscribe with no queries -> should receive all events, queryKeys = ['']
// Subscribe with no queries -> should receive all events, queryKeys = []
$clientAll = $this->getWebsocket(['documents'], [
'origin' => 'http://localhost',
'cookie' => 'a_session_' . $projectId . '=' . $session,
@@ -1660,13 +1660,13 @@ class RealtimeCustomClientQueryTest extends Scope
],
]);
// clientAll: should receive event, queryKeys = ['']
// clientAll: should receive event, queryKeys = []
$eventAll = json_decode($clientAll->receive(), true);
$this->assertEquals('event', $eventAll['type']);
$this->assertEquals($docActiveGoldId, $eventAll['data']['payload']['$id']);
$this->assertArrayHasKey('queryKeys', $eventAll['data']);
$this->assertIsArray($eventAll['data']['queryKeys']);
$this->assertEquals([''], $eventAll['data']['queryKeys']);
$this->assertCount(0, $eventAll['data']['queryKeys']);
// clientQ1: should receive event, queryKeys contains queryStatusActive
$eventQ1 = json_decode($clientQ1->receive(), true);
@@ -1704,13 +1704,13 @@ class RealtimeCustomClientQueryTest extends Scope
],
]);
// clientAll: should receive event, queryKeys = ['']
// clientAll: should receive event, queryKeys = []
$eventAll2 = json_decode($clientAll->receive(), true);
$this->assertEquals('event', $eventAll2['type']);
$this->assertEquals($docPendingSilverId, $eventAll2['data']['payload']['$id']);
$this->assertArrayHasKey('queryKeys', $eventAll2['data']);
$this->assertIsArray($eventAll2['data']['queryKeys']);
$this->assertEquals([''], $eventAll2['data']['queryKeys']);
$this->assertCount(0, $eventAll2['data']['queryKeys']);
// clientQ1: should NOT receive event (status is pending)
try {