mirror of
https://github.com/appwrite/appwrite.git
synced 2026-11-18 20:36:03 +00:00
Fix CodeQL + Greptile review on custom-domains PR
- Transfer::extractServices match was missing GROUP_SETTINGS; callers hit the default 'No service group found' branch even though GROUP_SETTINGS_RESOURCES exists. - Destination's redirect-rule fanout called ProxyResourceType::FUNCTION() which the SDK generator renames to FUNCTIONMODEL() because FUNCTION is a PHP reserved keyword. Underlying value is still 'function'.
This commit is contained in:
1 parent
cc7d68aaad
commit
afdf42c493
2 files changed
+2
-1
No files matched your search
@@ -3360,7 +3360,7 @@ class Appwrite extends Destination
|
||||
|
||||
$resourceType = $deploymentResourceType === 'site'
|
||||
? ProxyResourceType::SITE()
|
||||
: ProxyResourceType::FUNCTION();
|
||||
: ProxyResourceType::FUNCTIONMODEL();
|
||||
|
||||
$this->proxy->createRedirectRule(
|
||||
$resource->getDomain(),
|
||||
|
||||
@@ -448,6 +448,7 @@ class Transfer
|
||||
self::GROUP_MESSAGING => array_merge($resources, self::GROUP_MESSAGING_RESOURCES),
|
||||
self::GROUP_BACKUPS => array_merge($resources, self::GROUP_BACKUPS_RESOURCES),
|
||||
self::GROUP_DOMAINS => array_merge($resources, self::GROUP_DOMAINS_RESOURCES),
|
||||
self::GROUP_SETTINGS => array_merge($resources, self::GROUP_SETTINGS_RESOURCES),
|
||||
default => throw new \Exception('No service group found'),
|
||||
};
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user