Appwrite/appwrite
1
0
Fork 0
mirror of https://github.com/appwrite/appwrite.git synced 2026-05-26 13:51:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(analyze): drop redundant null-check on injected GeoRecord

Browse Source 
PHPStan flagged Executions/Create.php:242 `if ($geoRecord)` as always
true. GeoRecord is DI-injected and non-nullable; the inner guard is
dead weight. Outer `if (!empty($ip))` is the real condition.
This commit is contained in:
Damodar Lohani
2026-04-23 01:47:52 +00:00
parent cf9db4f89f
commit a822a94545
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Appwrite/Platform/Modules/Functions/Http/Executions/Create.php
+4 -6
View File
@@ -239,13 +239,11 @@ class Create extends Base
$headers['x-appwrite-client-ip'] = $ip;
if (!empty($ip)) {
if ($geoRecord) {
$eu = Config::getParam('locale-eu');
$eu = Config::getParam('locale-eu');
$headers['x-appwrite-country-code'] = $geoRecord->getCountryCode();
$headers['x-appwrite-continent-code'] = $geoRecord->getContinentCode();
$headers['x-appwrite-continent-eu'] = (\in_array(($geoRecord->getCountryCode()), $eu)) ? 'true' : 'false';
}
$headers['x-appwrite-country-code'] = $geoRecord->getCountryCode();
$headers['x-appwrite-continent-code'] = $geoRecord->getContinentCode();
$headers['x-appwrite-continent-eu'] = (\in_array(($geoRecord->getCountryCode()), $eu)) ? 'true' : 'false';
}
$headersFiltered = [];