mirror of
https://github.com/appwrite/appwrite.git
synced 2026-11-18 20:36:03 +00:00
fix: use target user for admin membership lookup and skip MFA check when impersonating
This commit is contained in:
1 parent
461ee1cc0b
commit
a7c753e536
1 file changed
+4
-2
@@ -299,7 +299,8 @@ Http::init()
|
||||
elseif (($project->getId() === 'console' && ! $team->isEmpty() && ! $user->isEmpty()) || ($project->getId() !== 'console' && ! $user->isEmpty() && $mode === APP_MODE_ADMIN)) {
|
||||
$teamId = $team->getId();
|
||||
$adminRoles = [];
|
||||
$memberships = $user->getAttribute('memberships', []);
|
||||
$membershipSource = !$impersonatorUser->isEmpty() ? $targetUser : $user;
|
||||
$memberships = $membershipSource->getAttribute('memberships', []);
|
||||
foreach ($memberships as $membership) {
|
||||
if ($membership->getAttribute('confirm', false) === true && $membership->getAttribute('teamId') === $teamId) {
|
||||
$adminRoles = $membership->getAttribute('roles', []);
|
||||
@@ -474,7 +475,8 @@ Http::init()
|
||||
$minimumFactors = ($mfaEnabled && $hasMoreFactors) ? 2 : 1;
|
||||
|
||||
// Step 13: Handle Multi-Factor Authentication
|
||||
if (! in_array('mfa', $route->getGroups())) {
|
||||
// Skip MFA check when impersonating — the actor already satisfied their own MFA during login.
|
||||
if (! in_array('mfa', $route->getGroups()) && $impersonatorUser->isEmpty()) {
|
||||
if ($session && \count($session->getAttribute('factors', [])) < $minimumFactors) {
|
||||
throw new Exception(Exception::USER_MORE_FACTORS_REQUIRED);
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user