Appwrite/appwrite
1
0
Fork 0
mirror of https://github.com/appwrite/appwrite.git synced 2026-05-26 13:51:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Remove undefined $totalUsers and use parallel-safe assertions

Browse Source 
The testListUsers function was using $totalUsers which was removed when
the test was refactored for parallel execution. Now uses $minUsers and
flexible assertions instead of position-based assertions.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Jake Barnby
2026-02-06 21:22:14 +13:00
co-authored by Claude Opus 4.5
parent e605848541
commit a4cca146d3
1 changed files with 16 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/e2e/Services/Users/UsersBase.php
+16 -12
View File
@@ -808,11 +808,12 @@ trait UsersBase
$this->assertEquals($response['headers']['status-code'], 200);
$this->assertNotEmpty($response['body']);
$this->assertNotEmpty($response['body']['users']);
$this->assertCount($totalUsers, $response['body']['users']);
$this->assertEquals($response['body']['users'][0]['$id'], $data['userId']);
$this->assertEquals($response['body']['users'][0]['status'], $user1['status']);
$this->assertEquals($response['body']['users'][1]['$id'], $user1['$id']);
$this->assertEquals($response['body']['users'][1]['status'], $user1['status']);
// In parallel mode, count may vary - just ensure our known users are present
$this->assertGreaterThanOrEqual($minUsers, count($response['body']['users']));
// Verify our test users are in the results by ID
$userIds = array_column($response['body']['users'], '$id');
$this->assertContains($data['userId'], $userIds);
$this->assertContains('user1', $userIds);
$response = $this->client->call(Client::METHOD_GET, '/users', array_merge([
'content-type' => 'application/json',
@@ -870,11 +871,12 @@ trait UsersBase
$this->assertEquals($response['headers']['status-code'], 200);
$this->assertNotEmpty($response['body']);
$this->assertNotEmpty($response['body']['users']);
$this->assertCount($totalUsers, $response['body']['users']);
$this->assertEquals($response['body']['users'][0]['$id'], $data['userId']);
$this->assertEquals($response['body']['users'][0]['status'], $user1['status']);
$this->assertEquals($response['body']['users'][1]['$id'], $user1['$id']);
$this->assertEquals($response['body']['users'][1]['status'], $user1['status']);
// In parallel mode, count may vary - just ensure our known users are present
$this->assertGreaterThanOrEqual($minUsers, count($response['body']['users']));
// Verify our test users are in the results by ID
$userIds = array_column($response['body']['users'], '$id');
$this->assertContains($data['userId'], $userIds);
$this->assertContains('user1', $userIds);
$response = $this->client->call(Client::METHOD_GET, '/users', array_merge([
'content-type' => 'application/json',
@@ -902,7 +904,7 @@ trait UsersBase
$this->assertEquals($response['headers']['status-code'], 200);
$this->assertNotEmpty($response['body']);
$this->assertIsArray($response['body']['users']);
$this->assertCount($totalUsers, $response['body']['users']);
$this->assertGreaterThanOrEqual($minUsers, count($response['body']['users']));
$response = $this->client->call(Client::METHOD_GET, '/users', array_merge([
'content-type' => 'application/json',
@@ -930,7 +932,9 @@ trait UsersBase
$this->assertEquals($response['headers']['status-code'], 200);
$this->assertNotEmpty($response['body']);
$this->assertNotEmpty($response['body']['users']);
$this->assertCount($totalUsers - 1, $response['body']['users']);
// CursorAfter should return results, count varies in parallel mode
$this->assertGreaterThanOrEqual(1, count($response['body']['users']));
// First result after cursor should be user1 (created right after setupUser)
$this->assertEquals($response['body']['users'][0]['$id'], 'user1');
$response = $this->client->call(Client::METHOD_GET, '/users', array_merge([