Fix deployment cancel race in build worker

This commit is contained in:
Chirag Aggarwal committed 2026-05-29 10:21:55 +05:30
1 parent 9b4585345f
commit 902b1d580e
1 file changed
+13 -3
@@ -246,14 +246,18 @@ class Builds extends Action
->setParam($resourceKey, $resource->getId())
->setParam('deploymentId', $deployment->getId());
$deploymentId = $deployment->getId();
$deployment = $dbForProject->getDocument('deployments', $deploymentId);
if ($deployment->isEmpty()) {
throw new \Exception('Deployment not found');
}
if ($deployment->getAttribute('status') === 'canceled') {
$this->cancelDeployment($deployment->getId(), $dbForProject, $queueForRealtime);
$this->cancelDeployment($deploymentId, $dbForProject, $queueForRealtime);
return;
}
$deploymentId = $deployment->getId();
$deployment->setAttribute('buildStartedAt', $startTime);
$deployment->setAttribute('status', 'processing');
$deployment = $dbForProject->updateDocument('deployments', $deployment->getId(), new Document([
@@ -534,6 +538,12 @@ class Builds extends Action
}
/** Request the executor to build the code... */
$deployment = $dbForProject->getDocument('deployments', $deploymentId);
if ($deployment->getAttribute('status') === 'canceled') {
$this->cancelDeployment($deploymentId, $dbForProject, $queueForRealtime);
return;
}
$deployment->setAttribute('status', 'building');
$deployment = $dbForProject->updateDocument('deployments', $deployment->getId(), new Document([
'status' => 'building',