fix: race condition with creating a user with targets

app/controllers/api/users.php

@@ -108,6 +108,8 @@ function createUser(string $hash, mixed $hashOptions, string $userId, ?string $e
             $hooks->trigger('passwordValidator', [$dbForProject, $project, $plaintextPassword, &$user, true]);
         }
 
+        $user = $dbForProject->createDocument('users', $user);
+
         if ($email) {
             try {
                 $target = $dbForProject->createDocument('targets', new Document([
@@ -143,8 +145,6 @@ function createUser(string $hash, mixed $hashOptions, string $userId, ?string $e
         }
 
         $dbForProject->deleteCachedDocument('users', $user->getId());
-
-        $user = $dbForProject->createDocument('users', $user);
     } catch (Duplicate $th) {
         throw new Exception(Exception::USER_ALREADY_EXISTS);
     }

phpunit.xml

@@ -6,7 +6,7 @@
          convertNoticesToExceptions="true"
          convertWarningsToExceptions="true"
          processIsolation="false"
-         stopOnFailure="false"
+         stopOnFailure="true"
 >
     <extensions>
         <extension class="Appwrite\Tests\TestHook" />

tests/e2e/Services/Messaging/MessagingBase.php

@@ -634,7 +634,7 @@ trait MessagingBase
         $this->assertEquals(201, $response['headers']['status-code'], "Error creating user: " . var_export($response['body'], true));
 
         $user = $response['body'];
-
+        var_dump($user);
         $this->assertEquals(1, \count($user['targets']));
         $targetId = $user['targets'][0]['$id'];