Appwrite/appwrite
1
0
Fork 0
mirror of https://github.com/appwrite/appwrite.git synced 2026-05-26 13:51:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid sharing mutable database adapters

Browse Source
This commit is contained in:
Chirag Aggarwal
2026-05-20 10:46:25 +05:30
parent fda5f1e025
commit 87cc1ea133
1 changed files with 2 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Appwrite/Database/DatabaseFactory.php
+2 -10
View File
@@ -16,11 +16,6 @@ use Utopia\System\System;
class DatabaseFactory
{
/**
* @var array<string, DatabasePool>
*/
protected array $adapters = [];
public function __construct(
protected Group $pools,
protected Cache $cache,
@@ -110,15 +105,12 @@ class DatabaseFactory
$projectDsn = $this->dsn($project->getAttribute('database'));
$databaseType = $databaseDocument->getAttribute('type', '');
$database = $this->newDatabase(new DatabasePool($this->pools->get($databaseDsn->getHost())));
$database = $this->newDatabase($this->adapter($databaseDsn->getHost()));
$database
->setDatabase($this->database)
->setAuthorization($this->authorization);
// This flag is adapter-level mutable state. Tenant databases can share the same
// pool name while requiring different attribute support (for example TablesDB
// versus DocumentsDB), so this adapter must not be reused from the factory cache.
$database->getAdapter()->setSupportForAttributes($databaseType !== DOCUMENTSDB);
if ($preserveDates) {
@@ -173,7 +165,7 @@ class DatabaseFactory
protected function adapter(string $name): DatabasePool
{
return $this->adapters[$name] ??= new DatabasePool($this->pools->get($name));
return new DatabasePool($this->pools->get($name));
}
protected function configureDocumentTypes(Database $database): Database