Appwrite/appwrite
1
0
Fork 0
mirror of https://github.com/appwrite/appwrite.git synced 2026-05-26 13:51:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: address sdk spec review feedback

Browse Source
This commit is contained in:
Chirag Aggarwal
2026-04-13 10:33:46 +05:30
parent 53c74582fc
commit 815209ebb0
2 changed files with 25 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Appwrite/SDK/Specification/Format.php
+1 -4
View File
@@ -800,7 +800,6 @@ abstract class Format
$config = [
'required' => !$optional,
'nullable' => $nullable,
'emitDefault' => $optional && !\is_null($default),
];
foreach (self::REQUEST_PARAMETER_OVERRIDES as $override) {
@@ -817,9 +816,7 @@ abstract class Format
break;
}
if ($config['required']) {
$config['emitDefault'] = false;
}
$config['emitDefault'] = !$config['required'] && !\is_null($default);
return $config;
}
tests/unit/SDK/Specification/FormatTest.php
+24 -17
View File
@@ -6,30 +6,33 @@ use Appwrite\SDK\Specification\Format;
use PHPUnit\Framework\TestCase;
use Utopia\DI\Container;
class TestFormat extends Format
{
public function getName(): string
{
return 'test';
}
public function parse(): array
{
return [];
}
public function requestParameterConfig(string $service, string $method, string $param, bool $optional, bool $nullable, mixed $default): array
{
return $this->getRequestParameterConfig($service, $method, $param, $optional, $nullable, $default);
}
}
class FormatTest extends TestCase
{
private Format $format;
private TestFormat $format;
protected function setUp(): void
{
parent::setUp();
$this->format = new class (new Container(), [], [], [], [], 0, 'console') extends Format {
public function getName(): string
{
return 'test';
}
public function parse(): array
{
return [];
}
public function requestParameterConfig(string $service, string $method, string $param, bool $optional, bool $nullable, mixed $default): array
{
return $this->getRequestParameterConfig($service, $method, $param, $optional, $nullable, $default);
}
};
$this->format = new TestFormat(new Container(), [], [], [], [], 0, 'console');
}
public function testProjectRequestParameterOverrides(): void
@@ -53,6 +56,10 @@ class FormatTest extends TestCase
{
$this->assertSame('PlatformType', $this->format->getResponseEnumName('platformAndroid', 'type'));
$this->assertSame('PlatformType', $this->format->getResponseEnumName('platformWeb', 'type'));
$this->assertSame('PlatformType', $this->format->getResponseEnumName('platformApple', 'type'));
$this->assertSame('PlatformType', $this->format->getResponseEnumName('platformWindows', 'type'));
$this->assertSame('PlatformType', $this->format->getResponseEnumName('platformLinux', 'type'));
$this->assertNull($this->format->getResponseEnumName('platformList', 'type'));
}
public function testExistingResponseEnumMappingsRemainUnchanged(): void