update: roles check.

2026-05-26 13:51:13 +00:00 · 2025-04-05 19:42:20 +05:30
parent 2a672f5a63
commit 7297188c1b
1 changed files with 3 additions and 3 deletions
@@ -1077,9 +1077,9 @@ App::patch('/v1/teams/:teamId/memberships/:membershipId')
                max: 2
            );

-            // If there's only one owner,
-            // and the requester is that owner, prevent role change
-            if ($ownersCount === 1 && $isOwner) {
+            // Prevent role change if there's only one owner left,
+            // the requester is that owner, and the new `$roles` no longer include 'owner'!
+            if ($ownersCount === 1 && $isOwner && !\in_array('owner', $roles)) {
                throw new Exception(Exception::GENERAL_ARGUMENT_INVALID, 'There must be at least one owner in the organization.');
            }
        }