Appwrite/appwrite
1
0
Fork 0
mirror of https://github.com/appwrite/appwrite.git synced 2026-05-26 13:51:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: review comment

Browse Source
This commit is contained in:
Mustaque Ahmed
2025-10-14 15:54:59 +05:30
parent 2bf0529f85
commit 528866b8b6
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/controllers/shared/api.php
+4 -4
View File
@@ -572,10 +572,10 @@ App::init()
$parts = explode('/', $cacheLog->getAttribute('resourceType', ''));
$type = $parts[0] ?? null;
// Initialize variables for use in response send logic
$isPrivilegedUser = Auth::isPrivilegedUser(Authorization::getRoles());
$isTransformationsBlocked = false;
if ($type === 'bucket') {
// Check privileged status early to avoid unnecessary DB requests
$isPrivilegedUser = Auth::isPrivilegedUser(Authorization::getRoles());
$bucketId = $parts[1] ?? null;
$bucket = Authorization::skip(fn () => $dbForProject->getDocument('buckets', $bucketId));
@@ -637,7 +637,7 @@ App::init()
->addHeader('X-Appwrite-Cache', 'hit')
->setContentType($cacheLog->getAttribute('mimeType'));
// Determine if user can bypass transformation blocks
$canBypassBlock = ($type === 'bucket') && ($isPrivilegedUser || $isToken);
$canBypassBlock = ($type === 'bucket') && $isPrivilegedUser;
if (!$isImageTransformation || !$isTransformationsBlocked || $canBypassBlock) {
$response->send($data);
}