Appwrite/appwrite
1
0
Fork 0
mirror of https://github.com/appwrite/appwrite.git synced 2026-05-26 13:51:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Torsten Dittmann <torsten.dittmann@googlemail.com>
This commit is contained in:
Damodar Lohani
2022-11-02 15:41:50 +05:45
committed by GitHub
parent 41d31c28d0
commit 4b5d537eee
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/controllers/shared/api.php
+1 -1
View File
@@ -77,7 +77,7 @@ $databaseListener = function (string $event, Document $document, Stats $usage) {
} elseif (strpos($collection, 'database_') === 0) {
$usage
->setParam('databaseId', $document->getAttribute('databaseId'));
if (strpos($collection, '_collection_') != false) {
if (strpos($collection, '_collection_') !== false) {
$usage
->setParam('collectionId', $document->getAttribute('$collectionId'))
->setParam('documents.{scope}.count.total', 1 * $multiplier);
src/Appwrite/Usage/Stats.php
+4 -4
View File
@@ -110,7 +110,7 @@ class Stats
foreach ($usersMetrics as $metric) {
$value = $this->params[$metric] ?? 0;
if ($value == 1 || $value == -1) {
if ($value === 1 || $value === -1) {
$this->statsd->count($metric . $tags, $value);
}
}
@@ -135,7 +135,7 @@ class Stats
foreach ($dbMetrics as $metric) {
$value = $this->params[$metric] ?? 0;
if ($value == 1 || $value == -1) {
if ($value === 1 || $value === -1) {
$dbTags = $tags . ",collectionId=" . ($this->params['collectionId'] ?? '') . ",databaseId=" . ($this->params['databaseId'] ?? '');
$this->statsd->count($metric . $dbTags, $value);
}
@@ -157,7 +157,7 @@ class Stats
foreach ($storageMertics as $metric) {
$value = $this->params[$metric] ?? 0;
if ($value >= 1 || $value == -1 || $value < -1) {
if ($value !== 0) {
$storageTags = $tags . ",bucketId=" . ($this->params['bucketId'] ?? '');
$this->statsd->count($metric . $storageTags, $value);
}
@@ -194,7 +194,7 @@ class Stats
$this->statsd->count('project.{scope}.storage.size' . $tags, $deploymentSize + $storageSize);
}
if ($deploymentSize > 0 || $deploymentSize <= -1) {
if ($deploymentSize !== 0) {
$this->statsd->count('deployments.{scope}.storage.size' . $functionTags, $deploymentSize);
}