Appwrite/appwrite
1
0
Fork 0
mirror of https://github.com/appwrite/appwrite.git synced 2026-05-26 13:51:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

(perf): skip subquery filters when loading report for ownership-only check

Browse Source
This commit is contained in:
Jake Barnby
2026-05-12 22:09:50 +12:00
parent 63df500b6f
commit 45f3a64617
2 changed files with 13 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Appwrite/Platform/Modules/Advisor/Http/Insights/Get.php
+8 -27
View File
@@ -59,45 +59,26 @@ class Get extends Action
Document $project,
Database $dbForPlatform
) {
$report = $dbForPlatform->getDocument('reports', $reportId);
// Skip the insights/CTA subqueries — we only need ownership metadata.
$report = $dbForPlatform->skipFilters(
fn () => $dbForPlatform->getDocument('reports', $reportId),
['subQueryReportInsights'],
);
if ($report->isEmpty() || $report->getAttribute('projectInternalId') !== $project->getSequence()) {
throw new Exception(Exception::REPORT_NOT_FOUND);
}
$insight = $this->getInsightFromReport($report, $insightId, $dbForPlatform);
if ($insight === null) {
throw new Exception(Exception::INSIGHT_NOT_FOUND);
}
$response->dynamic($insight, Response::MODEL_INSIGHT);
}
/**
* Resolve a nested insight scoped to its parent report.
*
* Fast path: pull from the report's embedded subquery payload (capped at APP_LIMIT_SUBQUERY).
* Fall back to a direct lookup so insights past the cap remain reachable.
*/
private function getInsightFromReport(Document $report, string $insightId, Database $dbForPlatform): ?Document
{
$embedded = $report->find('$id', $insightId, 'insights');
if (!empty($embedded)) {
return $embedded instanceof Document ? $embedded : new Document($embedded);
}
$insight = $dbForPlatform->getDocument('insights', $insightId);
if (
$insight->isEmpty()
|| $insight->getAttribute('projectInternalId') !== $report->getAttribute('projectInternalId')
|| $insight->getAttribute('projectInternalId') !== $project->getSequence()
|| $insight->getAttribute('reportInternalId') !== $report->getSequence()
) {
return null;
throw new Exception(Exception::INSIGHT_NOT_FOUND);
}
return $insight;
$response->dynamic($insight, Response::MODEL_INSIGHT);
}
}
src/Appwrite/Platform/Modules/Advisor/Http/Insights/XList.php
+5 -1
View File
@@ -67,7 +67,11 @@ class XList extends Action
Document $project,
Database $dbForPlatform
) {
$report = $dbForPlatform->getDocument('reports', $reportId);
// Skip the insights subquery — we're about to fetch a filtered, paginated slice ourselves.
$report = $dbForPlatform->skipFilters(
fn () => $dbForPlatform->getDocument('reports', $reportId),
['subQueryReportInsights'],
);
if ($report->isEmpty() || $report->getAttribute('projectInternalId') !== $project->getSequence()) {
throw new Exception(Exception::REPORT_NOT_FOUND);