Appwrite/appwrite
1
0
Fork 0
mirror of https://github.com/appwrite/appwrite.git synced 2026-05-26 13:51:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: added space validation

Browse Source
This commit is contained in:
Harsh Mahajan
2025-07-25 19:37:37 +05:30
parent 9ff6020584
commit 3ecec8350d
2 changed files with 25 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Appwrite/Network/Validator/AppwriteNetworkDomain.php
+3
View File
@@ -19,6 +19,9 @@ class AppwriteNetworkDomain extends Validator
if (!is_string($value) || empty($value)) {
return true;
}
if (\preg_match('/\s/', $value)) {
return false;
}
if (\str_starts_with($value, '.')) {
return false;
}
tests/unit/Network/Validators/AppwriteNetworkDomainTest.php
+22 -14
View File
@@ -77,22 +77,30 @@ class AppwriteNetworkDomainTest extends TestCase
$this->assertEquals(true, $this->validator->isValid('foo.bar.baz.example.com'));
}
public function testEdgeCases(): void
{
// Empty and invalid values should pass (let other validators handle them)
$this->assertEquals(true, $this->validator->isValid(''));
$this->assertEquals(true, $this->validator->isValid(null));
$this->assertEquals(true, $this->validator->isValid(false));
$this->assertEquals(true, $this->validator->isValid(123));
$this->assertEquals(true, $this->validator->isValid([]));
public function testEdgeCases(): void
{
// Empty and invalid values should pass (let other validators handle them)
$this->assertEquals(true, $this->validator->isValid(''));
$this->assertEquals(true, $this->validator->isValid(null));
$this->assertEquals(true, $this->validator->isValid(false));
$this->assertEquals(true, $this->validator->isValid(123));
$this->assertEquals(true, $this->validator->isValid([]));
// Just the root domain (unlikely but should be valid)
$this->assertEquals(true, $this->validator->isValid('appwrite.network'));
// Just the root domain (unlikely but should be valid)
$this->assertEquals(true, $this->validator->isValid('appwrite.network'));
// Domain with trailing/leading dots
$this->assertEquals(false, $this->validator->isValid('api.test.appwrite.network.'));
$this->assertEquals(false, $this->validator->isValid('.api.test.appwrite.network'));
}
// Domain with trailing/leading dots
$this->assertEquals(false, $this->validator->isValid('api.test.appwrite.network.'));
$this->assertEquals(false, $this->validator->isValid('.api.test.appwrite.network'));
// Domains with spaces should be invalid
$this->assertEquals(false, $this->validator->isValid('my app.appwrite.network'));
$this->assertEquals(false, $this->validator->isValid('api .appwrite.network'));
$this->assertEquals(false, $this->validator->isValid(' api.appwrite.network'));
$this->assertEquals(false, $this->validator->isValid('api.appwrite.network '));
$this->assertEquals(false, $this->validator->isValid('api.app write.network'));
$this->assertEquals(false, $this->validator->isValid("api\tapp.appwrite.network"));
}
public function testValidatorProperties(): void
{