revert: roll back VCS webhook signature ternary

Empty secret is the intended opt-out for self-hosted deployments.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Jake BarnbyandClaude Opus 4.7 committed 2026-05-28 22:41:33 +12:00
1 parent 7903808ed5
commit 301fe9b560
1 file changed
+1 -1
@@ -65,7 +65,7 @@ class Create extends Action
$signature = $request->getHeader('x-hub-signature-256', '');
$secretKey = System::getEnv('_APP_VCS_GITHUB_WEBHOOK_SECRET', '');
$valid = !empty($secretKey) && $github->validateWebhookEvent($payload, $signature, $secretKey);
$valid = empty($secretKey) ? true : $github->validateWebhookEvent($payload, $signature, $secretKey);
Span::add('vcs.github.event.signature.valid', $valid);
if (!$valid) {