Resolve PR comments

This commit is contained in:
Khushboo Verma
2024-10-27 15:51:17 +01:00
parent 81e3709d25
commit 2dead545f0
2 changed files with 4 additions and 6 deletions
@@ -482,14 +482,12 @@ class Builds extends Action
$cpus = match ($collection) {
'functions' => $spec['cpus'] ?? APP_FUNCTION_CPUS_DEFAULT,
'sites' => $siteVars['cpus'] ?? APP_SITE_CPUS_DEFAULT,
default => APP_FUNCTION_CPUS_DEFAULT,
'sites' => $siteVars['cpus'] ?? APP_SITE_CPUS_DEFAULT
};
$memory = match ($collection) {
'functions' => max($spec['memory'] ?? APP_FUNCTION_MEMORY_DEFAULT, 1024),
'sites' => max($siteVars['memory'] ?? APP_SITE_MEMORY_DEFAULT, 1024),
default => max(APP_FUNCTION_MEMORY_DEFAULT, 1024), // We have a minimum of 1024MB here because some runtimes can't compile with less memory than this.
'functions' => max($spec['memory'] ?? APP_FUNCTION_MEMORY_DEFAULT, 1024), // We have a minimum of 1024MB here because some runtimes can't compile with less memory than this.
'sites' => max($siteVars['memory'] ?? APP_SITE_MEMORY_DEFAULT, 1024)
};
$timeout = match ($collection) {
@@ -31,7 +31,7 @@ class ListSites extends Base
->setHttpPath('/v1/sites')
->desc('List sites')
->groups(['api', 'sites'])
->label('scope', 'sites.write')
->label('scope', 'sites.read')
->label('sdk.auth', [APP_AUTH_TYPE_KEY])
->label('sdk.namespace', 'sites')
->label('sdk.method', 'list')