Stabilize storage preview cache hit test (#12907)

This commit is contained in:
Jake Barnby authored and GitHub committed 2026-07-20 21:55:09 +12:00
1 parent cd94eba9ba
commit 1550af285b
1 file changed
+12 -9
+12 -9
View File
@@ -1065,7 +1065,8 @@ trait StorageBase
$this->assertNotEmpty($preview['body']);
$cachedPreview = [];
$this->assertEventually(function () use (&$cachedPreview, $bucketId, $fileId, $headers, $params) {
$cachedPreviewAgain = [];
$this->assertEventually(function () use (&$cachedPreview, &$cachedPreviewAgain, $bucketId, $fileId, $headers, $params) {
$cachedPreview = $this->client->call(
Client::METHOD_GET,
'/storage/buckets/' . $bucketId . '/files/' . $fileId . '/preview',
@@ -1073,7 +1074,16 @@ trait StorageBase
$params
);
$this->assertEquals('hit', $cachedPreview['headers']['x-appwrite-cache']);
$cachedPreviewAgain = $this->client->call(
Client::METHOD_GET,
'/storage/buckets/' . $bucketId . '/files/' . $fileId . '/preview',
$headers,
$params
);
$this->assertSame('hit', $cachedPreview['headers']['x-appwrite-cache']);
$this->assertSame('hit', $cachedPreviewAgain['headers']['x-appwrite-cache']);
$this->assertSame($cachedPreview['body'], $cachedPreviewAgain['body']);
});
$this->assertEquals(200, $cachedPreview['headers']['status-code']);
@@ -1081,13 +1091,6 @@ trait StorageBase
$this->assertStringStartsWith('private, max-age=', $cachedPreview['headers']['cache-control']);
$this->assertNotEmpty($cachedPreview['body']);
$cachedPreviewAgain = $this->client->call(
Client::METHOD_GET,
'/storage/buckets/' . $bucketId . '/files/' . $fileId . '/preview',
$headers,
$params
);
$this->assertEquals(200, $cachedPreviewAgain['headers']['status-code']);
$this->assertEquals('image/png', $cachedPreviewAgain['headers']['content-type']);
$this->assertStringStartsWith('private, max-age=', $cachedPreviewAgain['headers']['cache-control']);