Appwrite/appwrite
1
0
Fork 0
mirror of https://github.com/appwrite/appwrite.git synced 2026-05-26 13:51:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: flutter env limits!

Browse Source
This commit is contained in:
Darshan
2025-05-19 19:09:55 +05:30
parent 0ec7ff2cee
commit 0ca9438372
2 changed files with 34 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/config/templates/site.php
+1 -1
View File
@@ -478,7 +478,7 @@ return [
'frameworks' => [
getFramework('FLUTTER', [
'providerRootDirectory' => './',
'buildCommand' => 'bash build.sh',
'buildCommand' => 'flutter build web',
]),
],
'vcsProvider' => 'github',
src/Appwrite/Platform/Modules/Functions/Workers/Builds.php
+33 -5
View File
@@ -355,7 +355,7 @@ class Builds extends Action
->trigger();
}
} elseif ($isVcsEnabled) {
// VCS and VCS+Temaplte
// VCS and VCS+Template
$tmpDirectory = '/tmp/builds/' . $deploymentId . '/code';
$rootDirectory = $resource->getAttribute('providerRootDirectory', '');
$rootDirectory = \rtrim($rootDirectory, '/');
@@ -469,7 +469,7 @@ class Builds extends Action
$tmpPathFile = $tmpPath . '/code.tar.gz';
$localDevice = new Local();
if (substr($tmpDirectory, -1) !== '/') {
if (!str_ends_with($tmpDirectory, '/')) {
$tmpDirectory .= '/';
}
@@ -573,7 +573,6 @@ class Builds extends Action
$memory = max($spec['memory'] ?? APP_COMPUTE_MEMORY_DEFAULT, $minMemory);
$timeout = (int) System::getEnv('_APP_COMPUTE_BUILD_TIMEOUT', 900);
$jwtExpiry = (int)System::getEnv('_APP_COMPUTE_BUILD_TIMEOUT', 900);
$jwtObj = new JWT(System::getEnv('_APP_OPENSSL_KEY_V1'), 'HS256', $jwtExpiry, 0);
@@ -605,6 +604,8 @@ class Builds extends Action
'APPWRITE_VCS_ROOT_DIRECTORY' => $deployment->getAttribute('providerRootDirectory', ''),
]);
$flutterVarsForSite = [];
switch ($resource->getCollection()) {
case 'functions':
$vars = [
@@ -635,12 +636,15 @@ class Builds extends Action
'APPWRITE_SITE_CPUS' => $cpus,
'APPWRITE_SITE_MEMORY' => $memory,
];
$flutterVarsForSite = $vars;
break;
}
$command = $this->getCommand(
resource: $resource,
deployment: $deployment
deployment: $deployment,
flutterVars: $flutterVarsForSite,
);
$response = null;
@@ -1317,7 +1321,7 @@ class Builds extends Action
};
}
protected function getCommand(Document $resource, Document $deployment): string
protected function getCommand(Document $resource, Document $deployment, array $flutterVars = []): string
{
if ($resource->getCollection() === 'functions') {
return $deployment->getAttribute('buildCommands', '');
@@ -1340,6 +1344,30 @@ class Builds extends Action
$commands = array_filter($commands, fn ($command) => !empty($command));
/**
* Injects `--dart-define` flags into Flutter build commands.
*
* Since Flutter requires build-time vars via flags (not .env), we inject them
* here. The runtimes executor allows longer commands for Flutter to support this.
*/
if ($framework['key'] === 'flutter') {
foreach ($commands as $i => $cmd) {
if (str_contains($cmd, 'flutter build web')) {
$envs = '';
foreach ($flutterVars as $key => $value) {
$envs .= ' --dart-define=' . $key . '=' . escapeshellarg($value);
}
$commands[$i] = str_replace(
'flutter build web',
'flutter build web' . $envs,
$cmd
);
break;
}
}
}
return implode(' && ', $commands);
}