Appwrite/appwrite
1
0
Fork 0
mirror of https://github.com/appwrite/appwrite.git synced 2026-05-26 13:51:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve extensibility of DNS validation

Browse Source
This commit is contained in:
Matej Bačo
2025-09-17 13:15:50 +02:00
parent 00fb346b7a
commit 0af3338cab
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Appwrite/Platform/Modules/Proxy/Action.php
+11 -4
View File
@@ -14,6 +14,11 @@ use Utopia\Validator\IP;
class Action extends PlatformAction
{
protected function getDNSValidator(): string
{
return DNS::class;
}
/**
* Verify or re-verify a rule
*
@@ -25,6 +30,8 @@ class Action extends PlatformAction
*/
public static function verifyRule(Document $rule, ?Log $log = null, ?string $verificationDomainAPI = null, ?string $verificationDomainFunction = null): void
{
$dnsValidatorClass = $this->getDNSValidator();
$domain = new Domain($rule->getAttribute('domain', ''));
if (empty($domain->get())) {
@@ -38,7 +45,7 @@ class Action extends PlatformAction
// Ensure CAA won't block certificate issuance
if (!empty(System::getEnv('_APP_DOMAIN_TARGET_CAA', ''))) {
$validationStart = \microtime(true);
$validator = new DNS(System::getEnv('_APP_DOMAIN_TARGET_CAA', ''), DNS::RECORD_CAA);
$validator = new $dnsValidatorClass(System::getEnv('_APP_DOMAIN_TARGET_CAA', ''), DNS::RECORD_CAA);
if (!$validator->isValid($domain->get())) {
if (!\is_null($log)) {
$log->addExtra('dnsTimingCaa', \strval(\microtime(true) - $validationStart));
@@ -84,7 +91,7 @@ class Action extends PlatformAction
$mainValidator = null; // Validator to use for error description
if (!is_null($targetCNAME)) {
$validator = new DNS($targetCNAME->get(), DNS::RECORD_CNAME);
$validator = new $dnsValidatorClass($targetCNAME->get(), DNS::RECORD_CNAME);
$validators[] = $validator;
if (\is_null($mainValidator)) {
@@ -93,7 +100,7 @@ class Action extends PlatformAction
}
if ((new IP(IP::V4))->isValid(System::getEnv('_APP_DOMAIN_TARGET_A', ''))) {
$validator = new DNS(System::getEnv('_APP_DOMAIN_TARGET_A', ''), DNS::RECORD_A);
$validator = new $dnsValidatorClass(System::getEnv('_APP_DOMAIN_TARGET_A', ''), DNS::RECORD_A);
$validators[] = $validator;
if (\is_null($mainValidator)) {
@@ -102,7 +109,7 @@ class Action extends PlatformAction
}
if ((new IP(IP::V6))->isValid(System::getEnv('_APP_DOMAIN_TARGET_AAAA', ''))) {
$validator = new DNS(System::getEnv('_APP_DOMAIN_TARGET_AAAA', ''), DNS::RECORD_AAAA);
$validator = new $dnsValidatorClass(System::getEnv('_APP_DOMAIN_TARGET_AAAA', ''), DNS::RECORD_AAAA);
$validators[] = $validator;
if (\is_null($mainValidator)) {