Appwrite/appwrite
1
0
Fork 0
mirror of https://github.com/appwrite/appwrite.git synced 2026-05-26 13:51:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apex domain exception + proxy tests

Browse Source
This commit is contained in:
Matej Bačo
2025-02-22 18:26:51 +01:00
parent 7e3b693216
commit 0a25463b8d
4 changed files with 112 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/tests.yml
+2
View File
@@ -146,6 +146,7 @@ jobs:
Projects,
Realtime,
Sites,
Proxy,
Storage,
Teams,
Users,
@@ -212,6 +213,7 @@ jobs:
Projects,
Realtime,
Sites,
Proxy,
Storage,
Teams,
Users,
src/Appwrite/Platform/Modules/Proxy/Http/Rules/Create.php
+8
View File
@@ -10,6 +10,7 @@ use Appwrite\SDK\AuthType;
use Appwrite\SDK\Method;
use Appwrite\SDK\Response as SDKResponse;
use Appwrite\Utopia\Response;
use Utopia\App;
use Utopia\Database\Database;
use Utopia\Database\Document;
use Utopia\Database\Helpers\ID;
@@ -124,6 +125,13 @@ class Create extends Action
throw new Exception(Exception::GENERAL_ARGUMENT_INVALID, 'Domain may not start with http:// or https://.');
}
// Apex domain prevention due to CNAME limitations
if (empty(App::getEnv('_APP_DOMAINS_NAMESERVERS', ''))) {
if ($domain->get() === $domain->getRegisterable()) {
throw new Exception(Exception::GENERAL_ARGUMENT_INVALID, 'The instance does not allow root-level (apex) domains.');
}
}
// TODO: @christyjacob remove once we migrate the rules in 1.7.x
$ruleId = System::getEnv('_APP_RULES_FORMAT') === 'md5' ? md5($domain->get()) : ID::unique();
tests/e2e/Services/Proxy/ProxyBase.php
+46
View File
@@ -0,0 +1,46 @@
<?php
namespace Tests\E2E\Services\Proxy;
use Appwrite\Tests\Async;
use Tests\E2E\Client;
trait ProxyBase
{
use Async;
protected function createRule(mixed $params): mixed
{
$rule = $this->client->call(Client::METHOD_POST, '/proxy/rules', array_merge([
'content-type' => 'application/json',
'x-appwrite-project' => $this->getProject()['$id'],
], $this->getHeaders()), $params);
return $rule;
}
protected function deleteRule(string $ruleId): mixed
{
$rule = $this->client->call(Client::METHOD_DELETE, '/proxy/rules/' . $ruleId, array_merge([
'content-type' => 'application/json',
'x-appwrite-project' => $this->getProject()['$id'],
], $this->getHeaders()), []);
return $rule;
}
protected function setupRule(mixed $params): string
{
$rule = $this->createRule($params);
$this->assertEquals(201, $rule['headers']['status-code'], 'Failed to setup rule: ' . \json_encode($rule));
return $rule['body']['$id'];
}
protected function cleanupRule(string $ruleId): void
{
$rule = $this->deleteRule($ruleId);
$this->assertEquals(204, $rule['headers']['status-code'], 'Failed to cleanup rule: ' . \json_encode($rule));
}
}
tests/e2e/Services/Proxy/ProxyCustomServerTest.php
+56
View File
@@ -0,0 +1,56 @@
<?php
namespace Tests\E2E\Services\Proxy;
use Tests\E2E\Scopes\ProjectCustom;
use Tests\E2E\Scopes\Scope;
use Tests\E2E\Scopes\SideServer;
class ProxyCustomServerTest extends Scope
{
use ProxyBase;
use ProjectCustom;
use SideServer;
public function testCreateRule(): void
{
$rule = $this->createRule([
'domain' => 'api.myapp.com',
'resourceType' => 'api'
]);
$this->assertEquals(201, $rule['headers']['status-code']);
$this->assertEquals('api.myapp.com', $rule['body']['domain']);
$this->assertArrayHasKey('$id', $rule['body']);
$this->assertArrayHasKey('resourceType', $rule['body']);
$this->assertArrayHasKey('resourceId', $rule['body']);
$this->assertArrayHasKey('status', $rule['body']);
$this->assertArrayHasKey('logs', $rule['body']);
$this->assertArrayHasKey('renewAt', $rule['body']);
$ruleId = $rule['body']['$id'];
$rule = $this->deleteRule($ruleId);
$this->assertEquals(204, $rule['headers']['status-code']);
}
public function testCreateRuleSetup(): void
{
$ruleId = $this->setupRule([
'domain' => 'api2.myapp.com',
'resourceType' => 'api'
]);
$this->cleanupRule($ruleId);
}
public function testCreateRuleApex(): void
{
$rule = $this->createRule([
'domain' => 'myapp.com',
'resourceType' => 'api'
]);
$this->assertEquals(400, $rule['headers']['status-code']);
}
}