async-http-client

mirror of https://github.com/swift-server/async-http-client.git synced 2026-06-02 07:37:34 +00:00

Files

T

Ilya Teterin e401a2801c Fixes #234 by removing setter on internal ConnectionsState so modification (#311 )

allowed only using exposed API.

Motivation:

Having a setter for internal state of ConnectionsState led to a subset
of test testing invalid invariants, for example when we have at the same
time an available connecion and a waiter, which is an invalid state of
the system.

Modifications:

* test of ConnectionsState
* ConnectionsState
* ConnectionPool

are modified so the state under tests is achieved only by a sequence of
modifications invoked by state API.

During modification some tests are eliminated as they were testing
artificial state, which can not be achieved by exposed APIs.

ConnectionsState is pruned from "replace" as in no valid state we can
have a situation when we can "replace" a connection.

Invalid invariants and tests are removed.

Result:

We do not have a way to modify state of the ConnectionsState by direct
interaction with private state of the object. Getter on the state is
considered harmless and used for tests only.

2020-10-02 14:31:25 +01:00

NIOTransportServices

Support NIO Transport Services - part 2 (#184 )

2020-04-18 14:17:46 +01:00

Connection.swift

Code clean up to to fix issue #234 - ConnectionsState exposes a setter into internal state (#310 )

2020-09-30 17:03:52 +01:00

ConnectionPool.swift

Fixes #234 by removing setter on internal ConnectionsState so modification (#311 )

2020-10-02 14:31:25 +01:00

ConnectionsState.swift

Fixes #234 by removing setter on internal ConnectionsState so modification (#311 )