Cory Benfield 062989efd8 Correctly reset our state after .sendEnd (#597) ...

Motivation

In some cases, the last thing that happens in a request-response pair is
that we send our HTTP/1.1 .end. This can happen when the peer has sent
an early response, before we have finished uploading our body. When it
does, we need to be diligent about cleaning up our connection state.

Unfortunately, there was an edge in the HTTP1ConnectionStateMachine that
processed .succeedRequest but that did not transition the state into
either .idle or .closing. That was an error, and needed to be fixed.

Modifications

Transition to .idle when we're returning
.succeedRequest(.sendRequestEnd).

Result

Fewer crashes

2022-06-17 11:52:29 +01:00

..

Mocks

Call didSendRequestPart after the write has hit the socket (#566)

2022-04-26 16:04:54 +02:00

AsyncAwaitEndToEndTests.swift

Add async shutdown method to HTTPClient (#551)

2022-02-07 11:36:53 +01:00

AsyncAwaitEndToEndTests+XCTest.swift

Add async shutdown method to HTTPClient (#551)

2022-02-07 11:36:53 +01:00

AsyncTestHelpers.swift

Make async/await available on older Apple Platforms (#527)

2021-12-17 16:08:24 +01:00

EmbeddedChannel+HTTPConvenience.swift

Use explicit NIO imports (#407)

2021-08-19 21:11:49 +02:00

HTTP1ClientChannelHandlerTests.swift

[HTTP1] Tolerate immediate write errors (#579)

2022-04-11 16:41:10 +02:00

HTTP1ClientChannelHandlerTests+XCTest.swift

[HTTP1] Tolerate immediate write errors (#579)

2022-04-11 16:41:10 +02:00

HTTP1ConnectionStateMachineTests.swift

Call didSendRequestPart after the write has hit the socket (#566)

2022-04-26 16:04:54 +02:00

HTTP1ConnectionStateMachineTests+XCTest.swift

Fix race between connection close and scheduling new request (#546)

2022-01-24 12:07:41 +00:00

HTTP1ConnectionTests.swift

Fix flaky test: testConnectionClosesAfterTheRequestWithoutHavingSentAnCloseHeader (#520)

2021-12-06 18:31:32 +01:00

HTTP1ConnectionTests+XCTest.swift

Support informational response heads (#469)

2021-11-10 13:33:38 +01:00

HTTP1ProxyConnectHandlerTests.swift

Use explicit NIO imports (#407)

2021-08-19 21:11:49 +02:00

HTTP1ProxyConnectHandlerTests+XCTest.swift

Refactor Channel creation (#377)

2021-06-28 13:17:33 +02:00

HTTP2ClientRequestHandlerTests.swift

Crash fix: HTTPClientRequestHandler can deal with failing writes (#558)

2022-02-22 13:59:54 +01:00

HTTP2ClientRequestHandlerTests+XCTest.swift

Crash fix: HTTPClientRequestHandler can deal with failing writes (#558)

2022-02-22 13:59:54 +01:00

HTTP2ClientTests.swift

Crash fix: HTTP2 can handle requests are cancelled (#555)

2022-02-10 10:42:27 +01:00

HTTP2ClientTests+XCTest.swift

Crash fix: HTTP2 can handle requests are cancelled (#555)

2022-02-10 10:42:27 +01:00

HTTP2ConnectionTests.swift

Improve errors and testing using NIOTS (#588)

2022-06-01 14:13:47 +01:00

HTTP2ConnectionTests+XCTest.swift

Add HTTP2Connection (#401)

2021-07-22 18:30:37 +02:00

HTTP2IdleHandlerTests.swift

[HTTP2] Tolerate GoAway and Settings frames after connection close (#578)

2022-04-11 16:24:57 +02:00

HTTP2IdleHandlerTests+XCTest.swift

[HTTP2] Tolerate GoAway and Settings frames after connection close (#578)

2022-04-11 16:24:57 +02:00

HTTPClient+SOCKSTests.swift

Improve errors and testing using NIOTS (#588)

2022-06-01 14:13:47 +01:00

HTTPClient+SOCKSTests+XCTest.swift

Implement SOCKS proxy functionality (#375)

2021-06-18 13:02:58 +01:00

HTTPClientCookieTests.swift

Redo HTTP cookie parsing (#510)

2022-01-06 16:40:55 +00:00

HTTPClientCookieTests+XCTest.swift

Redo HTTP cookie parsing (#510)

2022-01-06 16:40:55 +00:00

HTTPClientInformationalResponsesTests.swift

Support informational response heads (#469)

2021-11-10 13:33:38 +01:00

HTTPClientInformationalResponsesTests+XCTest.swift

Support informational response heads (#469)

2021-11-10 13:33:38 +01:00

HTTPClientInternalTests.swift

Improve errors and testing using NIOTS (#588)

2022-06-01 14:13:47 +01:00

HTTPClientInternalTests+XCTest.swift

Redo HTTP cookie parsing (#510)

2022-01-06 16:40:55 +00:00

HTTPClientNIOTSTests.swift

Improve errors and testing using NIOTS (#588)

2022-06-01 14:13:47 +01:00

HTTPClientNIOTSTests+XCTest.swift

Improve errors and testing using NIOTS (#588)

2022-06-01 14:13:47 +01:00

HTTPClientRequestTests.swift

Prepare async/await API for public release (#531)

2022-01-14 14:35:17 +01:00

HTTPClientRequestTests+XCTest.swift

Test HTTPClientRequest (#513)

2021-12-06 10:53:42 +01:00

HTTPClientTests.swift

Correctly reset our state after .sendEnd (#597)

2022-06-17 11:52:29 +01:00

HTTPClientTests+XCTest.swift

Correctly reset our state after .sendEnd (#597)

2022-06-17 11:52:29 +01:00

HTTPClientTestUtils.swift

Correctly reset our state after .sendEnd (#597)

2022-06-17 11:52:29 +01:00

HTTPClientUncleanSSLConnectionShutdownTests.swift

Handle NIOSSLError.uncleanShutdown correctly (#472)

2021-11-11 11:02:54 +01:00

HTTPClientUncleanSSLConnectionShutdownTests+XCTest.swift

Handle NIOSSLError.uncleanShutdown correctly (#472)

2021-11-11 11:02:54 +01:00

HTTPConnectionPool+FactoryTests.swift

Improve errors and testing using NIOTS (#588)

2022-06-01 14:13:47 +01:00

HTTPConnectionPool+FactoryTests+XCTest.swift

Refactor Channel creation (#377)

2021-06-28 13:17:33 +02:00

HTTPConnectionPool+HTTP1ConnectionsTest.swift

Fix bug in migration from HTTP1 to HTTP2 and back to HTTP1 (#486)

2021-11-22 12:33:57 +01:00

HTTPConnectionPool+HTTP1ConnectionsTest+XCTest.swift

Fix bug in migration from HTTP1 to HTTP2 and back to HTTP1 (#486)

2021-11-22 12:33:57 +01:00

HTTPConnectionPool+HTTP1StateTests.swift

[HTTP2] Prepare migration actions (#456)

2021-10-13 17:11:04 +02:00

HTTPConnectionPool+HTTP1StateTests+XCTest.swift

HTTPConnectionPool timeout requests: preserve connection errors

2021-09-13 18:22:29 +02:00

HTTPConnectionPool+HTTP2ConnectionsTest.swift

Crash fix: HTTP2Connections emit events after the pool has closed them. (#481)

2021-11-19 12:33:08 +01:00

HTTPConnectionPool+HTTP2ConnectionsTest+XCTest.swift

Crash fix: HTTP2Connections emit events after the pool has closed them. (#481)

2021-11-19 12:33:08 +01:00

HTTPConnectionPool+HTTP2StateMachineTests.swift

Fix HTTP1 to HTTP2 migration while shutdown is in progress (#530)

2021-12-17 14:44:11 +01:00

HTTPConnectionPool+HTTP2StateMachineTests+XCTest.swift

Fix HTTP1 to HTTP2 migration while shutdown is in progress (#530)

2021-12-17 14:44:11 +01:00

HTTPConnectionPool+ManagerTests.swift

remove umbrella NIO imports and add soundness check (#446)

2021-09-29 17:42:42 +02:00

HTTPConnectionPool+ManagerTests+XCTest.swift

Add new HTTPConnectionPool Manager (#420)

2021-09-10 17:25:41 +02:00

HTTPConnectionPool+RequestQueueTests.swift

[HTTP1Connection] Option to ignore unclean ssl shutdown errors (#432)

2021-09-21 10:04:17 +02:00

HTTPConnectionPool+RequestQueueTests+XCTest.swift

Add a RequestQueue for the ConnectionPool (#412)

2021-09-01 13:55:06 +02:00

HTTPConnectionPool+StateTestUtils.swift

[HTTP2] Prepare migration actions (#456)

2021-10-13 17:11:04 +02:00

HTTPConnectionPoolTests.swift

Don't crash when hitting long backoffs. (#458)

2021-10-13 13:09:54 +01:00

HTTPConnectionPoolTests+XCTest.swift

Don't crash when hitting long backoffs. (#458)

2021-10-13 13:09:54 +01:00

HTTPRequestStateMachineTests.swift

Call didSendRequestPart after the write has hit the socket (#566)

2022-04-26 16:04:54 +02:00

HTTPRequestStateMachineTests+XCTest.swift

Call didSendRequestPart after the write has hit the socket (#566)

2022-04-26 16:04:54 +02:00

LRUCacheTests.swift

cache NIOSSLContext (saves 27k allocs per conn) (#362)

2021-05-13 12:16:52 +01:00

LRUCacheTests+XCTest.swift

cache NIOSSLContext (saves 27k allocs per conn) (#362)

2021-05-13 12:16:52 +01:00

RequestBagTests.swift

[Redirect] Allow redirect response to have body (#580)

2022-04-12 13:40:16 +02:00

RequestBagTests+XCTest.swift

[Redirect] Allow redirect response to have body (#580)

2022-04-12 13:40:16 +02:00

RequestValidationTests.swift

Prepare async/await API for public release (#531)

2022-01-14 14:35:17 +01:00

RequestValidationTests+XCTest.swift

Always overwrite Transport-Encoding and Content-Length headers (#479)

2021-11-23 10:22:57 +01:00

SOCKSEventsHandlerTests.swift

Use explicit NIO imports (#407)

2021-08-19 21:11:49 +02:00

SOCKSEventsHandlerTests+XCTest.swift

Refactor Channel creation (#377)

2021-06-28 13:17:33 +02:00

SOCKSTestUtils.swift

Fix flaky tests in HTTPClientSOCKSTests (#498)

2021-11-26 00:22:37 +01:00

SSLContextCacheTests.swift

Use explicit NIO imports (#407)

2021-08-19 21:11:49 +02:00

SSLContextCacheTests+XCTest.swift

SSLContextCache: use DispatchQueue instead of NIOThreadPool (#368)

2021-05-13 15:11:49 +01:00

TLSEventsHandlerTests.swift

Use explicit NIO imports (#407)

2021-08-19 21:11:49 +02:00

TLSEventsHandlerTests+XCTest.swift

Refactor Channel creation (#377)

2021-06-28 13:17:33 +02:00

Transaction+StateMachineTests.swift

Make async/await available on older Apple Platforms (#527)

2021-12-17 16:08:24 +01:00

Transaction+StateMachineTests+XCTest.swift

Respect deadline on new HTTPClient.execute for async/await (#529)

2021-12-17 09:36:41 +01:00

TransactionTests.swift

Fix flaky TransactionTests.testResponseStreamFails() test (#582)

2022-04-22 10:47:30 +02:00

TransactionTests+XCTest.swift

Add async Transaction (#518)

2021-12-09 18:04:01 +01:00

XCTest+AsyncAwait.swift

Make async/await available on older Apple Platforms (#527)

2021-12-17 16:08:24 +01:00