mirror of
https://github.com/swift-server/async-http-client.git
synced 2026-06-02 07:37:34 +00:00
Fix Connection Creation Crash (#873)
### Motivation When creating a connection, we wrongfully assumed that `failedToCreateNewConnection` will always be called before `http*ConnectionClosed` in the `HTTPConnectionPoolStateMachine`. However this is far from correct. In NIO Futures are fulfilled before `ChannelHandler` callbacks. Ordering in futures should not be assumed in such a complex project. ### Change We change the `http*ConnectionClosed` methods to be noops, if the connection is in the starting state. We instead wait for the `failedToCreateNewConnection` to create backoff timers and friends. rdar://164674912 --------- Co-authored-by: George Barnett <gbarnett@apple.com>
This commit is contained in:
co-authored by
George Barnett
parent
ce04df0613
commit
3c45dbde2d
+9
-10
@@ -226,20 +226,18 @@ extension HTTPConnectionPool {
|
||||
) -> EstablishedAction {
|
||||
self.failedConsecutiveConnectionAttempts = 0
|
||||
self.lastConnectFailure = nil
|
||||
if self.connections.hasActiveConnection(for: connection.eventLoop) {
|
||||
guard let (index, _) = self.connections.failConnection(connection.id) else {
|
||||
preconditionFailure("we have established a new connection that we know nothing about?")
|
||||
}
|
||||
self.connections.removeConnection(at: index)
|
||||
let doesConnectionExistsForEL = self.connections.hasActiveConnection(for: connection.eventLoop)
|
||||
let (index, context) = self.connections.newHTTP2ConnectionEstablished(
|
||||
connection,
|
||||
maxConcurrentStreams: maxConcurrentStreams
|
||||
)
|
||||
if doesConnectionExistsForEL {
|
||||
let connection = self.connections.closeConnection(at: index)
|
||||
return .init(
|
||||
request: .none,
|
||||
connection: .closeConnection(connection, isShutdown: .no)
|
||||
)
|
||||
} else {
|
||||
let (index, context) = self.connections.newHTTP2ConnectionEstablished(
|
||||
connection,
|
||||
maxConcurrentStreams: maxConcurrentStreams
|
||||
)
|
||||
return self.nextActionForAvailableConnection(at: index, context: context)
|
||||
}
|
||||
}
|
||||
@@ -424,6 +422,8 @@ extension HTTPConnectionPool {
|
||||
self.failedConsecutiveConnectionAttempts += 1
|
||||
self.lastConnectFailure = error
|
||||
|
||||
let eventLoop = self.connections.backoffNextConnectionAttempt(connectionID)
|
||||
|
||||
switch self.lifecycleState {
|
||||
case .running:
|
||||
guard self.retryConnectionEstablishment else {
|
||||
@@ -440,7 +440,6 @@ extension HTTPConnectionPool {
|
||||
)
|
||||
}
|
||||
|
||||
let eventLoop = self.connections.backoffNextConnectionAttempt(connectionID)
|
||||
let backoff = calculateBackoff(failedAttempt: self.failedConsecutiveConnectionAttempts)
|
||||
return .init(
|
||||
request: .none,
|
||||
|
||||
Reference in New Issue
Block a user