mirror of
https://github.com/rommapp/grout.git
synced 2026-04-23 06:54:36 +00:00
Brandon T. Kowalski
2d81086e9f
Prerelease segments like beta.6 vs beta.10 were compared as strings, causing beta.10 to appear older than beta.6. Split on '.' and compare numeric segments as integers per the semver spec.
146 lines
6.1 KiB
Go
146 lines
6.1 KiB
Go
package update
|
|
|
|
import (
|
|
"testing"
|
|
)
|
|
|
|
func TestParseVersion(t *testing.T) {
|
|
tests := []struct {
|
|
input string
|
|
expected Version
|
|
wantErr bool
|
|
}{
|
|
{"v1.2.3", Version{Major: 1, Minor: 2, Patch: 3, Build: 0, Prerelease: ""}, false},
|
|
{"1.2.3", Version{Major: 1, Minor: 2, Patch: 3, Build: 0, Prerelease: ""}, false},
|
|
{"v1.2.0-beta.1", Version{Major: 1, Minor: 2, Patch: 0, Build: 0, Prerelease: "beta.1"}, false},
|
|
{"1.2.0-beta.1", Version{Major: 1, Minor: 2, Patch: 0, Build: 0, Prerelease: "beta.1"}, false},
|
|
{"v1.0.0-alpha", Version{Major: 1, Minor: 0, Patch: 0, Build: 0, Prerelease: "alpha"}, false},
|
|
{"1.0", Version{Major: 1, Minor: 0, Patch: 0, Build: 0, Prerelease: ""}, false},
|
|
{"1", Version{Major: 1, Minor: 0, Patch: 0, Build: 0, Prerelease: ""}, false},
|
|
// 4-component versions
|
|
{"4.6.1.0", Version{Major: 4, Minor: 6, Patch: 1, Build: 0, Prerelease: ""}, false},
|
|
{"v4.6.1.0", Version{Major: 4, Minor: 6, Patch: 1, Build: 0, Prerelease: ""}, false},
|
|
{"4.6.1.1", Version{Major: 4, Minor: 6, Patch: 1, Build: 1, Prerelease: ""}, false},
|
|
{"4.6.0.0-beta.1", Version{Major: 4, Minor: 6, Patch: 0, Build: 0, Prerelease: "beta.1"}, false},
|
|
{"v4.6.0.0-beta.1", Version{Major: 4, Minor: 6, Patch: 0, Build: 0, Prerelease: "beta.1"}, false},
|
|
{"4.6.1.2-rc.1", Version{Major: 4, Minor: 6, Patch: 1, Build: 2, Prerelease: "rc.1"}, false},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.input, func(t *testing.T) {
|
|
got, err := ParseVersion(tt.input)
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("ParseVersion(%q) error = %v, wantErr %v", tt.input, err, tt.wantErr)
|
|
return
|
|
}
|
|
if !tt.wantErr {
|
|
if got.Major != tt.expected.Major || got.Minor != tt.expected.Minor || got.Patch != tt.expected.Patch || got.Prerelease != tt.expected.Prerelease {
|
|
t.Errorf("ParseVersion(%q) = %+v, want %+v", tt.input, got, tt.expected)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestCompareVersions(t *testing.T) {
|
|
tests := []struct {
|
|
current string
|
|
latest string
|
|
expected int // -1 if current < latest, 0 if equal, 1 if current > latest
|
|
desc string
|
|
}{
|
|
// Normal version comparisons
|
|
{"1.0.0", "1.0.1", -1, "patch version newer"},
|
|
{"1.0.1", "1.0.0", 1, "patch version older"},
|
|
{"1.0.0", "1.1.0", -1, "minor version newer"},
|
|
{"1.1.0", "1.0.0", 1, "minor version older"},
|
|
{"1.0.0", "2.0.0", -1, "major version newer"},
|
|
{"2.0.0", "1.0.0", 1, "major version older"},
|
|
{"1.0.0", "1.0.0", 0, "same version"},
|
|
|
|
// Beta vs full release
|
|
{"v1.2.0-beta.1", "v1.2.0", -1, "beta should recognize full release as newer"},
|
|
{"v1.2.0", "v1.2.0-beta.1", 1, "full release should be newer than beta"},
|
|
{"1.2.0-beta.1", "1.2.0", -1, "beta should recognize full release as newer (no v prefix)"},
|
|
{"1.2.0", "1.2.0-beta.1", 1, "full release should be newer than beta (no v prefix)"},
|
|
|
|
// Beta vs beta
|
|
{"v1.2.0-beta.1", "v1.2.0-beta.2", -1, "newer beta should be recognized"},
|
|
{"v1.2.0-beta.2", "v1.2.0-beta.1", 1, "older beta should be recognized"},
|
|
{"v1.2.0-beta.1", "v1.2.0-beta.1", 0, "same beta versions"},
|
|
|
|
// Different prerelease types
|
|
{"v1.2.0-alpha", "v1.2.0-beta.1", -1, "alpha < beta"},
|
|
{"v1.2.0-beta.1", "v1.2.0-alpha", 1, "beta > alpha"},
|
|
|
|
// Edge cases
|
|
{"v1.2.0-beta.1", "v1.2.1", -1, "beta should recognize higher patch as newer"},
|
|
{"v1.2.1", "v1.2.0-beta.1", 1, "higher patch should be newer than beta"},
|
|
{"v1.2.0-beta.1", "v1.3.0", -1, "beta should recognize higher minor as newer"},
|
|
{"v1.3.0", "v1.2.0-beta.1", 1, "higher minor should be newer than beta"},
|
|
|
|
// 4-component version comparisons
|
|
{"4.6.1.0", "4.6.1.1", -1, "build version newer"},
|
|
{"4.6.1.1", "4.6.1.0", 1, "build version older"},
|
|
{"4.6.1.0", "4.6.1.0", 0, "same 4-component version"},
|
|
{"4.6.1.5", "4.6.2.0", -1, "higher patch beats higher build"},
|
|
{"4.6.2.0", "4.6.1.5", 1, "higher patch beats higher build (reverse)"},
|
|
|
|
// 4-component with prerelease
|
|
{"4.6.0.0-beta.1", "4.6.0.0", -1, "4-component beta vs full release"},
|
|
{"4.6.0.0", "4.6.0.0-beta.1", 1, "4-component full release vs beta"},
|
|
{"4.6.0.0-beta.1", "4.6.0.0-beta.2", -1, "4-component beta comparison"},
|
|
{"4.6.0.0-beta.1", "4.6.0.1", -1, "4-component beta vs higher build"},
|
|
{"4.6.0.1", "4.6.0.0-beta.1", 1, "4-component higher build vs beta"},
|
|
|
|
// Multi-digit prerelease numbers (must compare numerically, not lexicographically)
|
|
{"v4.8.0.0-beta.6", "v4.8.0.0-beta.10", -1, "beta.10 should be newer than beta.6"},
|
|
{"v4.8.0.0-beta.10", "v4.8.0.0-beta.6", 1, "beta.6 should be older than beta.10"},
|
|
{"v4.8.0.0-beta.10", "v4.8.0.0-beta.10", 0, "same multi-digit beta"},
|
|
{"v1.0.0-beta.9", "v1.0.0-beta.20", -1, "beta.20 newer than beta.9"},
|
|
|
|
// Mixed 3 and 4 component (3-component defaults build to 0)
|
|
{"1.2.3", "1.2.3.0", 0, "3-component equals 4-component with build 0"},
|
|
{"1.2.3", "1.2.3.1", -1, "3-component older than 4-component with build 1"},
|
|
{"1.2.3.1", "1.2.3", 1, "4-component with build 1 newer than 3-component"},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.desc, func(t *testing.T) {
|
|
got := CompareVersions(tt.current, tt.latest)
|
|
if got != tt.expected {
|
|
t.Errorf("CompareVersions(%q, %q) = %d, want %d", tt.current, tt.latest, got, tt.expected)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestIsNewerVersion(t *testing.T) {
|
|
tests := []struct {
|
|
current string
|
|
latest string
|
|
expected bool
|
|
desc string
|
|
}{
|
|
{"v1.2.0-beta.1", "v1.2.0", true, "beta should see full release as newer"},
|
|
{"v1.2.0", "v1.2.0-beta.1", false, "full release should not see beta as newer"},
|
|
{"v1.1.0", "v1.2.0", true, "older version should see newer as newer"},
|
|
{"v1.2.0", "v1.1.0", false, "newer version should not see older as newer"},
|
|
{"v1.2.0", "v1.2.0", false, "same version should not be newer"},
|
|
|
|
// 4-component versions
|
|
{"4.6.1.0", "4.6.1.1", true, "build 0 should see build 1 as newer"},
|
|
{"4.6.1.1", "4.6.1.0", false, "build 1 should not see build 0 as newer"},
|
|
{"4.6.0.0-beta.1", "4.6.0.0", true, "4-component beta should see full release as newer"},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.desc, func(t *testing.T) {
|
|
got := IsNewerVersion(tt.current, tt.latest)
|
|
if got != tt.expected {
|
|
t.Errorf("IsNewerVersion(%q, %q) = %v, want %v", tt.current, tt.latest, got, tt.expected)
|
|
}
|
|
})
|
|
}
|
|
}
|