17749524ec
Silence warnings emitted under -W2.
2017-01-11 22:37:52 +00:00
60e4027c59
Extract the parsing/unparsing code from Hybi into Ruby classes that match the C API, drop the Native driver and allow Hybi to take options for which parsers to use.
2017-01-06 09:11:37 +00:00
914dadb973
Port the frame serializer to C.
2017-01-05 21:38:26 +00:00
ede6490add
Refer to error messages as 'reasons' so as not to confuse them with WebSocket message structs.
2016-12-31 15:48:47 +00:00
cee5700a02
Catch errors with close frames with invalid UTF-8.
2016-12-29 02:10:51 +00:00
97b497a520
Drop the old native extension and replace it with the new all-C parser. Replace the old masking code with a Ruby version, so that the Hybi class is pure Ruby.
2016-12-29 01:09:12 +00:00
0eb64913ca
Capture errors raise by emit() and re-raise them after the parser has finished running.
2016-12-29 00:56:55 +00:00
524aa3f356
Add handling of close frames.
2016-12-29 00:34:36 +00:00
8eaae3a149
Implement hooks for ping/pong.
2016-12-28 18:04:27 +00:00
78c5aea489
Check for valid UTF-8 after the message has gone through extensions, e.g. a deflate-encoded payload will not be valid UTF-8.
2016-12-28 16:35:45 +00:00
721644495b
Implement the require_masking flag properly.
2016-12-28 16:14:52 +00:00
ae62fc6322
Begin emitting native parser errors back to the driver, starting by handling invalid opcodes.
2016-12-28 15:25:44 +00:00
4e747733a3
Begin wiring the C parser up to a Ruby driver. Driver::Native is currently a hollowed-out copy of Driver::Hybi with the parsing code removed.
2016-12-27 12:26:59 +00:00
9ce857b3d4
Revise uses of encoding APIs.
...
When originally implemented, we still supported Ruby 1.8, which
necessitated checking for encoding methods and using a regex to validate
UTF-8. These checks are now gone.
We tagged many strings as binary when not strictly necessary, either
because we were just going to iterate their bytes or because we were
going to hand them off to the caller which should just write them
directly to a socket. Strings used as buffers to accumulate streaming
input are still tagged as binary to avoid encoding
collision/conversion.
The places where we do need to tag as UTF-8 (i.e. just before emitting
to the application) remain, but copy the string if necessary. This
allows us to work with frozen strings.
Finally, strings passed in via the Driver#text method should be
*transcoded* to UTF-8 if necessary, not merely tagged. The Ruby
String#encode method produces a new string so this should also be safe
with frozen strings.
2016-05-19 21:08:22 +01:00
115d82bebb
Silence all -W2 warnings.
2016-05-18 22:42:16 +01:00
15ba7410c6
Remove some unused variables from Hybi#send_frame.
2016-05-18 22:33:33 +01:00
4ae198b1d3
Throw a more helpful error if a client driver is created with an invalid URL.
2015-10-17 21:37:13 +01:00
c63220194c
Close the connection if a draft-76 client sends a Sec-WebSocket-Key header where the numeric value is a non-integer multiple of the number of spaces.
2015-10-02 21:32:35 +01:00
5ce5c98339
"warning: instance variable @delegate not initialized"
2015-07-21 16:41:50 +09:00
bc7d29cb52
Emit a protocol error when a closing frame has a 1-byte payload.
2015-07-17 22:02:51 +01:00
59940290c9
Emit close code 1000 if the closing frame does not contain one.
2015-07-16 08:19:05 +01:00
be2e5ed9ce
A few stylistic tweaks.
2015-07-11 14:24:19 +01:00
d4245ed3f4
Rather than implementing integer (un)packing ourselves, use the Array#pack and String#unpack methods.
2015-07-10 20:05:19 +01:00
7128d1b030
Standardise the words used to refer to chunks of parser input.
2015-07-10 09:37:03 +01:00
75fe55eaba
Adjust how on() calls add_listener(). This is necessary because faye-websocket overrides add_listener with one argument, so users with faye-websocket locked at < 0.10 will see errors.
2015-07-10 09:22:16 +01:00
f1fd96e093
Emit an error event *after* setting the ready state to 3.
2015-07-08 20:13:50 +01:00
fed81a5a88
Small format changes to StreamReader.
2015-07-07 21:24:13 +01:00
91653036ce
Parse the mask flag and length in the order they appear in the protocol.
2015-07-07 20:49:29 +01:00
e39fa15c07
Revert variable names in Draft75#parse to what they were in 0.5.
2015-07-07 20:45:55 +01:00
50ca31b4c8
Remove empty Driver#shutdown method.
2015-07-07 20:40:53 +01:00
9523937428
Initialize StreamReader in the base constructor.
2015-07-07 20:38:26 +01:00
91df761990
Hybi#shutdown doesn't really need to take a block, it can just take a flag to say whether to emit an error.
2015-07-07 20:33:22 +01:00
dcfd35fde8
Remove some excessive whitespace.
2015-07-07 20:32:47 +01:00
582a3b0541
Merge pull request #29 from ioquatix/buffered-input
...
Use StreamReader for both hybi and draft75.
2015-07-06 20:49:24 +01:00
fe6163c336
Perform state changes in #shutdown before calling frame(), which might fail when calling @socket.write.
2015-07-06 20:50:18 +01:00
9b561b6e12
The 'rescue' clause for errors from outgoing extensions should be in #frame, not #send_frame.
2015-07-06 20:48:44 +01:00
425e15da83
Use StreamReader for both hybi and draft75.
2015-07-06 10:29:18 +09:00
fa11841bfa
Don't catch errors from event listeners. Instead, make sure that in all parsing methods in Hybi, @stage is set before any user called is invoked so the parser is in the right state before code that might raise is called.
2015-07-05 18:52:53 +01:00
f11d5905d2
Merge pull request #28 from ioquatix/strem-reader-refactoring
...
Improve performance of StreamReader by reducing the number of buffer reallocations done.
2015-07-05 16:26:32 +01:00
83d317add2
Rescue from Exception when calling event listeners, and use the name 'error' for caught exceptions.
2015-07-05 15:31:36 +01:00
46f5ac8c6b
Improve performance of StreamReader by reducing the number of buffer reallocations done.
2015-07-05 23:24:35 +09:00
585eded63d
Remove unnecessary code to remove whitespace from Base64 output.
2015-07-04 21:13:06 +01:00
8eccf044b0
Change stage in the Base.shutdown() method to that all parsers stop processing input.
2015-07-04 21:06:50 +01:00
f218999304
If an event listener emits an error, close the connection with code 1011.
2015-07-04 20:54:42 +01:00
d69cdaba97
Allow event listeners to be passed as normal rather than block arguments.
...
This discourages the inappropriate use of 'return' inside event
listeners. Also, we return the listener, so that the caller has a
reference to it in case they do pass a block.
2015-07-04 19:28:49 +01:00
7af53b5be0
Add a pong() command for sending unsolicited pong frames.
2015-07-04 18:49:46 +01:00
6720cb2b4a
The client should use secure random numbers for Sec-WebSocket-Key, and we should use the Base64.strict_encode function everywhere.
2015-06-02 22:01:22 +01:00
d6b147f2e0
Fail the connection when the server receives an invalid Sec-WebSocket-Extensions header.
2015-03-26 09:43:59 +00:00
b78ed7706d
Don't send a close frame in response to receiving one, if we already sent a close frame.
2015-03-14 10:03:26 +00:00
de23229e7f
Don't parse incoming data if the client is already closed. This stops the headers being interpreted as WebSocket data if the client is closed before receiving the server's handshake.
2015-02-21 12:36:32 +00:00
James Coglan
Akira Matsuda
Samuel Williams