Commit Graph
105 Commits
Author SHA1 Message Date
AndywinXp e949b1ed47 SCUMM: GUI: Restore previous _saveSound at the end of menu
Fixes the main part of ticket #14618.
Fix suggested by eriktorbjorn.
2023-09-14 15:17:54 +02:00
athrxx 0201155544 SCUMM: (MI2) - fix assert triggering when pressing F5
This happens on screeens with an xstart offset (= a screen
that is wider than 320 pixels, after some scrolling) but only
when there is dialogue text on screen when pressing F5.
Can be tested right at the start on the bridge. Just right-
click the sign, then press F5...
2023-08-19 22:19:41 +02:00
AndywinXp f484ad6545 SCUMM: SAMNMAX: Fix bug #14467
This was caused by the fact that the pre and post save screen scripts
were not being called, and this messed up the cursor state with savegames
created as quicksaves.

Also, renamed the variables containing said scripts numbers, so that
they are a little bit more meaningful now.
2023-05-21 21:17:36 +02:00
AndywinXp 9926908983 SCUMM: SAMNMAX: Fix bug #14468
I really have no idea why I wrote the code in such a way that
it attempted to load stuff that was never saved in the first place,
and I guess we'll never know. Findings by athrxx!
2023-05-21 20:16:14 +02:00
AndywinXp e28b3f09b1 SCUMM: GUI: Use correct heap message for some v6 games 2023-03-19 19:26:15 +01:00
AndywinXp e494b2527b SCUMM: DOTT: Fix quit prompt appearing when using the PC in Ed's room
This only affects the original GUI mode, and leaves the other mode as it has always been; also,
the issue only appeared when the global configuration parameter "confirm_exit" was set to true.
2023-01-28 10:14:42 +01:00
AndywinXp d9777bf512 SCUMM: GUI: Correctly save the shake screen flag 2023-01-23 16:14:45 +01:00
AndywinXp cc2b4de6ec SCUMM: DOTT/GUI: Fix cursor not reappearing when loading a savegame 2023-01-22 23:11:25 +01:00
AndywinXp e8dfcb42f6 SCUMM: GUI: Implement ScummVM quit confirmation override
Now, the original GUI will ask you for confirmation only if the "confirm_exit" config
flag is active.
2023-01-20 10:03:37 +01:00
AndywinXp 7c158b1005 SCUMM: GUI: Fix voice mode string id for foreign versions of FT 2023-01-08 23:26:27 +01:00
AndywinXp 6f4acceede SCUMM: GUI: Insert workaround for german LOOM FM-Towns
Fixes a part of bug #13980
2022-12-27 15:00:56 +01:00
Donovan Watteau 818194e8cf SCUMM: Fix build on older systems lacking strnlen 2022-12-24 09:32:45 +01:00
AndywinXp 4d6d76b60b SCUMM: GUI: Implement missing banners for v6 games 2022-12-20 22:38:26 +01:00
AndywinXp 76f4371f45 SCUMM: GUI: Handle numbers strings with const chars instead of String objects 2022-12-13 18:40:11 +01:00
AndywinXp 87625eb23e SCUMM: GUI: Use strnlen to measure current passcode length 2022-12-13 18:40:11 +01:00
AndywinXp f463d032d8 SCUMM: GUI: Improve readability 2022-12-13 18:40:11 +01:00
AndywinXp beb65bc902 SCUMM: GUI: Fix warnings 2022-12-13 18:40:11 +01:00
AndywinXp 19b45e2a50 SCUMM: GUI: Fix passcode not being updated on MI1 SegaCD
Big thanks to eientei (einstein95) for the research for this commit!
2022-12-13 18:40:11 +01:00
AndywinXp b1eaf2ea0f SCUMM: GUI: Implement MI1 SegaCD menu 2022-12-13 18:40:11 +01:00
AndywinXp 0f93142ac9 SCUMM: MI1 (Sega CD): Fix message banner colors 2022-11-28 23:21:45 +01:00
AndywinXp 918b7f95f1 SCUMM: v3: Fix minor graphical glitch on game quit 2022-11-28 23:21:45 +01:00
AndywinXp ab5010e04b SCUMM: GUI: Remove menu inner box on v5 FM-Towns games 2022-11-28 23:21:45 +01:00
AndywinXp e93f6d2b83 SCUMM: GUI: Fix v5 FM-Towns menu box title 2022-11-28 23:21:45 +01:00
AndywinXp 2c36f10932 SCUMM: GUI: Cleanup 2022-11-28 23:21:45 +01:00
AndywinXp a0613993d3 SCUMM: GUI: Substitute 0 with nullptr for pointer values 2022-11-28 23:21:45 +01:00
AndywinXp 9900bbd616 SCUMM: GUI: Implement original save/load menus for v5 FM-Towns games 2022-11-28 23:21:45 +01:00
AndywinXp f1a18f26e2 SCUMM: GUI: Fix regression on v4 games restart prompts 2022-11-28 23:21:45 +01:00
AndywinXp 3bc9064278 SCUMM: GUI: Make the restart prompt more consistent
Also make it work for v3 Towns games, which have their own mapping for the F keys
2022-11-28 23:21:45 +01:00
AndywinXp 3519891ca1 SCUMM: GUI: Fix regression on v3 Towns games 2022-11-28 23:21:45 +01:00
AndywinXp 89009fedcd SCUMM: GUI: Fix graphical glitches and random distaff disappearances on LOOM v3 2022-11-28 23:21:45 +01:00
AndywinXp a0baee6e6f SCUMM: GUI: Fix remaining v3 FM-Towns banner-related glitches 2022-11-28 23:21:45 +01:00
AndywinXp 0944412c0e SCUMM: GUI: Fix graphical glitches in LOOM Towns 2022-11-28 23:21:45 +01:00
AndywinXp a3a7d4a131 SCUMM: GUI: Fix banner and text position on v3 FM-Towns games 2022-11-28 23:21:45 +01:00
AndywinXp ca3d80e281 SCUMM: GUI: Fix banner color for v3 FM-Towns games 2022-11-28 23:21:45 +01:00
AndywinXp 415370598c SCUMM: GUI: Fix black screen glitches on FMTowns v3 games 2022-11-28 23:21:45 +01:00
AndywinXp 172bc2d4c4 SCUMM: GUI: Fix v3 FM-Towns games crashing on banner display 2022-11-28 23:21:45 +01:00
AndywinXp 5f9d6d7780 SCUMM: GUI: Fix v5 banner colors for Mac versions 2022-11-28 23:21:45 +01:00
Torbjörn Andersson bf0ecd47ff SCUMM: Implement message boxes for Mac Loom and Last Crusade
I'm committing this as is, while leaving final integration to someone
else. Note that this doesn't really replicate the original Mac GUI (e.g.
the quit dialog is nothing like the original), but at least the pause
dialog looks right. And that's what matters to me.
2022-11-28 23:21:45 +01:00
AndywinXp 213b49336a SCUMM: LOOM v3: Fix query quit banner 2022-11-28 23:21:45 +01:00
AndywinXp 9cb7293de3 SCUMM: Clean-up and implement remaining messages for v0-1-2-3 2022-11-28 23:21:45 +01:00
AndywinXp 13e7c9d4d9 SCUMM: Implement basic support for v0-3 GUI 2022-11-28 23:21:45 +01:00
Donovan Watteau a029ea203e SCUMM: Fix gfx_gui.cpp build with GCC 4.8 on OSX 10.5
This would give an "strnlen not declared in this scope" build error.

I guess we're not seeing this on our other builders because my compiler
is the only one not inlining strnlen or something like that.
2022-10-09 10:07:15 +02:00
athrxx dee25ecfc5 SCUMM: (SAM) - add dissolve effect when restarting with F8
SAM has this hard coded for the restart handling. I noticed it in an
emulator and then found it in the original code . Without that, the
game would show the box transition for the restart which is
not suitable for SAM (it is made for games with a separate
verb interface).
2022-10-08 16:57:07 +02:00
Donovan Watteau 80e134a912 SCUMM: Let it build again without ENABLE_SCUMM_7_8 2022-09-20 19:38:18 +02:00
athrxx 002e66485f SCUMM: fix array range check
The array has size 50 (also in the original interpreter), we also save/load 50
bytes. So the range check should not allow an array index > 49 (although the
original does that, too).
2022-09-19 18:14:54 +02:00
athrxx 87e20640e8 SCUMM: fix dead code warnings
For negative resStringId values, the functions would return from the
switch statement default, never meeting the <= 0 condition at the end.
2022-09-19 18:14:40 +02:00
AndywinXp e0a2dccd77 SCUMM: GUI: Save shake effect in showOldStyleBannerAndPause() 2022-09-08 19:10:42 +02:00
AndywinXp 3475e94b6c SCUMM: GUI: Remove unnecessary call to the cursor restoring routine 2022-09-08 19:10:42 +02:00
AndywinXp a71e03444e SCUMM: GUI: Fix menu closing after failed replace savestate prompt 2022-09-08 19:10:42 +02:00
AndywinXp 80a8b3cb17 SCUMM: GUI: Simplify the saving/restoring routines for the screen surfaces 2022-09-08 19:10:42 +02:00